From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Hyong Youb Kim <hyonkim@cisco.com>
Cc: dev@dpdk.org, John Daley <johndale@cisco.com>
Subject: Re: [PATCH v2 3/3] net/enic: allow multicast in MAC address add callback
Date: Thu, 8 Aug 2024 09:50:45 +0100 [thread overview]
Message-ID: <31184b17-5abd-4ac0-9266-b98bf1e42419@amd.com> (raw)
In-Reply-To: <20240808061433.14971-4-hyonkim@cisco.com>
On 8/8/2024 7:14 AM, Hyong Youb Kim wrote:
> enic_set_mac_address() (mac_addr_add callback) currently allows only
> non-zero, unicast address to be added. It is overly restrictive.
> rte_eth_dev_mac_addr_add() itself allows multicast addresses. And,
> some applications do use rte_eth_dev_mac_addr_add() to accept
> multicast addresses. So, remove the unicast check in
> enic_set_mac_address().
>
What is the usecase to set Multicast MAC address as device default MAC
address?
Also, just a reminder that we have 'rte_eth_dev_set_mc_addr_list()' API
to set multicast MAC addresses.
next prev parent reply other threads:[~2024-08-08 8:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 4:18 [PATCH 0/3] net/enic: support VF and fix minor issues Hyong Youb Kim
2024-08-08 4:18 ` [PATCH 1/3] net/enic: support SR-IOV VF using admin channel Hyong Youb Kim
2024-08-08 4:18 ` [PATCH 2/3] net/enic: add speed capabilities for newer models Hyong Youb Kim
2024-08-08 4:18 ` [PATCH 3/3] net/enic: allow multicast in MAC address add callback Hyong Youb Kim
2024-08-08 6:14 ` [PATCH v2 0/3] net/enic: support VF and fix minor issues Hyong Youb Kim
2024-08-08 6:14 ` [PATCH v2 1/3] net/enic: support SR-IOV VF using admin channel Hyong Youb Kim
2024-08-08 8:50 ` Ferruh Yigit
2024-08-09 6:27 ` Hyong Youb Kim (hyonkim)
2024-08-08 6:14 ` [PATCH v2 2/3] net/enic: add speed capabilities for newer models Hyong Youb Kim
2024-08-08 8:50 ` Ferruh Yigit
2024-08-09 6:28 ` Hyong Youb Kim (hyonkim)
2024-08-08 6:14 ` [PATCH v2 3/3] net/enic: allow multicast in MAC address add callback Hyong Youb Kim
2024-08-08 8:50 ` Ferruh Yigit [this message]
2024-08-09 6:49 ` Hyong Youb Kim (hyonkim)
2024-08-09 7:07 ` [PATCH v3 0/3] net/enic: support VF and fix minor issues Hyong Youb Kim
2024-08-09 7:07 ` [PATCH v3 1/3] net/enic: support SR-IOV VF using admin channel Hyong Youb Kim
2024-08-09 7:07 ` [PATCH v3 2/3] net/enic: add speed capabilities for newer models Hyong Youb Kim
2024-08-09 7:07 ` [PATCH v3 3/3] net/enic: allow multicast in MAC address add callback Hyong Youb Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31184b17-5abd-4ac0-9266-b98bf1e42419@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=hyonkim@cisco.com \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).