From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1330BA0562; Wed, 14 Apr 2021 11:42:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C968C1618EA; Wed, 14 Apr 2021 11:41:59 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id DA0421618E8; Wed, 14 Apr 2021 11:41:57 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 8547258056A; Wed, 14 Apr 2021 05:41:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 14 Apr 2021 05:41:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 4h+B/c1ZgV74c+qUBT+n8GIROpp805jxj45Lr3exddk=; b=HRoFJSvT5D40GNra +mQBZ4sZ0l0ju9nEmqXONAKNb36+KieObFpiT4yaZOXfRqOEyD/RXukQV8u1Ngi3 mTJa5tfVqyuUpFWQ+wBzbxp3SunXDUPJVgCPB3cnB1oxmPbjdjTZIJhg62CDObqj XeUOt1pSunyNCEKsoUFIOjVf8zv4uRFeC/tXMQPEpkotA0zG826Eje8R0k5GygAz XASKdW2nRZha+tqI3tCMpaBafExIYP7dE3sOJnXqvsQuA/OwWVrZQNwBhVsWgx24 C97nIx2VJmRz3RRyAuzZxsFdPueCab/YMWauqOrVhnfj5r9fRzp2KdnaMGki60+X QU68ew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4h+B/c1ZgV74c+qUBT+n8GIROpp805jxj45Lr3exd dk=; b=gZLcDi2dQ7eEkj3A6c879EnDJfIcpqBA3q6nZS8uuTTt8BFliMx0BZsWI y3F+NPepAquwZ8EEQ8uG4bCDidoS7qgIDBbBv+5toF2CDaOT7qZT9m01iQY6BaMh Xj/gOqexsoafLMzfaAjt6kU0JfeAcnQZKtEqJVnPsznfvRPlUwVt7Nodq7qK6AJ8 qIflzW8jsehcNtTQHJrWKltSz0FTNwPB0sFTvMwgn2QKCbLbLvbILcQulbVLibqL 7vTa9Zqcsu2FdzQRrfJk3r/d9qAIy0Gpc5S+CI1IvPVHDALGDaNRCMFbNB5scBud kKBMP6S+mQrjGeQjEU0DmPQVsKBnA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BD65D1080068; Wed, 14 Apr 2021 05:41:55 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, bluca@debian.org, dmitry.kozliuk@gmail.com, olivier.matz@6wind.com, thierry.herbelot@6wind.com, Gabriel Ganne , stable@dpdk.org, Harry van Haaren , Luca Boccassi , Keith Wiles , david.marchand@redhat.com Date: Wed, 14 Apr 2021 11:41:53 +0200 Message-ID: <3119483.LeJDoi8FaI@thomas> In-Reply-To: <20210409122551.265939-1-thomas@monjalon.net> References: <20210409083927.8345-1-gabriel.ganne@6wind.com> <20210409122551.265939-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] build: remove redundant libpcap link X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/04/2021 14:25, Thomas Monjalon: > From: Gabriel Ganne > > The pcap PMD and the librte_port both declare their dependency to libpcap > with a line "ext_deps += pcap_dep". > Then meson automatically adds this dependency to the pkg-config file > in the "Requires.private" section for static builds. > > The additional update of dpdk_extra_ldflags was adding the dependency > in the "Libs.private" section of the pkg-config, that is unnecessary. > > Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson") > Fixes: 268fa581b1ff ("port: fix pcap support with meson") > Cc: stable@dpdk.org > > Signed-off-by: Gabriel Ganne > Signed-off-by: Thomas Monjalon > --- > I have a doubt whether this option is really always useless. > In the case of an old pcap (<1.9) without pkg-config support, > and with the minimum meson supported (0.47.1), > are we sure the generated pkg-config file will include -lpcap? Any volunteer to test please?