[dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

[dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

[McDaniel, Timothy]

From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>

Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
---
 doc/guides/rel_notes/deprecation.rst |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d1034f6..6af9b40 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -130,3 +130,31 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* eventdev: Three public data structures will be updated in 20.11;
+  ``rte_event_dev_info``, ``rte_event_dev_config``, and
+  ``rte_event_port_conf``.
+  Two new members will be added to the ``rte_event_dev_info`` struct.
+  The first, max_event_port_links, will be a uint8_t, and represents the
+  maximum number of queues that can be linked to a single event port by
+  this device. The second, max_single_link_event_port_queue_pairs, will be a
+  uint8_t, and represents the maximum number of event ports and queues that
+  are optimized for (and only capable of) single-link configurations
+  supported by this device. These ports and queues are not accounted for in
+  max_event_ports or max_event_queues.
+  One new member will be added to the ``rte_event_dev_config`` struct. The
+  nb_single_link_event_port_queues member will be a uint8_t, and will
+  represent the number of event ports and queues that will be singly-linked
+  to each other. These are a subset of the overall event ports and queues.
+  This value cannot exceed nb_event_ports or nb_event_queues. If the
+  device has ports and queues that are optimized for single-link usage, this
+  field is a hint for how many to allocate; otherwise, regular event ports and
+  queues can be used.
+  Finally, the ``rte_event_port_conf`` struct will be
+  modified as follows. The uint8_t implicit_release_disabled field
+  will be replaced by a uint32_t event_port_cfg field. The new field will
+  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
+  will have the same meaning as implicit_release_disabled. The second bit,
+  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
+  to a single event queue.
+
-- 
1.7.10

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

[McDaniel, Timothy]

>-----Original Message-----
>From: McDaniel, Timothy <timothy.mcdaniel@intel.com>
>Sent: Thursday, July 2, 2020 5:14 PM
>To: dev@dpdk.org
>Cc: jerinj@marvell.com; Eads, Gage <gage.eads@intel.com>; Van Haaren, Harry
><harry.van.haaren@intel.com>; mdr@ashroe.eu; nhorman@tuxdriver.com; Rao,
>Nikhil <nikhil.rao@intel.com>; Carrillo, Erik G <Erik.G.Carrillo@intel.com>; Gujjar,
>Abhinandan S <abhinandan.gujjar@intel.com>; pbhagavatula@marvell.com;
>hemant.agrawal@nxp.com; mattias.ronnblom@ericsson.com; Mccarthy, Peter
><Peter.Mccarthy@intel.com>; McDaniel, Timothy
><timothy.mcdaniel@intel.com>
>Subject: [PATCH] doc: announce changes to eventdev public data structures
>
>From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
>
>Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
>---
> doc/guides/rel_notes/deprecation.rst |   28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
>diff --git a/doc/guides/rel_notes/deprecation.rst
>b/doc/guides/rel_notes/deprecation.rst
>index d1034f6..6af9b40 100644
>--- a/doc/guides/rel_notes/deprecation.rst
>+++ b/doc/guides/rel_notes/deprecation.rst
>@@ -130,3 +130,31 @@ Deprecation Notices
>   Python 2 support will be completely removed in 20.11.
>   In 20.08, explicit deprecation warnings will be displayed when running
>   scripts with Python 2.
>+
>+* eventdev: Three public data structures will be updated in 20.11;
>+  ``rte_event_dev_info``, ``rte_event_dev_config``, and
>+  ``rte_event_port_conf``.
>+  Two new members will be added to the ``rte_event_dev_info`` struct.
>+  The first, max_event_port_links, will be a uint8_t, and represents the
>+  maximum number of queues that can be linked to a single event port by
>+  this device. The second, max_single_link_event_port_queue_pairs, will be a
>+  uint8_t, and represents the maximum number of event ports and queues that
>+  are optimized for (and only capable of) single-link configurations
>+  supported by this device. These ports and queues are not accounted for in
>+  max_event_ports or max_event_queues.
>+  One new member will be added to the ``rte_event_dev_config`` struct. The
>+  nb_single_link_event_port_queues member will be a uint8_t, and will
>+  represent the number of event ports and queues that will be singly-linked
>+  to each other. These are a subset of the overall event ports and queues.
>+  This value cannot exceed nb_event_ports or nb_event_queues. If the
>+  device has ports and queues that are optimized for single-link usage, this
>+  field is a hint for how many to allocate; otherwise, regular event ports and
>+  queues can be used.
>+  Finally, the ``rte_event_port_conf`` struct will be
>+  modified as follows. The uint8_t implicit_release_disabled field
>+  will be replaced by a uint32_t event_port_cfg field. The new field will
>+  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
>+  will have the same meaning as implicit_release_disabled. The second bit,
>+  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
>+  to a single event queue.
>+
>--
>1.7.10

Hello Jerin and DPDK community.  Please review and approve the eventdev interface changes announced in this notice.

Thanks,
Tim

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

[Jerin Jacob]

On Thu, Jul 30, 2020 at 10:03 PM McDaniel, Timothy
<timothy.mcdaniel@intel.com> wrote:
>
>
> >-----Original Message-----
> >From: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> >Sent: Thursday, July 2, 2020 5:14 PM
> >To: dev@dpdk.org
> >Cc: jerinj@marvell.com; Eads, Gage <gage.eads@intel.com>; Van Haaren, Harry
> ><harry.van.haaren@intel.com>; mdr@ashroe.eu; nhorman@tuxdriver.com; Rao,
> >Nikhil <nikhil.rao@intel.com>; Carrillo, Erik G <Erik.G.Carrillo@intel.com>; Gujjar,
> >Abhinandan S <abhinandan.gujjar@intel.com>; pbhagavatula@marvell.com;
> >hemant.agrawal@nxp.com; mattias.ronnblom@ericsson.com; Mccarthy, Peter
> ><Peter.Mccarthy@intel.com>; McDaniel, Timothy
> ><timothy.mcdaniel@intel.com>
> >Subject: [PATCH] doc: announce changes to eventdev public data structures
> >
> >From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
> >
> >Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> >---
> > doc/guides/rel_notes/deprecation.rst |   28 ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> >diff --git a/doc/guides/rel_notes/deprecation.rst
> >b/doc/guides/rel_notes/deprecation.rst
> >index d1034f6..6af9b40 100644
> >--- a/doc/guides/rel_notes/deprecation.rst
> >+++ b/doc/guides/rel_notes/deprecation.rst
> >@@ -130,3 +130,31 @@ Deprecation Notices
> >   Python 2 support will be completely removed in 20.11.
> >   In 20.08, explicit deprecation warnings will be displayed when running
> >   scripts with Python 2.
> >+
> >+* eventdev: Three public data structures will be updated in 20.11;
> >+  ``rte_event_dev_info``, ``rte_event_dev_config``, and
> >+  ``rte_event_port_conf``.
> >+  Two new members will be added to the ``rte_event_dev_info`` struct.
> >+  The first, max_event_port_links, will be a uint8_t, and represents the
> >+  maximum number of queues that can be linked to a single event port by
> >+  this device. The second, max_single_link_event_port_queue_pairs, will be a
> >+  uint8_t, and represents the maximum number of event ports and queues that
> >+  are optimized for (and only capable of) single-link configurations
> >+  supported by this device. These ports and queues are not accounted for in
> >+  max_event_ports or max_event_queues.
> >+  One new member will be added to the ``rte_event_dev_config`` struct. The
> >+  nb_single_link_event_port_queues member will be a uint8_t, and will
> >+  represent the number of event ports and queues that will be singly-linked
> >+  to each other. These are a subset of the overall event ports and queues.
> >+  This value cannot exceed nb_event_ports or nb_event_queues. If the
> >+  device has ports and queues that are optimized for single-link usage, this
> >+  field is a hint for how many to allocate; otherwise, regular event ports and
> >+  queues can be used.
> >+  Finally, the ``rte_event_port_conf`` struct will be
> >+  modified as follows. The uint8_t implicit_release_disabled field
> >+  will be replaced by a uint32_t event_port_cfg field. The new field will
> >+  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
> >+  will have the same meaning as implicit_release_disabled. The second bit,
> >+  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
> >+  to a single event queue.
> >+
> >--
> >1.7.10
>
> Hello Jerin and DPDK community.  Please review and approve the eventdev interface changes announced in this notice.

Changes look good to me in general. Could you reword the description
such way or similar like below to accommodate
1) DLB PMD requirements
2) Future extensions[1]

I think, We don't need exact mention the data structure member additions,
(This is to get the flexibility on additions/deletion on member fields
after the patch rework)

something like:

eventdev: ABI change to support DLB  PMD and future extensions

The following structures and will be modified to support to DLB PMD and future
extension in the eventdev library.

And then please enumerate the structures[2] of your patch which needs change,
[2]``rte_event_dev_info``, ``rte_event_dev_config``, and
``rte_event_port_conf``
and structures in [1]. Please mention the patches [1] and your spec change patch
as a reference in the description.


[1]
http://patches.dpdk.org/patch/72786/
http://patches.dpdk.org/patch/72787/
>
> Thanks,
> Tim

[dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

[McDaniel, Timothy]

From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>

Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
---
 doc/guides/rel_notes/deprecation.rst |   37 +++++++++-------------------------
 1 file changed, 10 insertions(+), 27 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ecb1bc4..4809643 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -149,30 +149,13 @@ Deprecation Notices
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
 
-* eventdev: Three public data structures will be updated in 20.11;
-  ``rte_event_dev_info``, ``rte_event_dev_config``, and
-  ``rte_event_port_conf``.
-  Two new members will be added to the ``rte_event_dev_info`` struct.
-  The first, max_event_port_links, will be a uint8_t, and represents the
-  maximum number of queues that can be linked to a single event port by
-  this device. The second, max_single_link_event_port_queue_pairs, will be a
-  uint8_t, and represents the maximum number of event ports and queues that
-  are optimized for (and only capable of) single-link configurations
-  supported by this device. These ports and queues are not accounted for in
-  max_event_ports or max_event_queues.
-  One new member will be added to the ``rte_event_dev_config`` struct. The
-  nb_single_link_event_port_queues member will be a uint8_t, and will
-  represent the number of event ports and queues that will be singly-linked
-  to each other. These are a subset of the overall event ports and queues.
-  This value cannot exceed nb_event_ports or nb_event_queues. If the
-  device has ports and queues that are optimized for single-link usage, this
-  field is a hint for how many to allocate; otherwise, regular event ports and
-  queues can be used.
-  Finally, the ``rte_event_port_conf`` struct will be
-  modified as follows. The uint8_t implicit_release_disabled field
-  will be replaced by a uint32_t event_port_cfg field. The new field will
-  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
-  will have the same meaning as implicit_release_disabled. The second bit,
-  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
-  to a single event queue.
-
+* eventdev: ABI change to support DLB PMD and future extensions
+  The following structures and will be modified to support to DLB PMD and future
+  extension in the eventdev library.
+  - ``rte_event_dev_info``
+  - ``rte_event_dev_config``
+  - ``rte_event_port_conf``
+  Patches containing justification, documentation, and proposed modifications
+  can be found at
+  - https://patches.dpdk.org/patch/71457/
+  - https://patches.dpdk.org/patch/71456/
-- 
1.7.10

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

[Jerin Jacob]

On Sat, Aug 1, 2020 at 12:24 AM McDaniel, Timothy
<timothy.mcdaniel@intel.com> wrote:
>
> From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
>
> Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst |   37 +++++++++-------------------------
>  1 file changed, 10 insertions(+), 27 deletions(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ecb1bc4..4809643 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -149,30 +149,13 @@ Deprecation Notices
>    In 20.08, explicit deprecation warnings will be displayed when running
>    scripts with Python 2.
>
> -* eventdev: Three public data structures will be updated in 20.11;
> -  ``rte_event_dev_info``, ``rte_event_dev_config``, and
> -  ``rte_event_port_conf``.
> -  Two new members will be added to the ``rte_event_dev_info`` struct.
> -  The first, max_event_port_links, will be a uint8_t, and represents the
> -  maximum number of queues that can be linked to a single event port by
> -  this device. The second, max_single_link_event_port_queue_pairs, will be a
> -  uint8_t, and represents the maximum number of event ports and queues that
> -  are optimized for (and only capable of) single-link configurations
> -  supported by this device. These ports and queues are not accounted for in
> -  max_event_ports or max_event_queues.
> -  One new member will be added to the ``rte_event_dev_config`` struct. The
> -  nb_single_link_event_port_queues member will be a uint8_t, and will
> -  represent the number of event ports and queues that will be singly-linked
> -  to each other. These are a subset of the overall event ports and queues.
> -  This value cannot exceed nb_event_ports or nb_event_queues. If the
> -  device has ports and queues that are optimized for single-link usage, this
> -  field is a hint for how many to allocate; otherwise, regular event ports and
> -  queues can be used.
> -  Finally, the ``rte_event_port_conf`` struct will be
> -  modified as follows. The uint8_t implicit_release_disabled field
> -  will be replaced by a uint32_t event_port_cfg field. The new field will
> -  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
> -  will have the same meaning as implicit_release_disabled. The second bit,
> -  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
> -  to a single event queue.

Remove this section. It is a duplicate of the below section. One
deprecation notice is enough.

> -
> +* eventdev: ABI change to support DLB PMD and future extensions
> +  The following structures and will be modified to support to DLB PMD and future
> +  extension in the eventdev library.
> +  - ``rte_event_dev_info``
> +  - ``rte_event_dev_config``
> +  - ``rte_event_port_conf``
> +  Patches containing justification, documentation, and proposed modifications
> +  can be found at
> +  - https://patches.dpdk.org/patch/71457/
> +  - https://patches.dpdk.org/patch/71456/
> --
> 1.7.10
>

[dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

[McDaniel, Timothy]

From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>

Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
---
 doc/guides/rel_notes/deprecation.rst |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 99c9806..b9682a7 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -148,3 +148,14 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* eventdev: ABI change to support DLB PMD and future extensions
+  The following structures and will be modified to support to DLB PMD and future
+  extension in the eventdev library.
+  - ``rte_event_dev_info``
+  - ``rte_event_dev_config``
+  - ``rte_event_port_conf``
+  Patches containing justification, documentation, and proposed modifications
+  can be found at:
+  - https://patches.dpdk.org/patch/71457/
+  - https://patches.dpdk.org/patch/71456/
-- 
1.7.10

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

[Jerin Jacob]

On Sat, Aug 1, 2020 at 1:04 AM McDaniel, Timothy
<timothy.mcdaniel@intel.com> wrote:
>
> From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>

The patch should have some description and
Please change the subject to: "doc: eventdev ABI change to support DLB PMD"

>
> Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>

We don't use "," in the Signed-off-by.
Please change to ``Signed-off-by: McDaniel Timothy
<timothy.mcdaniel@intel.com>``

> ---
>  doc/guides/rel_notes/deprecation.rst |   11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 99c9806..b9682a7 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -148,3 +148,14 @@ Deprecation Notices
>    Python 2 support will be completely removed in 20.11.
>    In 20.08, explicit deprecation warnings will be displayed when running
>    scripts with Python 2.
> +
> +* eventdev: ABI change to support DLB PMD and future extensions
> +  The following structures and will be modified to support to DLB PMD and future
> +  extension in the eventdev library.
> +  - ``rte_event_dev_info``
> +  - ``rte_event_dev_config``
> +  - ``rte_event_port_conf``
> +  Patches containing justification, documentation, and proposed modifications
> +  can be found at:
> +  - https://patches.dpdk.org/patch/71457/
> +  - https://patches.dpdk.org/patch/71456/

The HTML rendering of the above text is not proper.
Please run  "make doc-guides-html" to check generated HTML output.

You could use the below text as an example for sphinx syntax.

* eventdev: ABI change to support DLB PMD and future extensions:
  ``rte_event_dev_info``, ``rte_event_dev_config``, ``rte_event_port_conf`` will
  be modified to support to DLB PMD and future extension in the
eventdev library.
  Patches containing justification, documentation, and proposed modifications
  can be found at:

  - https://patches.dpdk.org/patch/71457/
  - https://patches.dpdk.org/patch/71456/

With the above changes:

Acked-by: Jerin Jacob <jerinj@marvell.com>


> --
> 1.7.10
>

[dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

[McDaniel, Timothy]

From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>

The ABI changes associated with this notification will better support
devices that:
1. Have limits on the number or queues that may be linked to a port
2. Have ports that are limited to exactly one linked queue
3. Are not able to transparently transfer the event flow_id field

Signed-off-by: McDaniel Timothy
<timothy.mcdaniel@intel.com>
---
 doc/guides/rel_notes/deprecation.rst |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 99c9806..bfe6661 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -148,3 +148,14 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* eventdev: ABI changes to support DLB PMD and future extensions:
+  ``rte_event_dev_info``, ``rte_event_dev_config``, ``rte_event_port_conf`` will
+  be modified to support DLB PMD and future extensions in the eventdev library.
+  Patches containing justification, documentation, and proposed modifications
+  can be found at:
+
+  - https://patches.dpdk.org/patch/71457/
+  - https://patches.dpdk.org/patch/71456/
+
+
-- 
1.7.10

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

[Jerin Jacob]

On Mon, Aug 3, 2020 at 11:28 PM McDaniel, Timothy
<timothy.mcdaniel@intel.com> wrote:
>
> From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>

There is still "," in the name.

>
> The ABI changes associated with this notification will better support
> devices that:
> 1. Have limits on the number or queues that may be linked to a port
> 2. Have ports that are limited to exactly one linked queue
> 3. Are not able to transparently transfer the event flow_id field
>
> Signed-off-by: McDaniel Timothy
> <timothy.mcdaniel@intel.com>


Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  doc/guides/rel_notes/deprecation.rst |   11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 99c9806..bfe6661 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -148,3 +148,14 @@ Deprecation Notices
>    Python 2 support will be completely removed in 20.11.
>    In 20.08, explicit deprecation warnings will be displayed when running
>    scripts with Python 2.
> +
> +* eventdev: ABI changes to support DLB PMD and future extensions:
> +  ``rte_event_dev_info``, ``rte_event_dev_config``, ``rte_event_port_conf`` will
> +  be modified to support DLB PMD and future extensions in the eventdev library.
> +  Patches containing justification, documentation, and proposed modifications
> +  can be found at:
> +
> +  - https://patches.dpdk.org/patch/71457/
> +  - https://patches.dpdk.org/patch/71456/
> +
> +
> --
> 1.7.10
>

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

[Van Haaren, Harry]

> -----Original Message-----
> From: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Sent: Monday, August 3, 2020 6:56 PM
> To: jerinj@marvell.com
> Cc: mattias.ronnblom@ericsson.com; dev@dpdk.org; Eads, Gage
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Subject: [PATCH] doc: eventdev ABI change to support DLB PMD
> 
> From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
> 
> The ABI changes associated with this notification will better support
> devices that:
> 1. Have limits on the number or queues that may be linked to a port
> 2. Have ports that are limited to exactly one linked queue
> 3. Are not able to transparently transfer the event flow_id field
> 
> Signed-off-by: McDaniel Timothy
> <timothy.mcdaniel@intel.com>

Nitpick: git warns on added extra new blank line at end of file.

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

<snip>

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

[Hemant Agrawal]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Jerin Jacob
> Sent: Tuesday, August 4, 2020 1:09 PM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Cc: Jerin Jacob <jerinj@marvell.com>; Mattias Rönnblom
> <mattias.ronnblom@ericsson.com>; dpdk-dev <dev@dpdk.org>; Gage Eads
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB
> PMD
> 
> On Mon, Aug 3, 2020 at 11:28 PM McDaniel, Timothy
> <timothy.mcdaniel@intel.com> wrote:
> >
> > From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
> 
> There is still "," in the name.
> 
> >
> > The ABI changes associated with this notification will better support
> > devices that:
> > 1. Have limits on the number or queues that may be linked to a port 2.
> > Have ports that are limited to exactly one linked queue 3. Are not
> > able to transparently transfer the event flow_id field
> >
> > Signed-off-by: McDaniel Timothy
> > <timothy.mcdaniel@intel.com>
> 
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> 
> > ---
> >  doc/guides/rel_notes/deprecation.rst |   11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 99c9806..bfe6661 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -148,3 +148,14 @@ Deprecation Notices
> >    Python 2 support will be completely removed in 20.11.
> >    In 20.08, explicit deprecation warnings will be displayed when running
> >    scripts with Python 2.
> > +
> > +* eventdev: ABI changes to support DLB PMD and future extensions:
> > +  ``rte_event_dev_info``, ``rte_event_dev_config``,
> > +``rte_event_port_conf`` will
> > +  be modified to support DLB PMD and future extensions in the eventdev
> library.
> > +  Patches containing justification, documentation, and proposed
> > +modifications
> > +  can be found at:
> > +
> > +  -
> > +
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> > +
> tches.dpdk.org%2Fpatch%2F71457%2F&amp;data=02%7C01%7Chemant.agra
> wal%
> > +
> 40nxp.com%7C0a8caadf8d834b79220b08d838497b8b%7C686ea1d3bc2b4c6fa
> 92cd
> > +
> 99c5c301635%7C0%7C0%7C637321235549807830&amp;sdata=9cH1qyDLlJz%2
> BNoI
> > + whoam9rzpuMKGqZJWG6lMDkuoy1A%3D&amp;reserved=0
> > +  -
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> es.dpdk.org%2Fpatch%2F71456%2F&amp;data=02%7C01%7Chemant.agrawa
> l%40nxp.com%7C0a8caadf8d834b79220b08d838497b8b%7C686ea1d3bc2b4c6
> fa92cd99c5c301635%7C0%7C0%7C637321235549817822&amp;sdata=dHNynX
> 75PGfiOtIycdm4raCRt5MWQPTWgHi%2Bj9Q331A%3D&amp;reserved=0
> > +
> > +
> > --
> > 1.7.10
> >

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

[Kinsella, Ray]

On 02/07/2020 23:13, McDaniel, Timothy wrote:
> From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
> 
> Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst |   28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index d1034f6..6af9b40 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -130,3 +130,31 @@ Deprecation Notices
>    Python 2 support will be completely removed in 20.11.
>    In 20.08, explicit deprecation warnings will be displayed when running
>    scripts with Python 2.
> +
> +* eventdev: Three public data structures will be updated in 20.11;
> +  ``rte_event_dev_info``, ``rte_event_dev_config``, and
> +  ``rte_event_port_conf``.

At a minimum a sub-bullet here for each of the public data structures, 
would a gift to readability. 

> +  Two new members will be added to the ``rte_event_dev_info`` struct.
> +  The first, max_event_port_links, will be a uint8_t, and represents the
> +  maximum number of queues that can be linked to a single event port by
> +  this device. The second, max_single_link_event_port_queue_pairs, will be a
> +  uint8_t, and represents the maximum number of event ports and queues that
> +  are optimized for (and only capable of) single-link configurations
> +  supported by this device. These ports and queues are not accounted for in
> +  max_event_ports or max_event_queues.
> +  One new member will be added to the ``rte_event_dev_config`` struct. The
> +  nb_single_link_event_port_queues member will be a uint8_t, and will
> +  represent the number of event ports and queues that will be singly-linked
> +  to each other. These are a subset of the overall event ports and queues.
> +  This value cannot exceed nb_event_ports or nb_event_queues. If the
> +  device has ports and queues that are optimized for single-link usage, this
> +  field is a hint for how many to allocate; otherwise, regular event ports and
> +  queues can be used.
> +  Finally, the ``rte_event_port_conf`` struct will be
> +  modified as follows. The uint8_t implicit_release_disabled field
> +  will be replaced by a uint32_t event_port_cfg field. The new field will
> +  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
> +  will have the same meaning as implicit_release_disabled. The second bit,
> +  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
> +  to a single event queue.
> +
> 

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

[Thomas Monjalon]

> > > From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
> > 
> > There is still "," in the name.
> > 
> > >
> > > The ABI changes associated with this notification will better support
> > > devices that:
> > > 1. Have limits on the number or queues that may be linked to a port 2.
> > > Have ports that are limited to exactly one linked queue 3. Are not
> > > able to transparently transfer the event flow_id field
> > >
> > > Signed-off-by: McDaniel Timothy
> > > <timothy.mcdaniel@intel.com>
> > 
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Applied with name fixed, thanks

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

[Thomas Monjalon]

05/08/2020 11:36, Kinsella, Ray:
> 
> On 02/07/2020 23:13, McDaniel, Timothy wrote:
> > From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
> > 
> > Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst |   28 ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> > 
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index d1034f6..6af9b40 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -130,3 +130,31 @@ Deprecation Notices
> >    Python 2 support will be completely removed in 20.11.
> >    In 20.08, explicit deprecation warnings will be displayed when running
> >    scripts with Python 2.
> > +
> > +* eventdev: Three public data structures will be updated in 20.11;
> > +  ``rte_event_dev_info``, ``rte_event_dev_config``, and
> > +  ``rte_event_port_conf``.
> 
> At a minimum a sub-bullet here for each of the public data structures, 
> would a gift to readability.

I've converted the list into bullets while applying.

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

[McDaniel, Timothy]

>-----Original Message-----
>From: Thomas Monjalon <thomas@monjalon.net>
>Sent: Wednesday, August 5, 2020 6:40 PM
>To: McDaniel, Timothy <timothy.mcdaniel@intel.com>
>Cc: Jerin Jacob <jerinjacobk@gmail.com>; dev@dpdk.org; Jerin Jacob
><jerinj@marvell.com>; Mattias Rönnblom <mattias.ronnblom@ericsson.com>;
>Eads, Gage <gage.eads@intel.com>; Van Haaren, Harry
><harry.van.haaren@intel.com>; Hemant Agrawal <hemant.agrawal@nxp.com>
>Subject: Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD
>
>> > > From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
>> >
>> > There is still "," in the name.
>> >
>> > >
>> > > The ABI changes associated with this notification will better support
>> > > devices that:
>> > > 1. Have limits on the number or queues that may be linked to a port 2.
>> > > Have ports that are limited to exactly one linked queue 3. Are not
>> > > able to transparently transfer the event flow_id field
>> > >
>> > > Signed-off-by: McDaniel Timothy
>> > > <timothy.mcdaniel@intel.com>
>> >
>Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
>> > Acked-by: Jerin Jacob <jerinj@marvell.com>
>> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
>Applied with name fixed, thanks
>

Thank you Thomas!

Tim