[dpdk-dev] [PATCH] app/test-crypto-perf: fix gcc compilation under FreeBSD

[dpdk-dev] [PATCH] app/test-crypto-perf: fix gcc compilation under FreeBSD

[Daniel Mrzyglod]

this fix error: implicit declaration of function 'getline'

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 app/test-crypto-perf/cperf_test_vector_parsing.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c
index e0bcb20..c53ba67 100644
--- a/app/test-crypto-perf/cperf_test_vector_parsing.c
+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c
@@ -1,3 +1,6 @@
+#ifdef RTE_EXEC_ENV_BSDAPP
+	#define _WITH_GETLINE
+#endif
 #include <stdio.h>
 
 #include <rte_malloc.h>
-- 
2.7.4

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix gcc compilation under FreeBSD

[De Lara Guarch, Pablo]

Hi Daniel,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod
> Sent: Wednesday, February 01, 2017 1:31 PM
> To: Mrozowicz, SlawomirX
> Cc: dev@dpdk.org; Mrzyglod, DanielX T
> Subject: [dpdk-dev] [PATCH] app/test-crypto-perf: fix gcc compilation under
> FreeBSD
> 
> this fix error: implicit declaration of function 'getline'

Could you add a Fixline for this?
Also, make sure your commit message starts with capital latter "This patch fixes error.."

Thanks,
Pablo

[dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation under FreeBSD

[Daniel Mrzyglod]

This patch fixes error: implicit declaration of function 'getline'

Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
v2:
* rewrite patch messege
* add fixline
---
 app/test-crypto-perf/cperf_test_vector_parsing.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c
index e0bcb20..c53ba67 100644
--- a/app/test-crypto-perf/cperf_test_vector_parsing.c
+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c
@@ -1,3 +1,6 @@
+#ifdef RTE_EXEC_ENV_BSDAPP
+	#define _WITH_GETLINE
+#endif
 #include <stdio.h>
 
 #include <rte_malloc.h>
-- 
2.7.4

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation under FreeBSD

[Thomas Monjalon]

Hi,

The error is not specific to GCC.
I can reproduce it with x86_64-native-bsdapp-clang.

2017-02-02 14:41, Daniel Mrzyglod:
> This patch fixes error: implicit declaration of function 'getline'
> 
> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>

I am interested to understand how such error can happen with the
recent integration of build checks in patchwork.
Have you received any automatic mail about the compilation error?
Do you think setting colors (green/orange/red) in the columns S/W/F
would help?

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation under FreeBSD

[Mrzyglod, DanielX T]

>-----Original Message-----
>From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>Sent: Thursday, February 02, 2017 2:57 PM
>To: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>; Mrozowicz, SlawomirX
><slawomirx.mrozowicz@intel.com>; De Lara Guarch, Pablo
><pablo.de.lara.guarch@intel.com>
>Cc: dev@dpdk.org
>Subject: Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation
>under FreeBSD
>
>Hi,
>
>The error is not specific to GCC.
>I can reproduce it with x86_64-native-bsdapp-clang.
>
I can reproduce it only at FreeBSD 10.3 gcc48

I have mindblow about it.
When you see patchwork report:
http://dpdk.org/dev/patchwork/patch/19998/   -  Everything is ok. 
But it isn't due to daily raport: http://dpdk.org/ml/archives/test-report/2017-January/010203.html

For clang it was working so I prepared patch for gcc.

>2017-02-02 14:41, Daniel Mrzyglod:
>> This patch fixes error: implicit declaration of function 'getline'
>>
>> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
>application")
>>
>> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>
>I am interested to understand how such error can happen with the
>recent integration of build checks in patchwork.
>Have you received any automatic mail about the compilation error?
>Do you think setting colors (green/orange/red) in the columns S/W/F
>would help?

We didn't get any error raport about this patchseries - so I think there may be some errors in DPDK's patchwork build environment .
Everybody like colors but it's not critical :>

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation under FreeBSD

[De Lara Guarch, Pablo]

Hi Thomas,

> -----Original Message-----
> From: Mrzyglod, DanielX T
> Sent: Thursday, February 02, 2017 3:18 PM
> To: Thomas Monjalon; Mrozowicz, SlawomirX; De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation
> under FreeBSD
> 
> 
> 
> >-----Original Message-----
> >From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> >Sent: Thursday, February 02, 2017 2:57 PM
> >To: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>; Mrozowicz,
> SlawomirX
> ><slawomirx.mrozowicz@intel.com>; De Lara Guarch, Pablo
> ><pablo.de.lara.guarch@intel.com>
> >Cc: dev@dpdk.org
> >Subject: Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc
> compilation
> >under FreeBSD
> >
> >Hi,
> >
> >The error is not specific to GCC.
> >I can reproduce it with x86_64-native-bsdapp-clang.
> >
> I can reproduce it only at FreeBSD 10.3 gcc48
> 
> I have mindblow about it.
> When you see patchwork report:
> http://dpdk.org/dev/patchwork/patch/19998/   -  Everything is ok.
> But it isn't due to daily raport: http://dpdk.org/ml/archives/test-
> report/2017-January/010203.html
> 
> For clang it was working so I prepared patch for gcc.

Could you say which clang version you have?
In patch report, clang version on FreeBSD is 3.4.1, and compilation is OK.
We might need to include a newer one.

> 
> >2017-02-02 14:41, Daniel Mrzyglod:
> >> This patch fixes error: implicit declaration of function 'getline'
> >>
> >> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> >application")
> >>
> >> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> >
> >I am interested to understand how such error can happen with the
> >recent integration of build checks in patchwork.
> >Have you received any automatic mail about the compilation error?
> >Do you think setting colors (green/orange/red) in the columns S/W/F
> >would help?
> 
> We didn't get any error raport about this patchseries - so I think there may
> be some errors in DPDK's patchwork build environment .
> Everybody like colors but it's not critical :>
> 

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation under FreeBSD

[Mrzyglod, DanielX T]

>-----Original Message-----
>From: De Lara Guarch, Pablo
>Sent: Friday, February 03, 2017 12:31 PM
>To: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>; Thomas Monjalon
><thomas.monjalon@6wind.com>; Mrozowicz, SlawomirX
><slawomirx.mrozowicz@intel.com>
>Cc: dev@dpdk.org
>Subject: RE: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation
>under FreeBSD
>
>Hi Thomas,
>
>> -----Original Message-----
>> From: Mrzyglod, DanielX T
>> Sent: Thursday, February 02, 2017 3:18 PM
>> To: Thomas Monjalon; Mrozowicz, SlawomirX; De Lara Guarch, Pablo
>> Cc: dev@dpdk.org
>> Subject: RE: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation
>> under FreeBSD
>>
>>
>>
>> >-----Original Message-----
>> >From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>> >Sent: Thursday, February 02, 2017 2:57 PM
>> >To: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>; Mrozowicz,
>> SlawomirX
>> ><slawomirx.mrozowicz@intel.com>; De Lara Guarch, Pablo
>> ><pablo.de.lara.guarch@intel.com>
>> >Cc: dev@dpdk.org
>> >Subject: Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc
>> compilation
>> >under FreeBSD
>> >
>> >Hi,
>> >
>> >The error is not specific to GCC.
>> >I can reproduce it with x86_64-native-bsdapp-clang.
>> >
>> I can reproduce it only at FreeBSD 10.3 gcc48
>>
>> I have mindblow about it.
>> When you see patchwork report:
>> http://dpdk.org/dev/patchwork/patch/19998/   -  Everything is ok.
>> But it isn't due to daily raport: http://dpdk.org/ml/archives/test-
>> report/2017-January/010203.html
>>
>> For clang it was working so I prepared patch for gcc.
>
>Could you say which clang version you have?
>In patch report, clang version on FreeBSD is 3.4.1, and compilation is OK.
>We might need to include a newer one.
>

Today I reproduced it  also at clang 3.8 & 3.4.1 on fresh git clone so Thomas was right.
Today I add clang-3.8 5 to vm and 3.4.1 compilation stopped working.
The patch name could be changed to "fix compilation under FreeBSD"

>>
>> >2017-02-02 14:41, Daniel Mrzyglod:
>> >> This patch fixes error: implicit declaration of function 'getline'
>> >>
>> >> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
>> >application")
>> >>
>> >> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>> >
>> >I am interested to understand how such error can happen with the
>> >recent integration of build checks in patchwork.
>> >Have you received any automatic mail about the compilation error?
>> >Do you think setting colors (green/orange/red) in the columns S/W/F
>> >would help?
>>
>> We didn't get any error raport about this patchseries - so I think there may
>> be some errors in DPDK's patchwork build environment .
>> Everybody like colors but it's not critical :>
>>

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation under FreeBSD

[De Lara Guarch, Pablo]

Hi Daniel,

> -----Original Message-----
> From: Mrzyglod, DanielX T
> Sent: Friday, February 03, 2017 12:10 PM
> To: De Lara Guarch, Pablo; Thomas Monjalon; Mrozowicz, SlawomirX
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation
> under FreeBSD
> 
> 
> 
> >-----Original Message-----
> >From: De Lara Guarch, Pablo
> >Sent: Friday, February 03, 2017 12:31 PM
> >To: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>; Thomas
> Monjalon
> ><thomas.monjalon@6wind.com>; Mrozowicz, SlawomirX
> ><slawomirx.mrozowicz@intel.com>
> >Cc: dev@dpdk.org
> >Subject: RE: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc
> compilation
> >under FreeBSD
> >
> >Hi Thomas,
> >
> >> -----Original Message-----
> >> From: Mrzyglod, DanielX T
> >> Sent: Thursday, February 02, 2017 3:18 PM
> >> To: Thomas Monjalon; Mrozowicz, SlawomirX; De Lara Guarch, Pablo
> >> Cc: dev@dpdk.org
> >> Subject: RE: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc
> compilation
> >> under FreeBSD
> >>
> >>
> >>
> >> >-----Original Message-----
> >> >From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> >> >Sent: Thursday, February 02, 2017 2:57 PM
> >> >To: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>; Mrozowicz,
> >> SlawomirX
> >> ><slawomirx.mrozowicz@intel.com>; De Lara Guarch, Pablo
> >> ><pablo.de.lara.guarch@intel.com>
> >> >Cc: dev@dpdk.org
> >> >Subject: Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc
> >> compilation
> >> >under FreeBSD
> >> >
> >> >Hi,
> >> >
> >> >The error is not specific to GCC.
> >> >I can reproduce it with x86_64-native-bsdapp-clang.
> >> >
> >> I can reproduce it only at FreeBSD 10.3 gcc48
> >>
> >> I have mindblow about it.
> >> When you see patchwork report:
> >> http://dpdk.org/dev/patchwork/patch/19998/   -  Everything is ok.
> >> But it isn't due to daily raport: http://dpdk.org/ml/archives/test-
> >> report/2017-January/010203.html
> >>
> >> For clang it was working so I prepared patch for gcc.
> >
> >Could you say which clang version you have?
> >In patch report, clang version on FreeBSD is 3.4.1, and compilation is OK.
> >We might need to include a newer one.
> >
> 
> Today I reproduced it  also at clang 3.8 & 3.4.1 on fresh git clone so Thomas
> was right.
> Today I add clang-3.8 5 to vm and 3.4.1 compilation stopped working.
> The patch name could be changed to "fix compilation under FreeBSD"

Could you send a newer version then?

Thanks,
Pablo

[dpdk-dev] [PATCH v3] app/test-crypto-perf: fix compilation under FreeBSD

[Daniel Mrzyglod]

This patch fixes error: implicit declaration of function 'getline'

Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
v3:
* remove gcc from commit subject because it's common for all compillers

v2:
* rewrite patch messege
* add fixline
---
 app/test-crypto-perf/cperf_test_vector_parsing.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c
index e0bcb20..c53ba67 100644
--- a/app/test-crypto-perf/cperf_test_vector_parsing.c
+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c
@@ -1,3 +1,6 @@
+#ifdef RTE_EXEC_ENV_BSDAPP
+	#define _WITH_GETLINE
+#endif
 #include <stdio.h>
 
 #include <rte_malloc.h>
-- 
2.7.4

Re: [dpdk-dev] [PATCH v3] app/test-crypto-perf: fix compilation under FreeBSD

[Thomas Monjalon]

2017-02-07 10:44, Daniel Mrzyglod:
> This patch fixes error: implicit declaration of function 'getline'
> 
> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>

Applied, thanks