DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <gakhil@marvell.com>,
	"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	ray.kinsella@intel.com, david.marchand@redhat.com
Subject: Re: [EXT] [PATCH] crypto: fix misspelled key in qt format
Date: Fri, 25 Feb 2022 18:56:20 +0100	[thread overview]
Message-ID: <3125054.AJdgDx1Vlc@thomas> (raw)
In-Reply-To: <PH0PR11MB50130035D150DC585F258E8A9F379@PH0PR11MB5013.namprd11.prod.outlook.com>

18/02/2022 07:11, Kusztal, ArkadiuszX:
> From: Akhil Goyal <gakhil@marvell.com>
> > Fix ABI warning.
> > Add libabigail.abiignore rule.
> 
> I think what is worth noticing is a fact that after "random 'k' patch" addition of
> [suppress_type]
>         name = rte_crypto_asym_op
> this problem does not show up.
> 
> But I think it is safer to send addition of
> [suppress_type]
>         name = rte_crypto_rsa_priv_key_type
> anyway.
> Will send v2.

I don't understand why adding this rule,
and the comment does say nothing about it:
	"Ignore name change of rsa qt key type"

The ABI check is fine without above because of this existing exception:

; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental
[suppress_type]
        name = rte_crypto_asym_op

So I will just drop the unjustified additional exception while pulling.

Next time, please make sure such ABI exception is approved by more maintainers.



  reply	other threads:[~2022-02-25 17:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 10:25 Arek Kusztal
2022-02-12 11:34 ` [EXT] " Akhil Goyal
2022-02-18  6:11   ` Kusztal, ArkadiuszX
2022-02-25 17:56     ` Thomas Monjalon [this message]
2022-02-25 19:35       ` Ray Kinsella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3125054.AJdgDx1Vlc@thomas \
    --to=thomas@monjalon.net \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=ray.kinsella@intel.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).