DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Olivier MATZ <olivier.matz@6wind.com>,
	dev@dpdk.org, keith.wiles@intel.com,
	Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v3] mempool: rename functions with confusing names
Date: Fri, 01 Jul 2016 12:21:17 +0200	[thread overview]
Message-ID: <3129755.jsp6WimcDp@xps13> (raw)
In-Reply-To: <3fc02727-50d2-a6b6-8dcc-8c8d6a0b1d89@6wind.com>

2016-07-01 10:57, Olivier MATZ:
> 
> On 06/30/2016 10:05 PM, Thomas Monjalon wrote:
> > 2016-06-30 13:49, Bruce Richardson:
> >> The mempool_count and mempool_free_count behaved contrary to what their
> >> names suggested. The free_count function actually returned the number of
> >> elements that were allocated from the pool, not the number unallocated as
> >> the name implied.
> >>
> >> Fix this by introducing two new functions to replace the old ones,
> >> * rte_mempool_avail_count to replace rte_mempool_count
> >> * rte_mempool_in_use_count to replace rte_mempool_free_count
> >>
> >> In this patch, the new functions are added, and the old ones are marked
> >> as deprecated. All apps and examples that use the old functions are
> >> updated to use the new functions.
> > 
> > The ThunderX driver uses rte_mempool_count and needs an update.
> > Except that, it looks good.
> > 
> 
> Yep, I don't see any other issue.

Applied with ThunderX update, thanks

      reply	other threads:[~2016-07-01 10:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 13:55 [dpdk-dev] [PATCH] " Bruce Richardson
2016-06-29 15:55 ` Thomas Monjalon
2016-06-29 16:00   ` Bruce Richardson
2016-06-29 16:02     ` Wiles, Keith
2016-06-29 16:05       ` Olivier MATZ
2016-06-29 16:19         ` Richardson, Bruce
2016-06-29 16:27 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2016-06-29 16:30   ` Bruce Richardson
2016-06-30 12:00   ` Thomas Monjalon
2016-06-30 12:02     ` Panu Matilainen
2016-06-30 12:09       ` Bruce Richardson
2016-06-30 12:08     ` Bruce Richardson
2016-06-30 12:49 ` [dpdk-dev] [PATCH v3] " Bruce Richardson
2016-06-30 20:05   ` Thomas Monjalon
2016-07-01  8:57     ` Olivier MATZ
2016-07-01 10:21       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3129755.jsp6WimcDp@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=pmatilai@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).