From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 89F6E2BA8 for ; Fri, 1 Jul 2016 12:21:19 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id a66so22699205wme.0 for ; Fri, 01 Jul 2016 03:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=1ubKAdOx9Ui8S4B0U4q9a8xCubFRByww1V9yrZpeD7M=; b=QO2/mgnE19C2+EIGfnCGKzpJjIpFJtK/mzoNbNgCpCs5c3S08Cado96Vrphc2Wnsms mTNq/9pQFaEOQoLzLq8DT8EL8xdmFp/FTY9ika35IYJNUST9rbQRTdJIGiOgjUPqCl/9 p2FbXS9a8iexZNBBbItx2aXnjWjiOIFISo9q4A6wUJPZ+w0vggofMX75KK1wtfEgYwpC d+ICXV7YvyI7ihSeTIV99mrvsx3IJZAGk9a8hAyraT2BF+5yKFWzzABCGzvpSBPs6FEK qGG6KNWYvJc1onDbomQGwA0xUcAZpfOE/2B/LYfevMaivwzicaH1J+VRG8fmlgGq9Edm thtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=1ubKAdOx9Ui8S4B0U4q9a8xCubFRByww1V9yrZpeD7M=; b=J/9uO3igyjQKkR/K0cShzOSQfpV6UtssLsbtBCh7LdSk26/X6bQmuCa0lX3F0/rVPS orHA0POlG8mAy0oTcJIlA9zKu0SMLzbYO4q9vsG6sSVZYVm3Hp/5sgEHrXR0igFyDUNZ T4IgKmPAHJ0j5MTrJfizx53N4J44gPINBg8tzBealyKb3wZCtUT76aDPJ4nQGs1D0uWB 6WqzSfj9w3qCV3bOsXPQq4vYYBpnEj9v/Vs77pCSMC8fNZLtMOfZFoDVw3jDY2EmYtcc szGGa7YVHOohJEPkXJQ62WfaVdsM1xkn8LGPHLeyCElvCt0+L6mnzrwSW8uFAUP1FG2A xNEA== X-Gm-Message-State: ALyK8tK8YgRjkLaQWUFjYCZOFXxLe/7zIJNd2K6qA6aXdkHQWSS9ftQ27bO3Nf76kFP018C/ X-Received: by 10.194.216.106 with SMTP id op10mr3227612wjc.178.1467368479361; Fri, 01 Jul 2016 03:21:19 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id rx9sm1781749wjc.19.2016.07.01.03.21.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Jul 2016 03:21:18 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Cc: Olivier MATZ , dev@dpdk.org, keith.wiles@intel.com, Panu Matilainen Date: Fri, 01 Jul 2016 12:21:17 +0200 Message-ID: <3129755.jsp6WimcDp@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3fc02727-50d2-a6b6-8dcc-8c8d6a0b1d89@6wind.com> References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com> <1613474.aBI9rN0qDz@xps13> <3fc02727-50d2-a6b6-8dcc-8c8d6a0b1d89@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] mempool: rename functions with confusing names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2016 10:21:19 -0000 2016-07-01 10:57, Olivier MATZ: > > On 06/30/2016 10:05 PM, Thomas Monjalon wrote: > > 2016-06-30 13:49, Bruce Richardson: > >> The mempool_count and mempool_free_count behaved contrary to what their > >> names suggested. The free_count function actually returned the number of > >> elements that were allocated from the pool, not the number unallocated as > >> the name implied. > >> > >> Fix this by introducing two new functions to replace the old ones, > >> * rte_mempool_avail_count to replace rte_mempool_count > >> * rte_mempool_in_use_count to replace rte_mempool_free_count > >> > >> In this patch, the new functions are added, and the old ones are marked > >> as deprecated. All apps and examples that use the old functions are > >> updated to use the new functions. > > > > The ThunderX driver uses rte_mempool_count and needs an update. > > Except that, it looks good. > > > > Yep, I don't see any other issue. Applied with ThunderX update, thanks