From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 36F6E1BB12 for ; Thu, 21 Jun 2018 10:06:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 01:06:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,251,1526367600"; d="scan'208";a="65997658" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.4.182]) ([10.252.4.182]) by fmsmga001.fm.intel.com with ESMTP; 21 Jun 2018 01:06:18 -0700 To: Qi Zhang , thomas@monjalon.net Cc: konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, benjamin.h.shelton@intel.com, narender.vangati@intel.com References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20180621020059.1198-1-qi.z.zhang@intel.com> <20180621020059.1198-4-qi.z.zhang@intel.com> From: "Burakov, Anatoly" Message-ID: <312afb17-6f37-8e83-4dd2-47b9c7c1098f@intel.com> Date: Thu, 21 Jun 2018 09:06:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180621020059.1198-4-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 03/22] ethdev: add function to release port in local process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 08:06:21 -0000 On 21-Jun-18 3:00 AM, Qi Zhang wrote: > Add driver API rte_eth_release_port_private to support the > requirement that an ethdev only be released on secondary process, > so only local state be set to unused , share data will not be > reset so primary process can still use it. > > Signed-off-by: Qi Zhang > --- > > /** > * @internal > + * Release the specified ethdev port in local process, only set to ethdev > + * state to unused, but not reset share data since it assume other process > + * is still using it, typically it is called by secondary process. > + * > + * @param eth_dev > + * The *eth_dev* pointer is the address of the *rte_eth_dev* structure. > + * @return > + * - 0 on success, negative on error > + */ > +int rte_eth_dev_release_port_private(struct rte_eth_dev *eth_dev); > + As far as i can tell, even though the function is marked as internal, it should still be exported in the .map file (see rte_eth_dev_allocate() for example). Thomas and others, does this count as new API? Should this be marked as __rte_experimental? Presumably, we guarantee ABI stability for internal functions too, so my expectation would be yes. > +/** > + * @internal > * Release device queues and clear its configuration to force the user > * application to reconfigure it. It is for internal use only. > * > -- Thanks, Anatoly