From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AB99A04C3; Mon, 28 Sep 2020 17:19:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A12D51D9C0; Mon, 28 Sep 2020 17:19:20 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 472A61D9B2; Mon, 28 Sep 2020 17:19:18 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id AA3145C014D; Mon, 28 Sep 2020 11:19:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 28 Sep 2020 11:19:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= AGWR62jXsUkvNgz0zhq6Trc8KW3hvxh2Vbrd5HeCC/w=; b=WRy+L/7WS8m5byKP HRx6kdXNJSwVv5vpv5/kzBOY4ysd3/xpx3IFRCQP1RlnN1sCV6nhszU132eA47ok akLiJkTXSAekyEpkGSXuQeIIcd3PxyqozQuSY74ioEr2R/VFAGASVfdxvWZWkbOb 109qCKVFOdpNSQU2Wh/BLGmGOTE0XIMMG/rDLL+vvFQzjudubDgOVGs8Ip8MkaCB OSkYpzuqfN+tZBGxHFriW2Sjv1T2XN2QNVmZadUwb44bD5WK54kv/tOdm0E2fjiZ YMDYNUY1DYXNVIvqaktSHQFOQSvLM99Few7LJhdtwt5uhrdVUAWp7ggFkeygGceY 28ApTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=AGWR62jXsUkvNgz0zhq6Trc8KW3hvxh2Vbrd5HeCC /w=; b=LUs4n4j0HihshQLjEsge62hepoOUrWVBHogYifTlyow8IL2RDKZZERa3U /zFtgP2Q/gvi8oyDgrcWQJls+OkV3Fop7suO6OZUVBRIpWIUSDf7STabHq6SDZg7 vYEc60Ptyw/q+ayhHr+Pnh/WmM5JbJBSAMpv+N07D8dV7IZeuqOOsPB07EqRkA1E h8tqE2xWk4HsggL2bTDc6x6pExEfIGnh+1O6AlMQQdy2BgKeOaf8uQZI1RI9Z7r8 Uq9Ktnwno+A0dvRzz0ikA153Y8jDKzsv3RZk1W6rwxqXa8lN+ySrqJEUdmyCYH7e Jnv/POX5Wa5MiLdLPmyDnP+KJIPtg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeigdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D5CD3064682; Mon, 28 Sep 2020 11:19:15 -0400 (EDT) From: Thomas Monjalon To: Maxime Coquelin , Chenbo Xia , Zhihong Wang , Jay Zhou , Fan Zhang , Ferruh Yigit Cc: stable@dpdk.org, dev@dpdk.org Date: Mon, 28 Sep 2020 17:19:14 +0200 Message-ID: <3132418.IDjBfVWYWf@thomas> In-Reply-To: <20200928105918.740807-6-ferruh.yigit@intel.com> References: <20200928105918.740807-1-ferruh.yigit@intel.com> <20200928105918.740807-6-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 6/6] vhost/crypto: fix possible TOCTOU attack X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Fan Zhang > > This patch fixes the possible time-of-check to time-of-use (TOCTOU) > attack problem by copying request data and descriptor index to local > variable prior to process. > > Also the original sequential read of descriptors may lead to TOCTOU > attack. This patch fixes the problem by loading all descriptors of a > request to local buffer before processing. > > CVE-2020-14375 > Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") > Cc: stable@dpdk.org > > Signed-off-by: Fan Zhang > Acked-by: Chenbo Xia Series applied in the main repository, thanks.