[dpdk-dev] [PATCH] common/dpaax: fix uninitialized table case

[dpdk-dev] [PATCH] common/dpaax: fix uninitialized table case

[Shreyansh Jain]

There is a possibility that either because of missing device tree entry
or lack of memory, the PA-VA table might not be available. But, the
table being transparent, the callers don't necessary check for its
initialization state. This is explicitly done during update and
translation call.

Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table")

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 drivers/common/dpaax/dpaax_iova_table.c | 3 +++
 drivers/common/dpaax/dpaax_iova_table.h | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c
index d54267bb7..075053b1a 100644
--- a/drivers/common/dpaax/dpaax_iova_table.c
+++ b/drivers/common/dpaax/dpaax_iova_table.c
@@ -272,6 +272,9 @@ dpaax_iova_table_update(phys_addr_t paddr, void *vaddr, size_t length)
 	uintptr_t align_vaddr;
 	phys_addr_t align_paddr;
 
+	if (unlikely(dpaax_iova_table_p == NULL))
+		return -1;
+
 	align_paddr = paddr & DPAAX_MEM_SPLIT_MASK;
 	align_vaddr = ((uintptr_t)vaddr & DPAAX_MEM_SPLIT_MASK);
 
diff --git a/drivers/common/dpaax/dpaax_iova_table.h b/drivers/common/dpaax/dpaax_iova_table.h
index 1109a362c..138827e7b 100644
--- a/drivers/common/dpaax/dpaax_iova_table.h
+++ b/drivers/common/dpaax/dpaax_iova_table.h
@@ -74,6 +74,9 @@ dpaax_iova_table_get_va(phys_addr_t paddr) {
 	size_t offset = paddr & DPAAX_MEM_SPLIT_MASK_OFF;
 	struct dpaax_iovat_element *entry;
 
+	if (unlikely(dpaax_iova_table_p == NULL))
+		return NULL;
+
 	entry = dpaax_iova_table_p->entries;
 
 	do {
-- 
2.17.1

Re: [dpdk-dev] [PATCH] common/dpaax: fix uninitialized table case

[Thomas Monjalon]

17/10/2018 11:05, Shreyansh Jain:
> There is a possibility that either because of missing device tree entry
> or lack of memory, the PA-VA table might not be available. But, the
> table being transparent, the callers don't necessary check for its
> initialization state. This is explicitly done during update and
> translation call.
> 
> Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table")
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied, thanks