From: Thomas Monjalon <thomas@monjalon.net>
To: Robin Jarry <robin.jarry@6wind.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
Kevin Laatz <kevin.laatz@intel.com>,
Andrius Sirvys <andrius.sirvys@intel.com>,
Ciara Power <ciara.power@intel.com>,
Reshma Pattan <reshma.pattan@intel.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] usertools: fix py3 syntax errors with dpdk-telemetry-client.py
Date: Sun, 27 Oct 2019 21:39:38 +0100 [thread overview]
Message-ID: <3132706.1A4gHmE3Kd@xps> (raw)
In-Reply-To: <20191017103715.4ac27fce@hermes.lan>
17/10/2019 19:37, Stephen Hemminger:
> On Thu, 17 Oct 2019 19:32:12 +0200
> Robin Jarry <robin.jarry@6wind.com> wrote:
>
> > When running the dpdk-telemetry-client.py with python 3, we get the
> > following syntax errors:
> >
> > File "usertools/dpdk-telemetry-client.py", line 70
> > print "\nResponse: \n", str(data)
> > ^
> > SyntaxError: invalid syntax
> >
> > File "usertools/dpdk-telemetry-client.py", line 93
> > print "\nResponse: \n", str(data)
> > ^
> > SyntaxError: invalid syntax
> >
> > File "usertools/dpdk-telemetry-client.py", line 111
> > file_path = sys.argv[1]
> > ^
> > TabError: inconsistent use of tabs and spaces in indentation
> >
> > Import print_function from __future__ and add parentheses where missing.
> > Also, use spaces for indentation everywhere.
> >
> > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry")
> > Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
> > Fixes: 4080e46c8078 ("telemetry: support global metrics")
> > Cc: Andrius Sirvys <andrius.sirvys@intel.com>
> > Cc: Ciara Power <ciara.power@intel.com>
> > Cc: Kevin Laatz <kevin.laatz@intel.com>
> > Cc: Reshma Pattan <reshma.pattan@intel.com>
> > Cc: stable@dpdk.org
> > Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks
prev parent reply other threads:[~2019-10-27 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 17:32 Robin Jarry
2019-10-17 17:37 ` Stephen Hemminger
2019-10-27 20:39 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3132706.1A4gHmE3Kd@xps \
--to=thomas@monjalon.net \
--cc=andrius.sirvys@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=reshma.pattan@intel.com \
--cc=robin.jarry@6wind.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).