From: Thomas Monjalon <thomas@monjalon.net>
To: "Yao, Lei A" <lei.a.yao@intel.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Xu, Qian Q" <qian.q.xu@intel.com>,
"Lu, PeipeiX" <peipeix.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: fix circular dependency in EAL proc type detection
Date: Thu, 19 Jul 2018 12:17:48 +0200 [thread overview]
Message-ID: <3133744.V1gL8Xi36k@xps> (raw)
In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A4F9683@shsmsx102.ccr.corp.intel.com>
18/07/2018 17:58, Yao, Lei A:
> From: Burakov, Anatoly
> >
> > Currently, we need runtime dir to put all of our runtime info in,
> > including the DPDK shared config. However, we use the shared
> > config to determine our proc type, and this happens earlier than
> > we actually create the config dir and thus can know where to
> > place the config file.
> >
> > Fix this by moving runtime dir creation right after the EAL
> > arguments parsing, but before proc type autodetection. Also,
> > previously we were creating the config file unconditionally,
> > even if we specified no_shconf - fix it by only creating
> > the config file if no_shconf is not set.
> >
> > Fixes: adf1d867361c ("eal: move runtime config file to new location")
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Tested-by: Yao Lei<lei.a.yao@intel.com>
> This patch pass the test with simple_mp sample. The secondary process
> can recognize itself as "secondary process" even use "--proc-type=auto"
> parameter.
Applied, thanks
prev parent reply other threads:[~2018-07-19 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 10:53 Anatoly Burakov
2018-07-18 15:58 ` Yao, Lei A
2018-07-19 10:17 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3133744.V1gL8Xi36k@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=lei.a.yao@intel.com \
--cc=peipeix.lu@intel.com \
--cc=qian.q.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).