From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7B41A2C2F for ; Thu, 19 Jul 2018 12:17:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BD4222188C; Thu, 19 Jul 2018 06:17:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 19 Jul 2018 06:17:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Rp2QkGIl20rSJmq3GWeRkY5lsi kyqxDRnrjeFXvWsaI=; b=dVgGf2xZXbQDnROvtJSJ5bDvcj2rLevYlIkQ6w+2HW 44Z4AP9sgei/kYR0iBLbXXUx+MrMLvxHNGhjadc1SLeH9OCgRhjTU4bcdZQ+DLeG 0DH4Bo1M20PRl4x/z3/YNvHPkTwTkzM9sd6yD2q9YfctgMqwEArAgKpgd3m7sLcN Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Rp2QkG Il20rSJmq3GWeRkY5lsikyqxDRnrjeFXvWsaI=; b=kGlrnIduUoQ7pFbAuGVcJB DzNkm8hh3/XbwU2Lg7i20EinjSz9HyT0ki4hKLX+jBTcmVjUYvF1cnpehMn6yuHD hWymBf7dJgWiU4JxDaaDjSQf8m5+H9Ve41ftiXlbYPKyOlQUX5x6Ql/X97fvArI9 riLJsbgdd/IG9cWTsmmRg6vnXNgfKzQpnkaMmxUrXejN3jGicMelNCUaHYrzzb5l ghz8AZVjQE+BSuDZxh5r0UaSzjoIzZBVO2ty+6DoAlA9wd+n+O0wLf4DqYp9xCCt TuBNwfHAH1ElyItwfXGOE7SSK4+Rjd9gNEe0AlYBm51CAwCTR0QG0iLfs77m9mfQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 841E3E4686; Thu, 19 Jul 2018 06:17:52 -0400 (EDT) From: Thomas Monjalon To: "Yao, Lei A" Cc: dev@dpdk.org, "Burakov, Anatoly" , "Richardson, Bruce" , "Xu, Qian Q" , "Lu, PeipeiX" Date: Thu, 19 Jul 2018 12:17:48 +0200 Message-ID: <3133744.V1gL8Xi36k@xps> In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A4F9683@shsmsx102.ccr.corp.intel.com> References: <2DBBFF226F7CF64BAFCA79B681719D953A4F9683@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix circular dependency in EAL proc type detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 10:17:56 -0000 18/07/2018 17:58, Yao, Lei A: > From: Burakov, Anatoly > > > > Currently, we need runtime dir to put all of our runtime info in, > > including the DPDK shared config. However, we use the shared > > config to determine our proc type, and this happens earlier than > > we actually create the config dir and thus can know where to > > place the config file. > > > > Fix this by moving runtime dir creation right after the EAL > > arguments parsing, but before proc type autodetection. Also, > > previously we were creating the config file unconditionally, > > even if we specified no_shconf - fix it by only creating > > the config file if no_shconf is not set. > > > > Fixes: adf1d867361c ("eal: move runtime config file to new location") > > > > Signed-off-by: Anatoly Burakov > Tested-by: Yao Lei > This patch pass the test with simple_mp sample. The secondary process > can recognize itself as "secondary process" even use "--proc-type=auto" > parameter. Applied, thanks