From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 760D41B013
for <dev@dpdk.org>; Mon, 2 Apr 2018 17:27:45 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id D9CAD20F50;
Mon, 2 Apr 2018 11:27:44 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Mon, 02 Apr 2018 11:27:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=5Rqfrmn0rRm03UaZYJS2WTH6/P
lg5T9/29J+usQPOAM=; b=I+pDtUp8Y3DE4fjV2oFOEFC+Tk9kubMJAVam8Tx560
AyMzLqyOdskxhVaNVEvEexSLsXM/faaMyRzjcd5VbVaeOgh0XukFDV/LJF2UP/Np
s48RXiwq6v2ye5t/Q46TbO35ZMkm9gOv02BWvG3M7DnyI0eXSj1tTanUtoA01LnH
I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5Rqfrm
n0rRm03UaZYJS2WTH6/Plg5T9/29J+usQPOAM=; b=FqdR3vDLGI/LK7roJNAVTW
xx1/fa6YJ0o4ZJ8yfTrhcBEizterkrRo7TqdRWisMi3X1zv5xgeUUZQIKrHibaoc
Z4cBgIrr6i6xQARpR6fFpxVE4GIlEpB3Qrelf+4mV+lui+Qar5lrARGmZT7VnJ8W
T/PYgOx1BXy/ao5e0eEce9P58tIHy6u00v1jV61RbFrXh0JMyCpgftp4SqcK/v8j
tw/kgDMCIvx5xNIqdyUHCpxnE1AwP8ljfwFmtNAY1mLV2r8ok7yYTlM6DEiBqw+r
2o/W2dMtiVy0i/8+MH05NM1YMGnIhp8biVoJSzG9diMwKCUwORJJpQYUY7OJi5Xg
==
X-ME-Sender: <xms:8EvCWjBmfMjoHWp4LXwOK1hahPBEZwB0BKe0JEX3RNfndiYlnnuq4A>
Received: from xps.localnet (84.19.136.77.rev.sfr.net [77.136.19.84])
by mail.messagingengine.com (Postfix) with ESMTPA id 00C0A1025B;
Mon, 2 Apr 2018 11:27:42 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
chaozhu@linux.vnet.ibm.com, gowrishankar.m@linux.vnet.ibm.com
Date: Mon, 02 Apr 2018 17:27:40 +0200
Message-ID: <3135662.d5SUXWziWm@xps>
In-Reply-To: <cb7e7ee4-c501-a554-7265-734331debe80@intel.com>
References: <9755302ee8a1439a152408d4b1c69cc1012153e4.1521715978.git.anatoly.burakov@intel.com>
<507411072.Cm6Xjx9PLX@xps> <cb7e7ee4-c501-a554-7265-734331debe80@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v6] eal: provide API for querying valid
socket id's
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2018 15:27:45 -0000
31/03/2018 15:35, Burakov, Anatoly:
> On 27-Mar-18 5:24 PM, Thomas Monjalon wrote:
> > 22/03/2018 13:36, Anatoly Burakov:
> >> --- a/lib/librte_eal/common/include/rte_eal.h
> >> +++ b/lib/librte_eal/common/include/rte_eal.h
> >> @@ -57,6 +57,9 @@ enum rte_proc_type_t {
> >> struct rte_config {
> >> uint32_t master_lcore; /**< Id of the master lcore */
> >> uint32_t lcore_count; /**< Number of available logical cores. */
> >> + uint32_t numa_node_count; /**< Number of detected NUMA nodes. */
> >> + uint32_t numa_nodes[RTE_MAX_NUMA_NODES];
> >> + /**< List of detected numa nodes. */
> >
> > Please keep this comment on the same line if it's below 99 chars.
>
> If this is allowed, can we fix checkpatch to not report error in these
> cases?
Checkpatch is just a tool, not an authority.
In this case, given all other lines are formatted with comments
at the end of lines, it is better to do the same if the line size
is reasonnable.