Re: [dpdk-dev] [PATCH v2 01/14] common/mlx5: add common device driver

[Thomas Monjalon <thomas@monjalon.net>]

13/07/2021 15:14, Xueming Li:
> +static const struct {
> +	const char *name;
> +	unsigned int drv_class;
> +} mlx5_classes[] = {
> +	{ .name = "vdpa", .drv_class = MLX5_CLASS_VDPA },
> +	{ .name = "eth", .drv_class = MLX5_CLASS_ETH },
> +	/* Keep class "net" for backward compatibility. */
> +	{ .name = "net", .drv_class = MLX5_CLASS_ETH },
> +	{ .name = "regex", .drv_class = MLX5_CLASS_REGEX },
> +	{ .name = "compress", .drv_class = MLX5_CLASS_COMPRESS },
> +};
[...]
>  enum mlx5_class {
>  	MLX5_CLASS_INVALID,
> -	MLX5_CLASS_NET = RTE_BIT64(0),
> +	MLX5_CLASS_ETH = RTE_BIT64(0),
[...]
>  static struct mlx5_pci_driver mlx5_driver = {
> -	.driver_class = MLX5_CLASS_NET,
> +	.driver_class = MLX5_CLASS_ETH,

There are other occurences of MLX5_CLASS_NET in mlx5_common_pci.c
so this patch does not compile.

This change may deserve a separate commit.