From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AEE5A0C50; Fri, 23 Jul 2021 16:09:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50D0C40DDA; Fri, 23 Jul 2021 16:09:18 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 8ACE940040; Fri, 23 Jul 2021 16:09:17 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D41BA5C0121; Fri, 23 Jul 2021 10:09:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 23 Jul 2021 10:09:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= xu6n5t/e8DQGUXBEtf9euYsaaLYRkoNXnGmjK4DOGsc=; b=uy3kRK3xGA6RytBz /C5RjKiIRa9Dspj3JoxoAgj1zEnNX2ngjdKZJpGqwRIr1Gyc01fT8zLqQ5TqIZDa c5NZuf41cr/ir70vuuAqagi3pynV+BgtWGLHCmDFViZ50ec2BKHwDUYKH10Ats5y GwYRVj3arnUFaQu43YD7U+ue5ExPMtiPis0zIo7YUiHl2gXoLivw4TB0T6jKoCNv Pa2YUIkUsF5woseaB6oMRSTkzBsxxJQcOtVEkjd38E0sJzNDtsNcIT34XRIjKHM/ wsYn2a/YX7BB9YXIY/kBDsyEXky07HGKTWED/xKaxU0neJm7TPrlcEcNM1TFpDKD P52rXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=xu6n5t/e8DQGUXBEtf9euYsaaLYRkoNXnGmjK4DOG sc=; b=Sp/ulukC+UsPxk9ifGfhiSJzrxm891CJhDdoxKqT8wtGSunKkBU0D3gkz F2QD74H47pGfKEus3Npovwo9xfEuLocnMdYe/AOQH4kQ3Z1KB+oqq8CI0FQDUy/T 0wY5jzZRfBDdPAVxESErLndG7vGkOkEjdO2s7vUlPIBBNgR0bPKhCDZQn/xXHAds ZC4YORK+mrAbg50hB90sFbFrLDRMOZH1qXPMntCn4YqgflJ0EvuQM5UHh958OaBa L0VUG5z3Vjac38lQVaJLlO0ge2kRneZJKsfubKpdA5OymB3zHvRzgfU+Y22g/O8e T1A7RQ8iSF7hYBwammr9cVygXJCKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeekgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Jul 2021 10:09:15 -0400 (EDT) From: Thomas Monjalon To: Slava Ovsiienko , "Jiawei(Jonny) Wang" Cc: Matan Azrad , Ori Kam , Shahaf Shuler , "dev@dpdk.org" , Raslan Darawsheh , "stable@dpdk.org" Date: Fri, 23 Jul 2021 16:09:36 +0200 Message-ID: <3136964.cCNWhMJKoI@thomas> In-Reply-To: References: <20210723124338.18269-1-jiaweiw@nvidia.com> <5536161.f2duC4C3qX@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/07/2021 16:01, Jiawei(Jonny) Wang: > Hello, > > From: Thomas Monjalon > > 23/07/2021 14:43, Jiawei Wang: > > > Due to hardware limitations, the decap action can't follow the > > > > Which decap action? Pleas be more specific. > > All of decap, vxlan_decap, nvgre_decap and raw_decap. > Will update details. > > > > > > sample action in the same flow, to keep the original action order of > > > sample and decap actions the flow was internally split by PMD, and > > > decap action was moved into suffix subflow in the new table. > > > > "the" new table? which one? > > " sample and decap actions the flow was internally split by PMD, " means > that PMD split internally into two flows:prefix subflow with sample action in original table; > suffix subflow with decap action in the new table; > > > > > Was there an issue? Above seems to say all is fine. > > > > The issue is mentioned below that 'L3 encapsulation' case (raw_decap+raw_encap), > the previous code not consier the combination decap/encap case. > And under this case flow don't need split. > > > > There is a specific combination of raw decap and raw encap actions to > > > specify "L3 encapsulation" packet transformation - raw decap action to > > > remove L2 header and raw encap to add the tunnel header. > > > > Is this combination the problem? It was not working before this patch? > > Please describe what happened. > > > > L3 encap is working without sample action or sample is working without L3 encap; OK please be more explicit in the next version. > > > This specific L3 encapsulation is encoded as a single packet reformat > > > hardware transaction and is supported by hardware after sample action > > > (no hardware limitations for packet reformat). > > > > > > The patch checks whether the decap action is the part of "L3 > > encapsulation" > > > > I think you mean "is part of". > > Thanks, will fix in new version. > > > > > > and does not move the decap action into suffix subflow for the case. > > > > > > Fixes: cafd87f62a06 ("net/mlx5: fix VLAN push/pop and decap actions > > > with mirror") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Jiawei Wang > > > Acked-by: Viacheslav Ovsiienko