From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E226F431FC; Wed, 25 Oct 2023 18:09:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D104440EAB; Wed, 25 Oct 2023 18:09:30 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2045.outbound.protection.outlook.com [40.107.223.45]) by mails.dpdk.org (Postfix) with ESMTP id 66A2440EAB for ; Wed, 25 Oct 2023 18:09:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MLIdFVrTcxDzu9WgV054bjUODPRK1AD6HHIteHo4Ev7TYfliXEcvAM9HQk96H2wIKhTjvVClHTym/tVOy1uRlZpWLfDVfS9ehqGNOHl/HRev9SdCkq/S9nn34IGKcplMDtV6ZNdGRiEvQL0undHgdfeSFdTHN8srM+8F65PX4rT4Q7/19PqMNq7nC9a3++6ftSngQs7Stf7oT+MPPqZX0/Z+DVQfmq/+HQP8kXvYFb42+iRquTaz+ayT1LUEA8AjYiKmoOxruvpBxqGSOd4deddtw128JU/1ZerC1yOsjE6rWeRNYeR1dL4S91E/8nQJLV4JtdVqeYj7KXj8kmr/NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=95pLTnLh00WplyD5tnNUX34VDMA360k0oSWMlR4h40Q=; b=EldtWD6ITsODHkymluHt8SjnOdz1IytQBgWXT3ooiKoqSeJyFFHW49NeHZ4K66aTIMvkwCOb2mCinhFas1RlOR5jsapEQNndV8rgZX2yCadx9a9ckAjBOXMjAg1cOakQpEtqBeNhSeCyRPNO0ZG3k4UByHVN4IS9yoF55a+F0ySNrdXfqmVs8upiWSE3CRoeshdm07baS0MS/DtwMNLOx3GZyQD1LPYfO65TNkI5rPg1ZJQxh+JPyD+nKlqJ57vxx7npEknfS1vpnFeA4zuJyvERiLCmixBrfsmH3PX4mdtYsxy+lpJdRGAzL8S9ONWoe5Xckeq9kl6mxImXoQWaYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=95pLTnLh00WplyD5tnNUX34VDMA360k0oSWMlR4h40Q=; b=JV+iADFSNCBuxTHGQRolX9cm5wyQIAiCUpgxunl5EqLuBqY3AcX+LZQzoFH+1hxF+6bS5Tcz9BJ3NRYg1E/sZ0lfe7n6BvTGhOqGT8E7XQueoHejPR/5kq0btrN+eme2x2k/apJFC7xSIms7lFXYz36MqksrD/U/dKCjUHgI0Ug= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB6709.namprd12.prod.outlook.com (2603:10b6:a03:44a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Wed, 25 Oct 2023 16:09:27 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6933.019; Wed, 25 Oct 2023 16:09:27 +0000 Message-ID: <31373851-d220-4f6a-ba97-2c97f3abf0d7@amd.com> Date: Wed, 25 Oct 2023 17:09:25 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/25] net/nfp: make VF PMD using of NFP common module Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Shujing Dong , Long Wu , Peng Zhang References: <20231017054545.1692509-1-chaoyong.he@corigine.com> <20231024022849.3092506-1-chaoyong.he@corigine.com> <20231024022849.3092506-3-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231024022849.3092506-3-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0190.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB6709:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d68b215-33b8-4882-e4b8-08dbd574c33b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qmdv7+hZxlEYsqwSEFs0TBDse0UEFVOTIzqNAfsyko/XuHR2EfBx4OjPq8tq/hSdRgQ8BBtM+KGHTjmNpjAw4PXKjhskCUFhZT+gNADvSM0IESGnNrk0Q5mujnZR+Y3wKwOJm0hQIv34z86z+w/WXVSdR1bp7+7PoP/ZD95W5P8+5xV1dO07zkGwa7rVVXlFAEmnP2HGFxTDsKEAgeGuMYAG9vc3bFKWossWHN03NOXoNckCX9jcLi/qTiZ2jx+OjKsjGpTFArJXJSw1wsmWegSrYO6CnfROWQmVf4lWJcuvynVDkqt0PX+JvUT5IXicaj7RZNzGnSlfp+Z78vMlRVKQWYj8JX3NFQPDnrjt2+9jXposm7aFrviKXdsgnhQfLs4xXaCRvhRc38UDwKwbMXoMrgwhAlM/otZ9KMeyzcMlzfQwK4GKkjRkPING/0nxBlT32DKdYp3bkjLc9XvTsCIP+9CkNeMZeHHLgCrmTnBm2+NlKxpj0fNV2XP2o5G3egNEgGrhVW4V38t6av+xiLldggc5bGTbjjcZfkNQ30GR5BPK2MIZogFVi9GcB5f1IS4kDqkDgUS2T3Is7OMRq7+Mci/Xc8tpwzUEUwxurX+20Y6CM4E8Ut2v3+eO/LpC7LiOVZocXawmNDQ29uJ4Ag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(39860400002)(136003)(376002)(346002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(2906002)(66556008)(54906003)(41300700001)(316002)(31696002)(66476007)(66946007)(478600001)(6506007)(6486002)(6512007)(53546011)(38100700002)(83380400001)(36756003)(86362001)(44832011)(5660300002)(8676002)(2616005)(4326008)(8936002)(26005)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk1STk04THUrYnFMa0NXa3AyV3gvNkNmVERjeUZDdjBGclRRaGQ4WVB5Mkph?= =?utf-8?B?UitQWll1Z0Z2QndHTEs3bFl2Rk9iclU4c1lFZUk5YU41cG9QUy9zME5HMnAv?= =?utf-8?B?TFJWTERaQjhlZzVDRklVbVZDQjhRUnR6VHB1VXFUWExxa00xTTVZWmVsMFVj?= =?utf-8?B?Z1loL3dkdzdTcDlzcU1tc1htVWlZSER6bmhzbWY0eFBNbkVxT0lRK25KYUwv?= =?utf-8?B?UEdDM2Qzc1NxVVlxdmxnNnVQMURDMmhCV3hnQ2VFaXV3UjFWVUs1S3BuK1Vv?= =?utf-8?B?K0dLaGRXNktmRjNHM0pwcjNzK251STRUK3VuTmtpVGFvVXpaWXNpRUNwK2hP?= =?utf-8?B?K0dsMUJlSThJUG1UQTdyemJwU05zMWxKUzlLa2Fyb0JzbFk4WU01ZDFDN2Iy?= =?utf-8?B?cFNqNjV6dWorSk5iRGFaaXFqQjU2bDlDdExhcVRJOFpBVFU5c2lWOERLVzVO?= =?utf-8?B?VXdxSzZYMkdWZ3R2TXl0bXNYZjdXOE4zTEhJY3RkQ1pDL0tJV0FJMkFta0c4?= =?utf-8?B?c2hsWTQ1V29ZaitGbkZKenFkR2NCSzRLVmExVXBiaUtONEt4cWhDSVVFK0dt?= =?utf-8?B?Q2toUzlmT290T0FITnh2M3VhMU9kdzZBVmZ0QW1hTjEwTTJnbDdra0RLZVNL?= =?utf-8?B?WUtsbXNnNytjeTFIT3NORFd0LzZhdUJEOVlHZDY2TTQ2QmRyMGh0WjhTMnNs?= =?utf-8?B?ZTBVVjNjTHd2V005cGFaMjdvaitDcVFqR2VBVjFaRERYTW1uRW5nSTJuTjZh?= =?utf-8?B?UmhTUVFkamtrYUgvTUdPS1NsQ3FBelhjc2VUdmwySkZRVzFNZWxsSjc5VDJm?= =?utf-8?B?RFU1cDJMaVRFWDhrUnZObE5YZ05UVWp5alZjMEhQU3ZJcFlFcDNjL2pIcGpZ?= =?utf-8?B?bHBaU0R0Tmszd3VGYzRoY2lPNHZZZTJwYlVXd0g5UkFWYVBnZTM5Rmx1MXQ5?= =?utf-8?B?VzZxSmVxVWxDdVkwVmZ2Q2Q1VVJxeXVhWjdQRTJ3SVMzN3YxNU96aCtrc2h0?= =?utf-8?B?NzI0aXF1eE5TVlFOcitFQUtJUWlpbytSai9KYWYvOFFoS0ZuMDBzTzR3Mnc5?= =?utf-8?B?S2c2Q3NkK1FIYlc1N2pQUnV4THIwZ0hDSG1Wb1hBd1BiNURnWXpqMVlMK1FT?= =?utf-8?B?UlZaNEVtaExHZ0J0Q3dObFRoalFRRm8zRGxzVTA4SjBqQXNnak0rVjhjQWNn?= =?utf-8?B?R2JIeFN4TjIrWUNGNjMwWExLMFY1QWVSVHFyM0NqU2x4WTl5WVdTY0ptVjNX?= =?utf-8?B?TCtXVlBOWUhyc0I3VEVhRkFsN0dGTE5rckhnRUsvWE8yZGg4Q0hnTHRMWmxp?= =?utf-8?B?NkQwTW9qZ21LYS8ySUNOL1F6VGdSWCt2ZWs4Tmgvckt0YytUaVR4dHNhUXF0?= =?utf-8?B?aEhKOVdGSkNEcnMzejBSMVFML1pnY1lmT3lxQzl1ZmtGbC80RXJQcGJpK3V2?= =?utf-8?B?YWk4enF1VCt1ZWsxZXI3bHJFeHZiRllXR2ZVb294UTgvWVZ5TDhDZURsMi8z?= =?utf-8?B?dENGMzFFWWNoUTVMTGpFditvNllOQzkwNkQzV1dFemFHYlRaWGp6RGhBUW5y?= =?utf-8?B?Q1NPUDJFRStKb3NIQ1F3cEcxRDFRenpFUzhCVmVoNlJzK2V6MU5EVW1VazdF?= =?utf-8?B?WnlhOENjd24yalQzRVRIRzVzL1owT1djWVVmTGhMa2hyTEx4enhaOXkzZFM1?= =?utf-8?B?bnczU1RJWEExY3RhczFUWDBZMzlINjErUVNOcFJnamJ5Z3F6dVRTU2czRkYr?= =?utf-8?B?aDQ5dEJmc2YyY2p0c1d5L3BVUzZqS0hrSXNqdjRERHBESUNDUnowYjhNTHI3?= =?utf-8?B?M2NBL2FQVHdCNVdQejRYKy85YjZhU0U4bjFiQ09sejh4VzFQUVhHdmNvNEln?= =?utf-8?B?RS9XRDJ1Q0kvZEVkWk00V2VNK25OK25XclZhb1BadWQ1YnNTV0xwZ0s2NDBu?= =?utf-8?B?UDliVFlqVmIzZ2RETHRUdHlGbld6SzQzVCs0QytzSUNmRGxqRllRT2c1K2FS?= =?utf-8?B?RXBNeG0wVXYzSFlkZks2R3BLUk9KS0RtemtOTUZxdlNQNmJNNWVxZkdLL0d4?= =?utf-8?B?V2E0RDIwVHFxU3JiWXRIUERUZkZxdUtLbmJ1bVduamRQOFdCK0Vvd2JvcVpr?= =?utf-8?Q?zEvs=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d68b215-33b8-4882-e4b8-08dbd574c33b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 16:09:27.3491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mzf6QWvwqMHFkm2NvYYvRbQ8viBkJIOLFKUbNXWs0tlKU8xaPsNG6mvTy5aOHLLu X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6709 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/24/2023 3:28 AM, Chaoyong He wrote: > Modify the logic of NFP VF PMD, make it using of the NFP common module > and link into the 'nfp_drivers_list'. > > Signed-off-by: Chaoyong He > Signed-off-by: Shujing Dong > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > --- > drivers/net/nfp/meson.build | 6 +++++- > drivers/net/nfp/nfp_ethdev_vf.c | 14 ++++++++++---- > 2 files changed, 15 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/nfp/meson.build b/drivers/net/nfp/meson.build > index 40e9ef8524..f8581403fa 100644 > --- a/drivers/net/nfp/meson.build > +++ b/drivers/net/nfp/meson.build > @@ -40,4 +40,8 @@ sources = files( > 'nfp_rxtx.c', > ) > > -deps += ['hash', 'security'] > +deps += ['hash', 'security', 'common_nfp'] > + > +if not dpdk_conf.has('RTE_COMMON_NFP') > + error('Missing internal dependency "common/nfp"') > +endif > This will break the build for the cases 'common/nfp' is disabled, above 'deps' updates should be sufficient, which should prevent to build the driver when 'common/nfp' is missing, instead of failing. So can you please drop above check.