From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 58090A49C
 for <dev@dpdk.org>; Sun, 21 Jan 2018 19:37:41 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id D2D0E20B49;
 Sun, 21 Jan 2018 13:37:40 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Sun, 21 Jan 2018 13:37:40 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=sMPzMbf28QgAsA8ViaiCBHH916
 i7+aVfS5BpiGo9umo=; b=X5tOJvMVK9ZnopQMA7JkbaANmPlBDvXvkRnw0CpyQK
 /04Y6CPBNcf4OH+bwFRZ5OSEluNcyKRl80JLNlD3ecpSBB7dYngNb4nC2l+st8tU
 uat+VAs94T+9eOT7Vhmm+RAUlqRhYkBnAOjy/PC8odIs/NYRbI+NFTVnP7alFOM6
 A=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=sMPzMb
 f28QgAsA8ViaiCBHH916i7+aVfS5BpiGo9umo=; b=QDtP/lA14zVkbfqfAR1NVp
 Z+BHVBD7bAb0fwSEjKlaJ8tp7BXQ2HVlUT3Qte/pkKs4bWmCS2x5pRz+mzWmu3yp
 frhsZFtNztC759XDDPrL4vKvJzRxxLJjDql1n1uCwMF6bbb0eBm0URWo08lff/Vk
 YXshQX7hgEiP6GP4nOiohpmDAWMmEaaNoaYW+0psleRcceHdMmiZTbO64wXc1nvL
 etJ85ArlIT75EdzsHK5jqPQEAYJSx+3WPcsWWpxiB7/Cpm07as1gkTj0aFmqAUWp
 llpZaoAZnbY2kIet6xWwMkfL15FoCflSZcMtU0Yq3zvI04m3yYAHrKObS1fmbHrA
 ==
X-ME-Sender: <xms:9N1kWilcF-sYwUd9910HOe9HrOAWnHXjZs4zsKCqCHncKql6YXlYLA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 839DF240DE;
 Sun, 21 Jan 2018 13:37:40 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com
Date: Sun, 21 Jan 2018 19:37:03 +0100
Message-ID: <3138205.GMUQgKkefC@xps>
In-Reply-To: <20171213151728.16747-3-nhorman@tuxdriver.com>
References: <20171201185628.16261-1-nhorman@tuxdriver.com>
 <20171213151728.16747-1-nhorman@tuxdriver.com>
 <20171213151728.16747-3-nhorman@tuxdriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCHv4 2/5] compat: Add __experimental macro
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jan 2018 18:37:41 -0000

Hi,

I know I should have spotted these comments earlier,
I'm sorry to be late on this review.

13/12/2017 16:17, Neil Horman:
> +#ifndef ALLOW_EXPERIMENTAL_APIS
>  
> +#define __experimental \

These macros should be in the DPDK namespace:
	RTE_ALLOW_EXPERIMENTAL_API (no need of S)
	__rte_experimental

> +__attribute__((deprecated("Symbol is not yet part of stable abi"), \

Nit: s/abi/ABI/