From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46341A04DC; Tue, 20 Oct 2020 00:28:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5E90BC50; Tue, 20 Oct 2020 00:28:35 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 98CDCBC48 for ; Tue, 20 Oct 2020 00:28:34 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 3B3B25C01C4; Mon, 19 Oct 2020 18:28:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Oct 2020 18:28:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= YnXJYOIrO3fFFKKznOiE8jjB2fiN4UjY+Ztrt06LTlA=; b=tOqFgzmt8qLMh/u4 Vmnl4PR1PpyuIiRS62RqNIXH33jBYpRW+p/FzNeuY+FbrcxmrB/+fJYS+w1MQyzN i+hlEOQTXacdfkpO50AB7oNa3YlnIMNG1feFB9Z5wdTxCDUrS0rPRMA8yZ1n1tp3 ovsyp0SBugDw2pwtDCWFdWa87ygNeCRem8NsCqvXkzU24ot+ovU6pPJUB4ZzxMN+ d6PbsutruQasoJpn34czJzEPhMc/H/8TGm7lblBjpEJf90To54u3U/YQS3HQiu6Y 3OzlHjbJVgGAsUOCmiZ1pb9HKFXdZLM/hMxH226WQiEvPoPJ9cSX0ODNZG0g2axR 4Mi4wQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=YnXJYOIrO3fFFKKznOiE8jjB2fiN4UjY+Ztrt06LT lA=; b=K2czHdw4TxwKF6i2SblgwJWfQVukTqhqExL28cNB5RFgv9R1+OUlxipHp I3JFlRgHvrpRrA02v7x0qZR7UR26LyZmf4bCMyG9tY4/OHfHYIQPB7MJ5ynTYuJ7 /vCjQDVoLNvNfLgsS4YXuIwdes3eYgzcLtHSjeA2NYUQGoCKFKYCyiY2y68YNQa8 86d18fi2zDyOHAodmfrODEhVqv4Hbr5T04t/NyINUdEOgducsmKi/ThU2jPt7/sE goE2YtX7jmoXkM6hG+6m7g1AF9tDCYZgVPgJ56szigVdqljEW66d7wWiY9siYafM YQv4fYQ6jsd3aSwUk64NjW9bIH8YQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjedvgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E5B0D3064683; Mon, 19 Oct 2020 18:28:29 -0400 (EDT) From: Thomas Monjalon To: Ajit Khaparde , Stephen Hemminger Cc: dev@dpdk.org, Ferruh Yigit , Somnath Kotur , David Marchand Date: Tue, 20 Oct 2020 00:28:28 +0200 Message-ID: <3138459.7qCrTMBDQB@thomas> In-Reply-To: <20200331110435.27507cf1@hermes.lan> References: <20200303175938.14292-1-stephen@networkplumber.org> <20200331110435.27507cf1@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/6] net/bnxt: bounds checking patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Why there was no progress on this during 6 months? Ajit, it was out of my radar because delegated to you. Please restart fresh with a separate patch for EAL, addressing comments. Thanks 31/03/2020 20:04, Stephen Hemminger: > On Tue, 31 Mar 2020 10:52:47 -0700 > Ajit Khaparde wrote: > > > On Tue, Mar 31, 2020 at 5:23 AM Ferruh Yigit wrote: > > > > > On 3/3/2020 5:59 PM, Stephen Hemminger wrote: > > > > This set of patches came from security review of bnxt driver. > > > > It introduces a set of overflow macros that could be more widely > > > > used in other places in DPDK to check for math overflows. > > > > > > > > Stephen Hemminger (6): > > > > eal: add portable way to check for math overflow > > > > net/bnxt: fix potential data race > > > > net/bnxt: avoid potential out of bounds read > > > > net/bnxt: check for integer overflow in buffer sizing > > > > net/bnxt: add integer underflow check > > > > net/bnxt: sanitize max_l2_ctx > > > > > > > > > > Hi Ajit, > > > > > > I can see this patchset has been merged into your tree, although the note > > > in the > > > mail list is missing. Since it has eal changes, I believe they should be > > > reviewed first before merging into brcm tree, can you separate the eal and > > > dependent patch for review, we can proceed with rest? > > > > > I don't mind. > > But being original owner - Stephen, do you want to go ahead? > > > > Thanks > > Ajit > > > > > > > > Regards, > > > ferruh > > > > > Sure, I expected normal review cycle on this. > Hoped that other drivers and eal core would also add overflow checks >