From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 9DE901B62F for <dev@dpdk.org>; Wed, 11 Apr 2018 14:48:45 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 28FE3B40056; Wed, 11 Apr 2018 12:48:44 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 11 Apr 2018 13:48:33 +0100 To: Adrien Mazarguil <adrien.mazarguil@6wind.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org> CC: Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur <somnath.kotur@broadcom.com>, John Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>, Beilei Xing <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, Yongseok Koh <yskoh@mellanox.com>, Tomasz Duszynski <tdu@semihalf.com>, Dmitri Epshtein <dima@marvell.com>, Natalie Samsonov <nsamsono@marvell.com>, Jianbo Liu <jianbo.liu@arm.com>, Pascal Mazon <pascal.mazon@6wind.com> References: <20180406131736.19145-1-adrien.mazarguil@6wind.com> <20180410162022.9101-1-adrien.mazarguil@6wind.com> <20180410162022.9101-12-adrien.mazarguil@6wind.com> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <313da45a-c412-5f2b-050d-1351ee78005a@solarflare.com> Date: Wed, 11 Apr 2018 15:48:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180410162022.9101-12-adrien.mazarguil@6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23776.003 X-TM-AS-Result: No--10.817100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1523450924-D3uVaHxfprGT Subject: Re: [dpdk-dev] [PATCH v3 11/16] ethdev: limit default VLAN TCI mask in flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 11 Apr 2018 12:48:46 -0000 On 04/10/2018 07:36 PM, Adrien Mazarguil wrote: > VLAN TCI is a 16-bit field broken down as PCP (3b), DEI (1b) and VID (12b). > > The default mask used by PMDs for the VLAN pattern when one isn't provided > by the application comprises the entire TCI, which is problematic because > most devices only support VID matching. > > This forces applications to always provide a mask limited to the VID part > in order to successfully apply a flow rule with a VLAN pattern item. > Moreover, applications rarely want to match PCP and DEI intentionally. > > Given the above and since VID is what is commonly referred to when talking > about VLAN, this commit excludes PCP and DEI from the default mask. > > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> > Cc: Ferruh Yigit <ferruh.yigit@intel.com> > Cc: Thomas Monjalon <thomas@monjalon.net> > Cc: Wenzhuo Lu <wenzhuo.lu@intel.com> > Cc: Jingjing Wu <jingjing.wu@intel.com> > Cc: Ajit Khaparde <ajit.khaparde@broadcom.com> > Cc: Somnath Kotur <somnath.kotur@broadcom.com> > Cc: John Daley <johndale@cisco.com> > Cc: Hyong Youb Kim <hyonkim@cisco.com> > Cc: Beilei Xing <beilei.xing@intel.com> > Cc: Qi Zhang <qi.z.zhang@intel.com> > Cc: Konstantin Ananyev <konstantin.ananyev@intel.com> > Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > Cc: Yongseok Koh <yskoh@mellanox.com> > Cc: Tomasz Duszynski <tdu@semihalf.com> > Cc: Dmitri Epshtein <dima@marvell.com> > Cc: Natalie Samsonov <nsamsono@marvell.com> > Cc: Jianbo Liu <jianbo.liu@arm.com> > Cc: Andrew Rybchenko <arybchenko@solarflare.com> > Cc: Pascal Mazon <pascal.mazon@6wind.com> > > --- > > v3 changes: > > These changes were previously mistakenly made part of the previous patch > ("ethdev: refine TPID handling in flow API") from which they were split > following Andrew's rightful comment [1]. > > [1] http://dpdk.org/ml/archives/dev/2018-April/095870.html > --- > doc/guides/prog_guide/rte_flow.rst | 2 +- > lib/librte_ether/rte_flow.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>