From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id EF9971B676 for ; Fri, 13 Oct 2017 11:28:45 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8DB8B20BB4; Fri, 13 Oct 2017 05:28:45 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 13 Oct 2017 05:28:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=m7XFIOXocuagm/FxcWbkKgzgmY ZLvqi65tupBbFDKGw=; b=juc0djnnpOSwrWzv0oBFG4CJowGeZusndJO8xgP/1d wkgq0sw8TG72Q1pz6BMneSwKVYrNXKQubT2gNvBC3ezcPdLCCUeRd8M9QAJcX1G2 RmCH8F4veu916uDvg3oJIqtK5BQPZtbuWR4hJhcYFSo7oMSzJQ3ntrXr2y74DI/A c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=m7XFIO Xocuagm/FxcWbkKgzgmYZLvqi65tupBbFDKGw=; b=PytZBD4gATHjT7lLMCIeu/ VoXSa6+ssx+UK9nWlqtCKKZL6Ha09YlRL+rQs8ybNwH/DQdebEerdK2fdK4qrUJD EZF9VVYMpCYtsAozOJPBtzU0giWgFzh5a2TDz1TyB4eMrPgpUmWDviqWij3N5uUI ytQ3ZpS9hJrpkGW9t7nYQwqiMicmpfEfjpkoyD9srsT/Zad+GeykvQcRzEOD4KZZ sgYjkGHh66hRjwdLe0X1qQieIAD7n+gG1PM+WyHFN1vKtdAirlvwgN417eYa9YSO J/PfYpBxQf1W2enMQ/wroDEcoPiMWFJD8Lsm057Vna+NKtPlCAQSrjITiS3dGH3Q == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 401272473E; Fri, 13 Oct 2017 05:28:45 -0400 (EDT) From: Thomas Monjalon To: Xiaoyun Li , konstantin.ananyev@intel.com Cc: dev@dpdk.org, bruce.richardson@intel.com, wenzhuo.lu@intel.com, helin.zhang@intel.com Date: Fri, 13 Oct 2017 11:28:44 +0200 Message-ID: <31420042.6nB00FbIV6@xps> In-Reply-To: <1507885309-165144-2-git-send-email-xiaoyun.li@intel.com> References: <1507206794-79941-1-git-send-email-xiaoyun.li@intel.com> <1507885309-165144-1-git-send-email-xiaoyun.li@intel.com> <1507885309-165144-2-git-send-email-xiaoyun.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 09:28:46 -0000 13/10/2017 11:01, Xiaoyun Li: > lib/librte_eal/common/arch/x86/rte_memcpy.c | 59 ++ > lib/librte_eal/common/arch/x86/rte_memcpy_avx2.c | 44 + > .../common/arch/x86/rte_memcpy_avx512f.c | 44 + > lib/librte_eal/common/arch/x86/rte_memcpy_sse.c | 40 + > .../common/include/arch/x86/rte_memcpy.h | 861 +----------------- > .../common/include/arch/x86/rte_memcpy_internal.h | 966 +++++++++++++++++++++ I think that rte_memcpy_internal.h should not be in the include directory. Can it be moved to lib/librte_eal/common/arch/ ? > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > @@ -243,6 +243,7 @@ DPDK_17.11 { > rte_eal_iova_mode; > rte_eal_mbuf_default_mempool_ops; > rte_lcore_has_role; > + rte_memcpy_ptr; I don't know what is the consequence of adding this function in the .map file for architectures where it does not exist?