From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A6B14238D; Fri, 13 Jan 2023 19:34:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3256410EF; Fri, 13 Jan 2023 19:34:30 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 2544F40E03 for ; Fri, 13 Jan 2023 19:34:30 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id A37163200201; Fri, 13 Jan 2023 13:34:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 13 Jan 2023 13:34:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1673634867; x= 1673721267; bh=4K48omeAVB+4V+bzhN0cT742i4P3LgXifr6SYoFOssQ=; b=N HCSP1DYCDPCFk8Ccsg+fBpN+z9Djd7tCbRdYrUH8OuiWn/4qOlv4JGZ22f98/K1B ErSVYBIWK2ZkVVqgzbQ+5EmsNq5CbiQ6U2aP8jXHvtRxtGj4UcsgYPwxO5zxVH/C DBfVph+cLAtKE79aVWtVs0DBsRsQq2vTJUY+FGZkSgy9svDjueAT4gOPPHyif4WQ BXkE8/fkRCoCRWpcEUKDglPHFDQZHfkFfi6qIqES6AyqVEcuEGnZcDIl01dsUiuj KU2Dhv/DficUgfLqdb8Fdx614PB59n4bOyqXFEkwLj8oPr85gC42J8wxKFWvpOfn rMwEvfLhVpdUsS9DMa3Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673634867; x= 1673721267; bh=4K48omeAVB+4V+bzhN0cT742i4P3LgXifr6SYoFOssQ=; b=Y hmplPrXrEws31fGAv6E2v/4lVhp2i8Taay6O7Um4AUqHF5y6AkwpELq1SoKIebI9 Uv7LSLl34IoYL9U4vM1KnIEJoEKSdoxmYbYGIl3KflPAn517utv8K/GIXEFzDpZ0 qKqcuBYOTsgRO+0G1kXZdyOGWWbX9ws9XWi6VXV90Eu9nJS+Ncz+AzeFlDwdbOpd zX8J7YMTglj57nVhfX+iFjOEt19udo+WEyk1wDl/Jbs9yUN2e1JosR7b5wBObRRb zEM4l7zDN+kuzre90jjuh9lQKWERxJO4dxCYi9Q31r6fitk8yXpSk5cXS9WgrIk5 EMIZNPtzsb/NhpnxNPpzg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleekgdduudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Jan 2023 13:34:26 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Cristian Dumitrescu , Bruce Richardson , Anatoly Burakov Subject: Re: [RFC] Remove Kernel Network Interface (KNI) Date: Fri, 13 Jan 2023 19:34:24 +0100 Message-ID: <3142342.SvYEEZNnvj@thomas> In-Reply-To: <20230113091326.20d210c9@hermes.local> References: <20230113050313.87378-1-stephen@networkplumber.org> <2383172.OBFZWjSADL@thomas> <20230113091326.20d210c9@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 13/01/2023 18:13, Stephen Hemminger: > On Fri, 13 Jan 2023 09:12:16 +0100 > Thomas Monjalon wrote: > > > 13/01/2023 06:03, Stephen Hemminger: > > > The Linux special network driver for kernel networking has been > > > a long term problem for DPDK. The performance benefits of KNI > > > are available via virtio-user and XDP, and the simpler kernel > > > interface via TAP is also available. > > > > > > This driver has required lots of effort to keep up with the > > > kernel API changes. And the overall architecture of the driver > > > is fundamentally insecure and has unfixable locking and data > > > race problems. No developer has been willing to do extensive > > > tests or be the maintainer. > > > > > > In short, the time has come to do some early spring cleaning > > > and remove KNI from DPDK 23.03. > > > > In doc/guides/rel_notes/deprecation.rst it is announced > > to be removed in 23.11. Let's keep this RFC for later :) > > > > > > For 23.03 could we add a deprecation log message when library is > used and when kernel module is loaded. We already have a message in the lib: int rte_kni_init(unsigned int max_kni_ifaces __rte_unused) { RTE_LOG(WARNING, KNI, "WARNING: KNI is deprecated and will be removed in DPDK 23.11\n"); It is a good idea to add a message in the kernel module loading.