From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id E2D577E7B for ; Wed, 22 Oct 2014 11:17:03 +0200 (CEST) Received: by mail-wg0-f46.google.com with SMTP id l18so3293295wgh.17 for ; Wed, 22 Oct 2014 02:25:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=H+4Blz/P0hJGqlb3jBL2lD5hgYBhcimTweBJ7bANdiU=; b=kLkGxuwMFSgB/YSQ2MbTGxtk40SoTGGYestll3okotf3e3NJ1HKjjak63VkJIL2Hp3 4Mg6wrtibsxo9SfVimuUQ5OIeHb14oQzmEK+0ayPRQ/E3hN2XHUYr98ptavq80BVqjMX x8v+4fVT2Cp0k01Oby30lLKutlQ3tCCMpBppbviOpmVCdMU8M6BDPr5kpqZYVhGaYeVw yxNAVN0ynKFmassiU3A+3ErKThpIs6qNBnbf502fsVBU0Uyqgq8fVm7twr3GR7F8nnC7 gLOQBfD9AJA416A8RsCrfjK2fKawDYL6lDfUWkKc7uyVLlQdV2EEHGgZ6Dn0jCsFr4+1 Oskg== X-Gm-Message-State: ALoCoQkroYQq5kwobQsbiRP6+leLNBXb2Xy/johA+0vRfEttDbdFs9zAJIZYrf9YJFCZwxzFrZWV X-Received: by 10.180.212.78 with SMTP id ni14mr4242989wic.2.1413969923560; Wed, 22 Oct 2014 02:25:23 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id pn4sm18179371wjc.38.2014.10.22.02.25.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Oct 2014 02:25:22 -0700 (PDT) From: Thomas Monjalon To: "Liu, Jijiang" Date: Wed, 22 Oct 2014 11:25:06 +0200 Message-ID: <3142740.MjSjxYyKcT@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D828AA@SHSMSX101.ccr.corp.intel.com> References: <1413881168-20239-1-git-send-email-jijiang.liu@intel.com> <1893361.J7EnPDFulE@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D828AA@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 5/9] librte_ether:add data structures of VxLAN filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 09:17:04 -0000 2014-10-22 06:45, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2014-10-21 16:46, Jijiang Liu: > > > +#define RTE_TUNNEL_FILTER_TO_QUEUE 1 /**< point to an queue by filter > > type */ > > > > Sorry, I don't understand what is this value for? > > This MACRO is used to indicate if user application hope to filter > incoming packet(s) to a specific queue(multi-queue configuration > is required) using filter type(such as inner MAC + tenant ID). > If the flag is not set, and all incoming packet will always go > to queue 0. 1) It's a boolean, so a new constant is not required. 2) You set the variable "to_queue" with this value but the variable is not used 3) Is there a sense to add a filter with this variable to 0? I think "to_queue" variable and this constant are useless. PS: it seems I'm the only person worried by the filtering API. So maybe we shouldn't integrate it at all? -- Thomas