From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 7D842952 for ; Fri, 28 Oct 2016 18:13:27 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id e69so112093435wmg.0 for ; Fri, 28 Oct 2016 09:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=G+tYsZIdxRa6doLBPdrCLd8PdGp1WVTmCxHUyrDkRIM=; b=TiGvoat1TqMtMbN2nIGpDsjlXXGy7o0v44sjb0z54GahIZAZ2S0MOGidT00AYBwGEY mwH78mV4pOie6KMg9EqiQ0mFPUTENQ28ifSzBmtmmfLK/nQpyZqkFY9Xg0GT+IkSXPee coEZ3NN1GW7MnIKvcN8jMdBg4K96w/01YDjs5hXIeXgR7jZcFwCxdv0B8FHV4uaVa+nA R/GDT4ei9qUllTISHb1oqDkdeXaFl1LTmoxx0EB3AdJ1+HNtw6ZNV46+ob6fWFNr/ucR DYjFMbHOBSyJ5HK30pgAMx0VfFHYitXSgjfmr0RK19DTwJfC8+FNQfXc9vvt/+Q9vex8 NuLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=G+tYsZIdxRa6doLBPdrCLd8PdGp1WVTmCxHUyrDkRIM=; b=brL2od4aPonRY5aMWpi9AMRT30U3+1Jgjw30qXhxqvSw2guoO3AMjO7RK2FVoNygGa CwBZnEMFnhsbZ28bSggq/bbaR8pd7O8jasYL4GmzDSP2sjW4Ns71ZpgxukhOSpK4OEP7 O+bF83/Fbr0GX9FYsgVIE+LpwXci0qPt1s/NpmzCR4ve/qJR0a5UYsmuSCM7oDTBP0r0 U7Ajh/Lt5qtTtAunXISl9wX/w4PMscxEM0DXUc6okOEYWtdI7Q60reNFfFLK/UOrY33O ZhD0C5T0eY6NyDKKs+Ffxd11PUdEYQFn+06hhgHKX0P4PLrE4k1VZQTuDoNFUS8Q8fwD C3HA== X-Gm-Message-State: ABUngvcRMCXQCtgySJ2syZ+fESfrtNlr1p1C4HsiD5rWBXRxkg833kl+2N+f1sLgVxpjn7Fa X-Received: by 10.194.152.102 with SMTP id ux6mr8741190wjb.166.1477671207165; Fri, 28 Oct 2016 09:13:27 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id us3sm14807886wjb.32.2016.10.28.09.13.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2016 09:13:26 -0700 (PDT) From: Thomas Monjalon To: "Richardson, Bruce" Date: Fri, 28 Oct 2016 18:13:25 +0200 Message-ID: <31440590.xYOza9ndpd@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B035B31F7F@IRSMSX103.ger.corp.intel.com> References: <8c7f9d25-b042-6b7e-b197-7873ea7425ef@intel.com> <16238883.tkNBRrfWjK@xps13> <59AF69C657FD0841A61C55336867B5B035B31F7F@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, "Yigit, Ferruh" Subject: Re: [dpdk-dev] KNI discussion in userspace event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 16:13:27 -0000 2016-10-28 15:51, Richardson, Bruce: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > 2016-10-28 15:31, Ferruh Yigit: > > > * virtio-user + vhost-net > > > This can be valid alternative, removes the out of tree kernel module > > > need. But missing control path. Proof of concept work will be done. > > > > That's probably a smart alternative for packet injection. > > What do you mean exactly by "missing control path"? > > We'll have to see how it performs - which is the key gap for data path that KNI fills. Until we get an alternative with (nearly) equivalent performance, there will be demand for KNI to stick around. > The "control path" is the ethtool part, to get stats and do operations on the NIC using command-line tools. > > > > > > * Remove ethtool support ? > > > > That's the other part of KNI. > > It works only for e1000/ixgbe. That's a niche. > > Yes, it's something we need to remove, but again, we need an alternative first. > > > > > > Still there is some interest, will keep it. But not able to extend it > > > to other drivers with current design. > > > > It should be removed one day. > > We must seriously think about a generic alternative. > > Either we add DPDK support in ethtool or we create a dpdk-ethtool. > > (or at least a library as the one in examples/). > > I don't view that as a great path forward. Sure, we can do our own ethtool, but then people will look for ifconfig to work, and "ip" to work, etc. I view having a kernel proxy module as the best path here as it is tool agnostic on the userspace side, rather than trying to make every tool for working with kernel netdevs also have support for dpdk ports. Yes that's the ultimately best solution. But: - we need some cooperation of the kernel team - ethtool manages a device (what DPDK provides) whereas iproute and others manage a TCP/IP stack so is out of control of DPDK. > > Or we do nothing and wait to have more hardware like Mellanox supporting a > > kernel bifurcated driver approach. > > Given the lack of other NICs supporting that, I think it could be quite a wait! Also, it doesn't work for virtio ports, for pcap ports, or any other ports which don't have physical hardware backing them. No reason you shouldn't be able to pull stats from all your dpdk ethdevs, not just the ones with physical hardware. The same ethdev APIs work for them, so should the same tools. Yes, very good point. > > > *KNI PMD > > > Patch is in the mail list, missing comments. If it gets some > > > interest/comments/acks it may go in to next release. > > > > I'm not against KNI PMD but it looks strange to add more support to an old > > dying approach. > > I think the main idea here is to clean up the API - at least for the data path. There is no reason why we need special KNI RX/TX functions, when ethdev RX/TX functions could do the job. However, at a higher level, the more basic requirement is that whatever solution for the data-path to kernel from dpdk is, it needs to appear as an ethdev, and not as a special library with different APIs, as KNI is now. Yes I agree to unifiy (and reduce) API. Why this PMD is not more commented? KNI users should be interested to review it. Please dear community, we need more reviews!