DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Raslan Darawsheh <rasland@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	stable@dpdk.org, Wisam Monther <wisamm@nvidia.com>
Subject: Re: [PATCH v2] app/flow-perf: add missing default option
Date: Wed, 17 Nov 2021 10:49:00 +0100	[thread overview]
Message-ID: <3144311.vIepLxtpYk@thomas> (raw)
In-Reply-To: <DM4PR12MB5039E42CC6EB707F4CD600C3A4999@DM4PR12MB5039.namprd12.prod.outlook.com>

> > Currently, if an invalid parameter is passed to the application it will cause a
> > crash due to missing default in options.
> > 
> > For example:
> >         ./dpdk-test-flow-perf -a 01:00.0 -- --invalid
> > 
> > This adds missing default for options, and prints the invalid option.
> > 
> > Fixes: 3344cf2e3001 ("app/flow-perf: add flow performance skeleton")
> > Cc: wisamm@nvidia.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> Acked-by: Wisam Jaddo <wisamm@nvidia.com>

Applied with title "fix parsing of invalid option", thanks.




      reply	other threads:[~2021-11-17  9:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 12:50 [PATCH] app/flow-perf: report invalid parameters Raslan Darawsheh
2021-11-16 14:12 ` [PATCH v2] app/flow-perf: add missing default option Raslan Darawsheh
2021-11-16 14:18   ` Wisam Monther
2021-11-17  9:49     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3144311.vIepLxtpYk@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=wisamm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).