From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4976A0C41; Wed, 17 Nov 2021 10:49:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E8C240687; Wed, 17 Nov 2021 10:49:03 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 7737440040; Wed, 17 Nov 2021 10:49:02 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1D7A85C01AA; Wed, 17 Nov 2021 04:49:02 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 17 Nov 2021 04:49:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 17X84ikOWZTESc3STR6h22Ey38cFvYEaYEEf7u4odog=; b=bJV5Pi8Y8Lu6riWg ZSoC9/Kd1rTgO/q1M3o1nSgCRh26iNoM6EX1os+F4+MW0Lyj2BPL9C/cpgwYSpZ8 FpIOeg6Lzq4FEdJuKMALElukmxQ33UCj648CKKinhcYo1Cgk/XVXUuWUMx85Y/8e GogGpnGoA0gdegO2P1jca7lkiXBEX3NjVfHIYUdyU0gETQdLL6W0ojv6f5hNbIXZ ij9K6/IMgEU0lihlCnMbPc2eokyF7HtZ2Sje26/p0/CeGbIjKORzuwGSz4dwyWtk Bx4+D04i/YRS207DTfMzOAAHz6UO9MJfDxoRRYxprTI2GPts/alMNoPAhkT/6/L0 /KZITA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=17X84ikOWZTESc3STR6h22Ey38cFvYEaYEEf7u4od og=; b=EBuvG/hQ2NzsiOx/c3kDUs6YOKh71M3YexUaqLcp0mLuH2dgg7GH3NT1H 8qlVUsYRcqREVcEsF3tLcylYWURGMGiemV8LpF6Na56D+IB9MeLZNMBR9o4MYL/O 7pBfAAKtcvZUQVzehYQIcENJhWgBfg8aHEVGB/JrEbI29/jLSWF7HPEtI1dsaebl nC0eyKqvv1rwLkllO+i/vELIhNzO5O3ZslYKMQpCv6WJHxlwCTMi0thi69+4DKxl eQgsVnD24BFDTzW0TE2eeJzQ8uxjrHMaZNxNtsKWRbUne1BA5uuGtX84bCAS0M94 I8Oh5L9WVEmMAVHU4eJzABm80rwyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfeeggddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Nov 2021 04:49:01 -0500 (EST) From: Thomas Monjalon To: Raslan Darawsheh Cc: "dev@dpdk.org" , stable@dpdk.org, Wisam Monther Subject: Re: [PATCH v2] app/flow-perf: add missing default option Date: Wed, 17 Nov 2021 10:49:00 +0100 Message-ID: <3144311.vIepLxtpYk@thomas> In-Reply-To: References: <20211111125032.29087-1-rasland@nvidia.com> <20211116141228.14755-1-rasland@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Currently, if an invalid parameter is passed to the application it will cause a > > crash due to missing default in options. > > > > For example: > > ./dpdk-test-flow-perf -a 01:00.0 -- --invalid > > > > This adds missing default for options, and prints the invalid option. > > > > Fixes: 3344cf2e3001 ("app/flow-perf: add flow performance skeleton") > > Cc: wisamm@nvidia.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Raslan Darawsheh > Acked-by: Wisam Jaddo Applied with title "fix parsing of invalid option", thanks.