From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 447A4A04BA; Wed, 7 Oct 2020 17:05:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C4261BC86; Wed, 7 Oct 2020 17:05:18 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id C341F1BC84 for ; Wed, 7 Oct 2020 17:05:15 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 3A323B43; Wed, 7 Oct 2020 11:05:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 07 Oct 2020 11:05:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= itaiMi4OWMJZ/TnvUnUry61w510j1zif2Spz50r3f4c=; b=ITHOFza7TMpL7nAh TDYbu0w2g2SoolG1YdPu7Ah0LV1iQv97/xE6g/wp9CnjEQp1V8oe4VlYViAzl0vR iXJCp+cFKV9u5sDrB+i5IWBOCemb8xilasBwL6a/YkankJe0Z4YjTi854/CGh4aA K2EGGPgIMpSe719ddJjZjOCIl3DJlwueCwrhrpSRHX18gGqGZ7t3fB8Mx+Xj/TNz E9avb/H3ZGJG7Og09tQZnwUyKFNi9Sbx8e/htZq7c9/Kl1kZOdg4o/Zo3FlpRdjp +f4t6pve/wtRK8MSlXmRAW0/1Mf2idry77mpFtST3enrVDfEOBJw92MFrCYo6td5 r0u7kQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=itaiMi4OWMJZ/TnvUnUry61w510j1zif2Spz50r3f 4c=; b=TbVeSsPOH/dp9YQyboKSbUt/YUCD75TF+JZyb90GLabQ/v1BmCmzxcEor zKiEvB+G64UQnit9NQlwbKuT80btBaVW/JZRfxZjqhMoAPd6rZGIeq7c7h85i1UM bB0h0l6v/y0ho1PMcL+oU5DesDKNmvEA9fsPtA6b76da+ox0mF7qr1XDz5/srFQW FltDLj6wOioIz0GIer/2UtWfUqeDVg/gclkWyjs5lJj9UXJbOpxP1iRkCRxnWguZ bGDF7YyVPoOL7enXrPznBDHPsF+tLOpBkfFH7IyDzHcgAl/d24y4fHOaJbBIF9w9 NZuYUZ292u9vsfckHah0Jz1btNIuA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeeigdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 93343328005A; Wed, 7 Oct 2020 11:05:12 -0400 (EDT) From: Thomas Monjalon To: Jim Harris Cc: dev@dpdk.org, david.marchand@redhat.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Date: Wed, 07 Oct 2020 17:05:11 +0200 Message-ID: <3148596.31tV2P40R3@thomas> In-Reply-To: <20200824211038.48932-1-james.r.harris@intel.com> References: <20200821220650.7901-1-james.r.harris@intel.com> <20200824211038.48932-1-james.r.harris@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] pci/linux: copy new id for inserted device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jim, Sorry I see nobody reviewed your patch. Jim Harris wrote: > + memcpy(&dev2->id, &dev->id, sizeof(dev2->id)); [...] > + memcmp(&dev2->id, &dev->id, sizeof(dev2->id))) Why using memcpy and memcmp instead of simple assignment and comparison?