From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 3F2DE5963 for ; Wed, 10 Feb 2016 18:21:43 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id p63so36014918wmp.1 for ; Wed, 10 Feb 2016 09:21:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=0EBLcAz4aqL+T2uLmscWu2Mbgz81qqFU1PJAkIFvmrM=; b=dhCyf4N038u3Azgp3jltqaZywDipgt3fVeW6+iOQVdjEg23GldTnF9Ewt2VIMMhroG IHObRxB+GMhg8m1j4Hp2x0ZHJsj837XJsRzxhqCbTV5lywd/KTquyXlfMg1I8mc14sB9 zLCn1XPEm+N8uzdA1Ze4ODUmQ4eCyRNBYAD6wmj46RPxbWJZvFkunkPGaZk+mzHvticm +DOJqCttJ7uwsFsp9FoOPDuQpz9FecEk4nVh8N97U8AUAp0/kkm5b+mqsFXdoAO7NXIS aAAoZhigARxtr5dTTAaBvZfucEE+8Jb0lobuqL4XvMrUlmhIXlvSgwspsUJo5SJ/LIcP V+yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=0EBLcAz4aqL+T2uLmscWu2Mbgz81qqFU1PJAkIFvmrM=; b=i1O65GS1KC6sEWNGyNZlBgmUxKtQWeeh+kcfVOCVUuvqFtRVD/EFEqzbudnnZkArsq rblVi16RGBj/HhyKE51C/QmFAqunO/uKl+MdMEu5KAjQu2rAHM4JXFoyYQNQOww33kQd 3twfGd/3w22Y6EKovdD/3RMaW1NFrijLxeGU22R+80gXrDqez8NWIMDnE+Gf89SsxFL2 RTGprHf0I9IGV43kUbbIzaM6lDle9LXRO5TJm4kTiTvFH3WdoXxN92zfFujWIV5J8xr2 cHsSybskQ/Qw/L4Kgllzc0+0Bc6im3SKog377fUjQNgQy49qXa30HigL1e+LybC3gMlu 2LYQ== X-Gm-Message-State: AG10YOTBJrSshdUIAEi/7I8HQcjnfPL9Ehg2hZO22lDns+8h+B+l8KmO3lAqjVOdxtNrpmrb X-Received: by 10.28.6.213 with SMTP id 204mr12254203wmg.47.1455124903089; Wed, 10 Feb 2016 09:21:43 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id v2sm4287636wmd.24.2016.02.10.09.21.42 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 10 Feb 2016 09:21:42 -0800 (PST) From: Thomas Monjalon To: "Mcnamara, John" Date: Wed, 10 Feb 2016 18:20:16 +0100 Message-ID: <3149452.Rm3BBxm9PK@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1450704384-9986-1-git-send-email-bruce.richardson@intel.com> <1455123732-1705-1-git-send-email-john.mcnamara@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/2] version: switch to year/month version numbers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2016 17:21:43 -0000 2016-02-10 17:11, Mcnamara, John: > Hi Alejandro, > > Please note the above change to the nfp_net.c code due to the name change > in the version macro names. > > > I was originally going to change it to this: > > #if RTE_VER_YEAR == 2 && RTE_VER_MONTH >= 1 > dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ; > #endif > > Or better: > > #if RTE_VERSION >= 0x02010000 > dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ; > #endif Or better: #if RTE_VERSION >= RTE_VERSION_NUM(2,1,0,0) > However, since the code was added in DPDK 2.2 the version check doesn't seem > necessary, so I removed it. If you need it back in for some reason let me know. A version check is needed for external applications or external drivers. It should not exist in the git tree.