From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67D0841EB2; Thu, 16 Mar 2023 18:05:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4313D42D73; Thu, 16 Mar 2023 18:05:38 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 70D0840DDC for ; Thu, 16 Mar 2023 18:05:37 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1C45A5C018A; Thu, 16 Mar 2023 13:05:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 16 Mar 2023 13:05:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1678986337; x=1679072737; bh=LToVOCQE+e4yUQdSr5p2Xuufh6WjOG/KQOz EEjMMQC8=; b=t9pG0INgQE86MYFMR0e964LIx9mQWb8Za3YnqNvEWIXges5BfyA hRdnGrjeIQD5/jcbTybYGK6mDAtheHlyS3o3tpfyw4oHIanCl1th3WNfCtm0sfIW u9Nl1X4DRv3ZCawPRkhokW9BFm5OAHNzcB9X4JI+4UHBKFfQ7XiRrLee+nkEYSP5 c65+TmbR6eS7LSpZLF+cup2+1K18+CSW5Jk7xtHv+PGLWob+GkGJ5EDGkIWUh2Ha /im8QBNAWaF+sI+aCyyhUQEjHCahAh+AHZSXWc9n2BZJse2XSHe2ZFegbAtAPh7o TVcznQ1cxstm0USaVZKbB0zIMb3Jn6pR8Vw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678986337; x=1679072737; bh=LToVOCQE+e4yUQdSr5p2Xuufh6WjOG/KQOz EEjMMQC8=; b=diNDnwQvCCBK04Sa6J5zDjc2gb9oNwIeIbbBQFqOuR+DaSocw7y 3tOVI9ajBb4wJSi13k5Va1n7BHcIXGqST5bRY2E81Vwo7xNC+tAAibLwnpd4pHWZ XHU2Z7FXAB5WOQupmfhWlG0DNq2gC4j1dG/BfQigKOSxZCbXwYHkHpqL2Z+yHOmM mIHq/4mtW7Gc5QvRIOEG7OJGlC1qEJ1rcU+oeyK4YWwx20+i93jfjiQrQyuB7ZS0 NmAHX8V3sS8iqGolGurX4zd15+dHuLODql+nwbdT6zvR70PDANVzmh0BO0YBoLh8 PfqhqGCjO5o6gIoJbqPqWHg6caO+k2qn/Rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeftddgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Mar 2023 13:05:36 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , Ferruh Yigit Cc: dev@dpdk.org, David Marchand , Pier Damouny , olivier.matz@6wind.com Subject: Re: [PATCH v4 0/2] Fix testpmd interrupt regression Date: Thu, 16 Mar 2023 18:05:34 +0100 Message-ID: <3151640.5fSG56mABF@thomas> In-Reply-To: References: <20230313171905.67720-1-stephen@networkplumber.org> <20230316083104.3872a538@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/03/2023 18:01, Ferruh Yigit: > On 3/16/2023 3:31 PM, Stephen Hemminger wrote: > > On Thu, 16 Mar 2023 12:20:41 +0000 > > Ferruh Yigit wrote: > > > >> On 3/15/2023 5:31 PM, Stephen Hemminger wrote: > >>> Resolve issues from using control-C in testpmd. > >>> Fixes regression from recent change to use cmdline_poll(). > >>> > >>> v4 - drop sig_atomic_t. Not required requires changes on > >>> some platforms. > >>> > >>> Stephen Hemminger (2): > >>> testpmd: go back to using cmdline_interact > >>> testpmd: enable interrupt in interactive mode > >>> > >>> app/test-pmd/cmdline.c | 27 ++++++++++++++------------- > >>> app/test-pmd/testpmd.c | 11 +++++++++++ > >>> lib/cmdline/cmdline.h | 10 ++++++++++ > >>> lib/cmdline/cmdline_os_unix.c | 8 +++++++- > >>> lib/cmdline/cmdline_os_windows.c | 18 ++++++++++++++++-- > >>> lib/cmdline/cmdline_private.h | 2 +- > >>> lib/cmdline/version.map | 3 +++ > >>> 7 files changed, 62 insertions(+), 17 deletions(-) > >>> > >> > >> This solution is adding new cmdline API for -rc3 and there are some > >> testpmd changes, > >> can it be possible to have a simple workaround specific to window for > >> this release and get this set for next release? > > > > > > Not really. cmdline_poll() is broken in several ways. > > Don't want to fix it or use it. > > What about to revert the original fix [^1] in this release and get a new > version of it at early next release? > > @Thomas, what do you think? I think better to decide before -rc3. We should not add risky changes at this stage. Also I would prefer to see a review from Olivier, the cmdline maintainer. The reason of this breakage was a cleanup. I think it is more reasonnable to revert.