From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix build
Date: Fri, 17 Apr 2020 23:14:35 +0200 [thread overview]
Message-ID: <3152428.ucjEoNaZvj@thomas> (raw)
In-Reply-To: <20200417185534.2285671-1-ferruh.yigit@intel.com>
17/04/2020 20:55, Ferruh Yigit:
> Build fails because '__rte_unused' macro not defined in file, error
> produced by 'i686-native-linux-gcc config' but it seems generic issue.
>
> Build error:
> .../examples/vm_power_manager/oob_monitor_nop.c:11:13:
> error: expected ‘;’ before ‘static’
> 11 | __rte_unused static float
> | ^~~~~~~
> | ;
> .../examples/vm_power_manager/oob_monitor_nop.c:12:14:
> error: unknown type name ‘__rte_unused’
> 12 | apply_policy(__rte_unused int core)
> | ^~~~~~~~~~~~
> .../examples/vm_power_manager/oob_monitor_nop.c:18:21:
> error: unknown type name ‘__rte_unused’
> 18 | add_core_to_monitor(__rte_unused int core)
> | ^~~~~~~~~~~~
> .../examples/vm_power_manager/oob_monitor_nop.c:24:26:
> error: unknown type name ‘__rte_unused’
> 24 | remove_core_from_monitor(__rte_unused int core)
> | ^~~~~~~~~~~~
>
> Including 'rte_common.h' header which defines the macro for fix.
>
> Fixes: f2fc83b40f06 ("replace unused attributes")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
The file oob_monitor_nop.c is not compiled on x86_64.
Unfortunately, my build matrix does not include vm_power_manager
on i686.
Applied, thanks
prev parent reply other threads:[~2020-04-17 21:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 18:55 Ferruh Yigit
2020-04-17 21:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3152428.ucjEoNaZvj@thomas \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).