From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E7F3A0C4E; Mon, 25 Oct 2021 21:48:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B76640E3C; Mon, 25 Oct 2021 21:48:57 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 898954003E for ; Mon, 25 Oct 2021 21:48:55 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 9CA2632021CA; Mon, 25 Oct 2021 15:48:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 25 Oct 2021 15:48:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= foATttWNcEm9qaxWonAMl/g5bkRi++4e06U2iMVceyk=; b=CJgmba33u/sMTMMJ qEwHJBnGrtV+fs/WrMtucunlHcu63sB0sBQBAItJZrKE1TtmiBq4VeNqIBs71NBc 0IEw6eHY6fog4bmt0L4Gsu8pnLhbUVuDpiQwiEWo4q2PZZPpROo+zeA/rn69NHJz g2JjgF9XaZIIcqDL/lvWgpDVs1E6zo1v1GBWMl0LOj+5ik10f/GKUxW4MbbZ/xr+ fyACivbgIHGe/MN+gexsFNbt356yhhehxKvicClhrtuUEFYxfWNd6a5sozH9yZac NsFZd+HozewcfaG/XC9t+tUOGqY5Y/3Z1sqXIFnRNjdV4jQrg6vUJgpvTW4Ht5yq MJtG8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=foATttWNcEm9qaxWonAMl/g5bkRi++4e06U2iMVce yk=; b=VcRvn5w1hQPhnWxyA7hgSszx6B22Hi3NtLTq80wr01ssxHFfWXCk9fZV1 qRt6rPw2ZAWEsS3sPpp2ZOgppJu3eDD9zskiEO93D0JtGxV1sVk37dYuSBs6ZYrp T9vIhHaHcT+FyHeWzeJiVL7eRUGld8aAYbegEjqOd/rk0SCK6xZiSouc2FkjD6Pm kt7QGGyepJI4ZRcxBHDClTSPKJ8j622G9M0LwSRjtxBhsU7DfMA2XckAZutCzlsj x4quGyABpUYpUW4XdIxHM8Ql8U+1c9DcfPXgs95cffStb8qLANnt6JL0pry5sftU nFSZrtFlXxmvkcjXpuFo79xf3qzvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefhedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Oct 2021 15:48:52 -0400 (EDT) From: Thomas Monjalon To: Sarosh Arif Cc: dev@dpdk.org, Bruce Richardson Date: Mon, 25 Oct 2021 21:48:51 +0200 Message-ID: <3152738.G4va1dxgnP@thomas> In-Reply-To: References: <20211013072303.157394-1-sarosh.arif@emumba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd: add promiscuous mode selection through command line option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/10/2021 10:28, Bruce Richardson: > On Wed, Oct 13, 2021 at 12:23:03PM +0500, Sarosh Arif wrote: > > The default behaviour of l2fwd is to exit if we are unable to turn > > promiscuous mode on. On some aws instances turning promiscuous mode > > on is not permitted. In such cases there should be a way to run the > > application without promiscuous mode. > > > > This patch allows user to turn promiscuous mode on via command line > > parameter. l3fwd has a similar option available. > > > > Signed-off-by: Sarosh Arif > > --- > > This is a behaviour change, but since this is sample application, I think > it's acceptable, and agree that the change is needed. > > Acked-by: Bruce Richardson Applied (with small reformat of the doc), thanks.