From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 434BCA0352; Tue, 25 Jan 2022 15:49:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19F5D426F4; Tue, 25 Jan 2022 15:49:15 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C5C64426E4 for ; Tue, 25 Jan 2022 15:49:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643122153; x=1674658153; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=munaWm08j2DAlpxORl5ud/MVDxSCKZ9CcJDJjTT1uJE=; b=CQeXKg27gVVQLD8njJMG+W+prZEju0cQZUgK+xPZNm3Bt+ekOXhnhml2 pV3xKcyt6nC3pClCgaK4+1NEB6KrPaIGu9Sf6qmcBmf59mjSKU2t6kG3w 68WvtoIloyVV9hDkORVVqRiSaH0eo0uLsEaDjrJkjMQ78ooPidGYL/kOz o4NMtwA0OgSPi1LdODHvpby2WiaEuIdo5duim3NUxrsr1n1LPMQBOSpKZ r9JpWPR19vKrlo4DW/VImJSgn2eN70Ua0m3wESr3aj6Qfj2UrbPAfU0oE EAwhFtH/wZ/7dDLVp0AEQszfqTD9fBE82g9v0aOvnSc2ThI6uMk8/vq8k Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="233686509" X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="233686509" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 06:49:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="534752937" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 25 Jan 2022 06:49:12 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 06:49:11 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 06:49:11 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 06:49:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dKfHzIVibtsanObtrj/ip1BRb7dlJBRbYvJZRhC59Gk3kLTYiVLphoveEvbVM0myTOA0BbgiK4D3ZL47LCWxapAJAlnIZVFn3GeQGF/IA8ZR1teuj9IfJnnCEl/7PuT+5VWZhmmf58eiA974gAbPy5szraifhMuuMDfrtr3F8+UngaEfnKm6k3ulaTy/37gf2z9v0QaYA1DohIU67M0nyoYcsfQ2HzME7jxWYOgcBmDIDGPbcZPRQx1VnYC0xNu6JN+c9fCfegM2jt3RGJdkl/isUvdsfEbnEDWyuCdZ7GRRPHspUP9fbc25SC7ltmrXtFDmjWzQ39HIQzE5jDEwfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7xFjYo7EtlVRv68W1UzETjcJKqR8Hx93yomWmlYu99Y=; b=e1H/jk0GoeIh67U6Vg3sZeqKYLRy6bMKr6q7dwcuoL3QBhBEmxzkkvCL9kO3DNXdrB/1Xb6DdgQs9EUhqN83Ju0ydeJCzdtOzLHpxqS5vFeQOiGf3M1f3zll6CC+fLuOe4JiZwVdUdyIvAAkW9tECoCIlKsQnKRXohwWqv+bDf8c3kggUwqMxNMCASTy7Dhrdw3szKZKivobNmRm7hec6uES+zx7224U32eJ0ieoXmiB3o6ZF/2wGSUGTKQ9IPWYilpwCKIXPzllfmADXrOgSEymMw61eUriazAqNkz84GadI/DHEGaI9HnjUT3aq1tdPpnY5V54enDY1gmCS3/iWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by CY4PR11MB2039.namprd11.prod.outlook.com (2603:10b6:903:22::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Tue, 25 Jan 2022 14:49:07 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5097:78f8:816f:f243]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5097:78f8:816f:f243%6]) with mapi id 15.20.4930.015; Tue, 25 Jan 2022 14:49:06 +0000 Message-ID: <31531e36-81c2-e6de-62ae-35f0d89c381c@intel.com> Date: Tue, 25 Jan 2022 14:49:00 +0000 Content-Language: en-US To: Steve Yang , CC: , , , , Wenzhuo Lu References: <20220120025931.574106-1-stevex.yang@intel.com> <20220120025931.574106-2-stevex.yang@intel.com> From: Ferruh Yigit Subject: Re: [PATCH 1/2] net/ice: add module EEPROM ops for ice X-User: ferruhy In-Reply-To: <20220120025931.574106-2-stevex.yang@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0296.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::13) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3be2e600-6c1a-4ae1-328b-08d9e011d63a X-MS-TrafficTypeDiagnostic: CY4PR11MB2039:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mVPCtb4RawwQTfdPa8gqv6tKggKeDWuIqsDfhLe47xsFW+NCNehG3fnT4gtblkBxanMwJ8hIhAMQX1mt1DH01wUbDZpKMjZcezmcccYpulDC/tWdSeKY4TD0Pjm2cDYMQKtdU7ADd4DdjFy7CoErxEuf7vZAPYkovhXk11t/ecYqCREr0La11+Hiy9VCGmQ0Zi+JR/p01UxCos72bmT5q7ezJvHGGMljTFi4x+vyeNK/ZCB/2aU0W/Gt4HgRGPtZkfCJBqMnD6IXr+MJRK1uakTsO043T0gctyAVtA7AJyfpQQ8lj6zKzg5+0oc/LXy2a9+scXlyfMG0v0JlEcNMYxzDVb0OrM+8mm7MiDuUQDoEkTtO3VmblR9G7nRCk1x+T8+dz0sPGIASLn9uBgG6fdqDAtkXIm1154HxLilKfC67yGQQYng/KxhNb5gnaWDsgVkPBCTeMyraLvZZHGxRDk/zFNDcuP8UCs1STpxZxVVj7BFvYDDE8LDz5O0GYrMZwFLneawUSn0hmeTGhLy+7zi+Wwv03tOSHJtNrjuwd9A9eWDeahLxycJUlkuBBGZRANsyD3VJTb6BoYNTLRFm97RX+rR5175ZHuirrItyccMVHG3EW7XS5pHIPwOwK0jzYqdkj3v4kVh08AeDB5wG2aQIIIxq+J84pcGodaACDAtY+enVn9rAL/SJ7O040igiwza2daPyOLfEE3MsyzRqeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(508600001)(36756003)(316002)(53546011)(6512007)(82960400001)(66946007)(66476007)(6486002)(66556008)(5660300002)(31696002)(6506007)(107886003)(38100700002)(4326008)(2906002)(4744005)(26005)(6666004)(31686004)(86362001)(186003)(8676002)(44832011)(8936002)(2616005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1NHWFZtM0pRZ0wrZmEvcGZiSHo3UkZpR2pEdFBoOGg1MnRScUNTb2xmd1hl?= =?utf-8?B?dVNQd09Ob0tZcTM4d0tvc1pMWVBnZFRUSjM3RTNab3hJTWQyZjFuWnFXem5H?= =?utf-8?B?VFFCYUdoTTVkajgxWUV2WjJCakt2a25QYXd2QncrUGpleFc2aFk5ZWFuOWtZ?= =?utf-8?B?UCtnQW5IT3VoeklmQ0Ivc2VRbGNlaWZhWGcweExFTFVtSlUxNmpVN1RiNFBH?= =?utf-8?B?b1dLZ0RTZXNndXVUaFZsMEUzdnRpeHBZeFlVbmdValNsS0F1MnRjMy80YTJZ?= =?utf-8?B?aGcwM213N2VWVHRHbjg5Y1lqN3lHaHhhSHlTNmk2UWp2QWhUN083WGVtWlNX?= =?utf-8?B?MnhYMHl0MURpOUt4SzJMYXpRMHRHOFZOcDB2QmRxdUhESDdRNXdBbXRwVWdC?= =?utf-8?B?RUhob285VEtubHJxWnNvc0FETTBsc1FLYUFTYmNRRGRmVWNwUjI2clhIYWI5?= =?utf-8?B?NlA5OHR3MDlWV3pBbDlHNkJmbXUvQklZRjdoY2xCSDVpVUVpelJRS2tveDcx?= =?utf-8?B?bWlGZzgwTWlvdVNCUkdxV3ZIK3k1QzZxTVJ2bGxJR0lDbWdEUFc4ZnNtbktN?= =?utf-8?B?NjlCcGRJdlkwVUZ3RDNZNVdMbXZpZDdOMmtMeFNXdWxlYVpsaUc0ME9tM25r?= =?utf-8?B?TjNKc1ZyYVdRWlhqcmpjbDVQQkMybW5lY0gwTWJiYlI2RVZ4VGxCNGJBa20r?= =?utf-8?B?Z1dENmZOc3FDOUUrMnNvRHBvMkYrTStXWkRKMVJCYjJPQ1JHdTZTMTE5SzM5?= =?utf-8?B?dUtMVjRCeUx6Y0w0emcyQ1I0NGsydVJvaG9JZzJKK2ZBdDhEbHphRnJmTXkv?= =?utf-8?B?RUhNdlArM1ZyY05WQ1AxSzdRVGI3YnVGK0x1RWVlVExsYU9xTlQwYnFFVHBW?= =?utf-8?B?eS8ydVplTHoxcVYvbS9xUmdvcDgzZVJOcnh4cmNNQTVaNXdFZFlWS0gxbFl1?= =?utf-8?B?WC9YLzhsYXQ3SGk3MTMrQW1EdVVsU3lRK0E3WStvb3A2SFJmVWdwaHVoZE9x?= =?utf-8?B?UjJTbEJudUs5a1ZiS1pseno2NG5PcU1TdTNhKzFpTHVVcjNVMXNyS29nRzNw?= =?utf-8?B?VlFQK0xNQlN5UnBIUkQ5TG9HWkZickxCdy9SczJSSVZYMnNRR1h3dG9teFR5?= =?utf-8?B?QS82QXU4bjdVOWQ1YUxlWldaRTV5bjkzcmpFVG5Pblp5bU5KaXh5QU40WkdZ?= =?utf-8?B?Ty9RdUhjVUZqTEFlZ1EzL290TWlkbjRaOXNUSjJTYld2dUY0V2RJSXAvYXpK?= =?utf-8?B?UERCYTZ3bXd6UjFnSlRxbzIvU3pQaEdWUmdVNkthK25nWjRRK1lHVUtyTzVY?= =?utf-8?B?cDVwaTROL3FkM2xnaDBmNWtXV0VQMmxnVXJwTld4SUJpVzE4RlNXV05jaEMw?= =?utf-8?B?TXRFd3pKK0lpYlNzajhFWU4yNjhqSVdVeHI3L0cxNUFpYTI3L1ZsSC93VTgv?= =?utf-8?B?WnBTREVqSFJtTXZIOW1RZlkzdmFuR1ppRG5NVjhPVkF4bStmQll3Q1dNNEZX?= =?utf-8?B?ZHp1SzM5SzUvNitENUVCRXBUZ1hXNGVpcGl4YXVlR0xOdDQyaW5mNjQzMEQ3?= =?utf-8?B?aWJBV3V1ZXF3eHljQkxsMFk2MEpvUExZUFJKNUdMNzJRU0FzWmNHTkpPbE9U?= =?utf-8?B?d3RKczRJcCs2L2hlMGlPdWp3cjFpMFhqb0ZyMkRORy8zWFVRRWVuQ28wUWc0?= =?utf-8?B?Sjk1ZDBEdlZwRnAvYjkyZGVBZlcydWYxR2lZNnk1ZGZXWHNIQTR4ckI0TVhE?= =?utf-8?B?bnFXdS9NcU1WeVJRK1gyWlVtdDZaQWFmUVR3VVZDVCtmRnB3SEI2RjNYSmN2?= =?utf-8?B?TzMyUmVxakw2Mi9adDVycFZNVWVtSFZPNXlGMVdwSzFVVUVFbzRWd2M3dTJ1?= =?utf-8?B?UzQ4MVBsVUV5bTg4UWlBdXM1RldkdzgxQytnaFZXbHRJZkRvSFdMbzBFSnZZ?= =?utf-8?B?WUtGNVdKc0JhMnVYZThuZ2hyYTBJaXZzeUQrc1ZpOXlXK0FGS28yY040azlq?= =?utf-8?B?R1c1M3lYd0tyL3NoVWtNZ3pveXB6QjZJSkdsTjJOMVZsUUpkREFKK1c0alBz?= =?utf-8?B?L1Y5OU1Kc1hNa1p6aGxtajVsRHhFdjBxUm1HOXc2WEJMVUw0aSs5eDZ3bVlG?= =?utf-8?B?dmdvTXZSZGM1N0VsYjcweVREZTFteStNRjZodlptMWlDeTZjNWx6Y0tkb0RQ?= =?utf-8?Q?10g4T3sW3QdN52gxycbqKsM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3be2e600-6c1a-4ae1-328b-08d9e011d63a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2022 14:49:06.5822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7qosurDBiLRpSJ4foVN4OpFUjLMlLirE/KXo1AQfjU3sJoAdTEBg12+4rKKHK6FbfbHy5GgVc4rSb04MjRUuUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB2039 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/20/2022 2:59 AM, Steve Yang wrote: > Add new callbacks for eth_dev_ops of ice to get the information > and data of plugin module EEPROM. > > Signed-off-by: Steve Yang > --- > drivers/net/ice/ice_ethdev.c | 160 +++++++++++++++++++++++++++++++++++ > drivers/net/ice/ice_ethdev.h | 25 ++++++ > 2 files changed, 185 insertions(+) In the 'doc/guides/nics/features/ice.ini' file, the "Module EEPROM dump" feature already documented as supported, but it is this patch add that support. It looks like documenting "Module EEPROM dump" was mistake [1], intention was to document "EEPROM dump" feature. Steve, can you please send another patch to fix it? [1] Fixes: d0dd1c8e1997 ("net/ice: support EEPROM information getting") Thanks, ferruh