From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 2A81A2BA0 for ; Tue, 22 Mar 2016 21:08:39 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id r129so109241009wmr.1 for ; Tue, 22 Mar 2016 13:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=oWpNQtNdpdBvtdCxz+goTCQHBdWcMMIurvb9218gVeU=; b=yb1+g9A2nrey0w6xCtL45w9nZ8n/eezcLzayRxFIl4nIhHy2XJJUYGgSiBFmnRCALi TmMwfTE2c90UkA52JE8O4MSapmpjDV8UUXFTki9561gKZBF+szJbshjE8VOq02M7HQco L3YdRKSQ0bh7lyGV/0mtXOYhT5Z429U2DPCI5RnRPp1k/lcltCo4QKz7KA75tcWoH/hc GG0165pGuSy5aWMzXb7Q9mOws44wMnzyBZrA1xT0a3L27h+hiFXtDbDfzacM2QCNCf7F DgMDX3wprZ0ez9YN+MyE06EP4kfro8xrr1uUtY01ecrqeU6QAazik/iOunxPwLBrhFAO MF4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=oWpNQtNdpdBvtdCxz+goTCQHBdWcMMIurvb9218gVeU=; b=eaCPuK1OnRPHi6cdGRoz53Mb6GzooFc+L76TUm8f4hAj5JBSRWd4IjDBw42Le9+dSF Xki2P0BE57nCEShT/ef1Q5ggHF8LlK/1WT+xZqSu1LSM5EYqwGZvgQ43Gd8Cs+fZeL/F Yh3CJxSrPC+i9LjEdLxndO1EXICXlRjWt+ETJdUdg7D2j3pceKkm4uceN6UhEGRvQ8YU EBFJTwlD7m88Jg52AoMlttVrU6uKKvcBKn3zmXCX1E0OX/Pl/h85BL5YEsPXxoNzNJPa s0+puLH1mrtvfg6NY0s0XkQFt9uNREeQr0ApVkoEFG1NCM/aykx/YYDqvL+5DN1e5pD1 HqqA== X-Gm-Message-State: AD7BkJLHZoLPFz4uYh6wdZSnehioelAL9oKgXiS81uiaY/jv0uOFZTi9dG83CvyneDX/Rb6p X-Received: by 10.28.216.141 with SMTP id p135mr22903142wmg.22.1458677319025; Tue, 22 Mar 2016 13:08:39 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id i1sm31657071wjs.45.2016.03.22.13.08.38 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 22 Mar 2016 13:08:38 -0700 (PDT) From: Thomas Monjalon To: Aaron Conole Cc: Panu Matilainen , "Lu, Wenzhuo" , dev@dpdk.org, Bruce Richardson Date: Tue, 22 Mar 2016 21:06:58 +0100 Message-ID: <3160638.7nQCDhkLkr@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56D576C7.9060108@redhat.com> References: <1456426121-21423-1-git-send-email-aconole@redhat.com> <56D576C7.9060108@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/8] drivers/net/e1000: Fix missing brackets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 20:08:39 -0000 2016-03-01 13:02, Panu Matilainen: > On 02/26/2016 03:13 PM, Aaron Conole wrote: > > "Lu, Wenzhuo" writes: > >> Normally we will not maintain the base code. It's just taken from kernel driver. > >> Agree with you that the whitespace is misleading. But as it's no real > >> impact. I'd like to say not a big deal, better not change it. :) > > > > Thanks for this hint. It turns out my patch is wrong. It should actually > > be this (and I've confirmed by looking at the drivers): [...] > > I will cook up a v2 of this patch if it makes sense. It is a real bug, > > so should be fixed. Yes, waiting for your v2. > Yes, it quite clearly is a real bug and there needs to be a documented > way of getting these things fixed. The README in the base/ directory is > not particularly helpful, since it only says "dont touch it". Yes don't touch it ;) > This is apparently fixed in FreeBSD codebase so fixing it would be > "just" a matter of pulling in a newer version. Probably. > The other alternatives are either disabling the whole driver in gcc 6 > builds, or paper over the bug with warning disablers, or have everybody > patch their packages locally to fix it, all of which just feel so stupid > they're not alternatives, really. No they are not sane alternatives. > OTOH the bug has been there for 2.5 years (since commit > 38db3f7f50bde45477f564783a06ac8fbd3348fa) and nobody has noticed... > > Thomas, Bruce, thoughts/comments? It is in the hands of Wenzhuo, the e1000 maintainer. You just need his ack.