From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 007C41B675 for <dev@dpdk.org>; Tue, 3 Apr 2018 09:35:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A31C821215; Tue, 3 Apr 2018 03:35:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 03 Apr 2018 03:35:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=bFLfbR5hln5ilLhZardhyaXCL/ dx0+mpo2Bd1gAn6jc=; b=nE0beNdW0NtQxyK6EUtEfyTShzjmX+kHSe0oqTTB5w cxZE2XowLBQdc1IM5jRLMO3qhG6hJ5PP3UAMaLHV0AAGI9wLNWW+sKrmq+0Au/tz 6xGm0eHmcnYQ8LNUmZpOREdlVz7WiYTbd/VeEVB9u7AF37azoPXMyNnO4C2arpdu 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=bFLfbR 5hln5ilLhZardhyaXCL/dx0+mpo2Bd1gAn6jc=; b=RP5S0JMd+QzMa3irxyca/t qwdR0zrmqcZqn/raEurtuVWsG4+QJ2wNr4h++rSqzHZu/DRo4UtHCFhwGMLSKWsy AWmo94jrPofK7G9fYG3a4ADA4GpKLlSlu6x8Uuupaff2dEAq6Ig/zpeoJ0QpIN1A cfHSbq3fQ7ZcOhQbg6F3LRsP9E3x3M6qq4gWQJVziK76ku2vTg7bgs4rtN1vJVGY YsauTgugrLzyQI3Z6g7icpjOetVsipzAAG5pLlkoXIl4hycugyVE71j+dvET++6n bhjtgTHnArbCunkPwrO5kqcnB9OxRLFPXcIRDkRolbukvxa111gCgf1BqPLFVnlQ == X-ME-Sender: <xms:qi7DWvafPzloLMstJuTp-V3_6z2uX6TdeNpOcMa41AyuvwtUwPYgsg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1A149E4472; Tue, 3 Apr 2018 03:35:06 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Shreyansh Jain <shreyansh.jain@nxp.com> Cc: hemant.agrawal@nxp.com, dev@dpdk.org Date: Tue, 03 Apr 2018 09:03:58 +0200 Message-ID: <3161325.7B0DNJKXUk@xps> In-Reply-To: <5df8c54e-a750-e576-9adb-50ff863872d3@nxp.com> References: <20180402220649.662-1-thomas@monjalon.net> <5df8c54e-a750-e576-9adb-50ff863872d3@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] config: remove useless lines for DPAA2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 03 Apr 2018 07:35:07 -0000 03/04/2018 08:55, Shreyansh Jain: > On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote: > > Some comments are not relevant in a config which only overrides > > the default config. > > > > The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled > > by default so it can be removed from this file. > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > --- > > config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 ------- > > 1 file changed, 7 deletions(-) > > I think DEBUG_DRIVER should exist in local config so that a developer > can easily toggle it without modifying the common_base, which should > serves as repository rather than toggle. No, the file to be modified is .config in the build directory, not the default config. > I do see the problem that having an option in common_base and then > having it again in local config without overriding (=n) - is non-intuitive. > > But, I still feel it is easier to control changes in local config - > (make T=<local config>) is easily visible. It is not a local config file. The local config is .config.