From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0A3A45B52; Wed, 16 Oct 2024 18:17:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EAA540150; Wed, 16 Oct 2024 18:17:31 +0200 (CEST) Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by mails.dpdk.org (Postfix) with ESMTP id AC644400D6 for ; Wed, 16 Oct 2024 18:17:29 +0200 (CEST) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 4B23711401DA; Wed, 16 Oct 2024 12:17:29 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Wed, 16 Oct 2024 12:17:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1729095449; x=1729181849; bh=hdsDTxElbfCopwwSXVyw+e12Xk+akF6G1EHx1SDe7LI=; b= Xj5aNyG2IxBLRh7sOPrP67SAtdoPViHqiT9pO92VE4o5OszkG4UK2wrFCR1WWPLZ R07MuTs5fXZF/gcwuxK8QvCvyarqCza1rTFv4AE+BIit7iiEwCKCKBrbYTqPrFI4 TX2xbyNN/LwJ4p3N9tC9yWEypXRqHIRTlDX3VJmrxEff4FSpM1NzgXjKJHYAaK57 8+XrilYiuCpiCUlpbwh6kZ+7JGXtSyidEzTnyxfZu2nz1q4rk2wkrVxl7aZWNv6t 6z5TdAaW40UFbZopSHH2sXW6KCl3+qj6gaf+u431tctbEObiq/h31AtghtXJMT+X RvEwlT+xMfdFe2lp5gmV7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1729095449; x= 1729181849; bh=hdsDTxElbfCopwwSXVyw+e12Xk+akF6G1EHx1SDe7LI=; b=D LAW5HkIGzswYm62HqYg3TT8bJtsGOeskbfiv1ZJUx1SlH4luSKxuvNZtqa4b3hUd ZCDAKM+vxXKaAXThB/q+1wUMsIn5BzK/XDiLnzNeadTfquwbfEPE7oGAvCKMyosk 9Ke+2JWbmjld8cwlDaCY5DAg2T1LJJIcJeC+tfGDSQIh7CF/RxxaPlFTyUiZC31O d15xRTOCRjGU+O5hZnM/pxfYEZLwUyzTRx3ajnlOpuRYRYqoucMIRhg+e1/wEPf+ y4aG2niCsLIqzWAmAL14g8TeZSVs6+584zUNYzyT2nJmuUs9bT/T3RNu865K2M3i IukhmDTgnYZde8c8I5FUA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdegledgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedt heevtdekiedvueeuvdeiuddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeekpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehmsgessh hmrghrthhshhgrrhgvshihshhtvghmshdrtghomhdprhgtphhtthhopegurghvihgurdhm rghrtghhrghnugesrhgvughhrghtrdgtohhmpdhrtghpthhtohephhhofhhorhhssehlhi hsrghtohhrrdhlihhurdhsvgdprhgtphhtthhopeguvghvseguphgukhdrohhrghdprhgt phhtthhopegsrhhutggvrdhrihgthhgrrhgushhonhesihhnthgvlhdrtghomhdprhgtph htthhopehkthhrrgihnhhorhesrhgvughhrghtrdgtohhmpdhrtghpthhtohepmhgrthht ihgrshdrrhhonhhnsghlohhmsegvrhhitghsshhonhdrtghomhdprhgtphhtthhopehroh hrvghtiihlrgeslhhinhhugidrmhhitghrohhsohhfthdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 16 Oct 2024 12:17:27 -0400 (EDT) From: Thomas Monjalon To: Morten =?UTF-8?B?QnLDuHJ1cA==?= , David Marchand , Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: dev@dpdk.org, bruce.richardson@intel.com, ktraynor@redhat.com, Mattias =?UTF-8?B?UsO2bm5ibG9t?= , Tyler Retzlaff Subject: Re: [PATCH v2 2/4] bitset: fix build for GCC without experimental API Date: Wed, 16 Oct 2024 18:17:25 +0200 Message-ID: <3162268.xgJ6IN8ObU@thomas> In-Reply-To: References: <20241015121046.2556695-1-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35E9F7EF@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/10/2024 18:03, Mattias R=C3=B6nnblom: > On 2024-10-16 17:42, Morten Br=C3=B8rup wrote: > >> From: David Marchand [mailto:david.marchand@redhat.com] > >> Sent: Wednesday, 16 October 2024 17.37 > >> > >> On Wed, Oct 16, 2024 at 4:14=E2=80=AFPM Mattias R=C3=B6nnblom > >> wrote: > >>> > >>> On 2024-10-16 13:38, David Marchand wrote: > >>>> For a reason similar to the change on bitops header, hide bitset > >>>> implementation relying on experimental API. > >>>> > >>>> Fixes: 99a1197647d8 ("eal: add bitset type") > >>>> > >>>> Signed-off-by: David Marchand > >>>> Acked-by: Morten Br=C3=B8rup > >>>> --- > >>>> lib/eal/include/rte_bitset.h | 123 > >> +++++++++++++++++++++++++++++++++++ > >>>> 1 file changed, 123 insertions(+) > >>>> > >>>> diff --git a/lib/eal/include/rte_bitset.h > >> b/lib/eal/include/rte_bitset.h > >>>> index 74c643a72a..8ae8425fc2 100644 > >>>> --- a/lib/eal/include/rte_bitset.h > >>>> +++ b/lib/eal/include/rte_bitset.h > >>>> @@ -255,7 +255,13 @@ __rte_experimental > >>>> static inline bool > >>>> rte_bitset_test(const uint64_t *bitset, size_t bit_num) > >>>> { > >>>> +#ifdef ALLOW_EXPERIMENTAL_API > >>>> return __RTE_BITSET_DELEGATE(rte_bit_test, bitset, bit_num); > >>>> +#else > >>>> + RTE_SET_USED(bitset); > >>>> + RTE_SET_USED(bit_num); > >>>> + return false; > >>> > >>> This is no RTE_VERIFY(0) here, because this is just dummy code, that > >>> will never be run. Is that correct? > >> > >> Adding a RTE_VERIFY(false) is an interesting idea. > >> It is not supposed to be run, indeed. > >=20 > > Great idea. > >=20 > >> > >> Do you prefer I respin with this? > >=20 > > No need. > > Instead, create a ticket in Bugzilla so RTE_VERIFY(false) goes in every= where there is dummy code, not just here. > >=20 >=20 > No experimental function is supposed to be invoked, if=20 > ALLOW_EXPERIMENTAL_API is not set, right? So RTE_VERIFY(), or its=20 > compile-time equivalent, should be in every such function, not just the=20 > broken ones. There is no other experimental dummy branch in the current version. I think respin is a good option.