From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3A50A00C3; Wed, 23 Nov 2022 17:33:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E5D842D9C; Wed, 23 Nov 2022 17:33:27 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id A250540E5A; Wed, 23 Nov 2022 17:33:25 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3CCEA5C0108; Wed, 23 Nov 2022 11:33:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 23 Nov 2022 11:33:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669221205; x= 1669307605; bh=0HjNkEY+EDRARgKuZfYD3Us3TDMuMDiM07FGkEyvlGc=; b=l Wo7yU6NfN95ntnjBSuuVE4mBWWyYDMemfrQzgevwxigB7ewmsnylJp/WIXqAyeDx r1ohxnYLIE9xXnBJvwcCjbO004uOzMJhjJM06vSJTSb68eu2yXziDaTu91ZoJ+sF xvenTrN0jad6TC0EcrtDW4Des0IiVAqAA6DM/X3kA6+kMObPET+GOc6ewKbz4gzA 05D8z97eeljkFE3EbwoAx5d5GBg3sXYHE/zj1KVQmbF390AXFdecdZrefqQWc6PP JwKiNyBasZRXMG7Cp9C/ak5a54fPrWrSp/6gIv3i/VZx5MYDzi6UEfwnCEE1lyQD NIFLEZ0983PyzB0VfWwZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669221205; x= 1669307605; bh=0HjNkEY+EDRARgKuZfYD3Us3TDMuMDiM07FGkEyvlGc=; b=a I6zwrl2vPqmdV/GjZBKSWD+EEQgYs6ZKcB3KJu4GmbMY9My5rI6h3T2/K8Qn1v4g LNpUTpWX600otWpNkgwc1XAl2azDlgbI6E3k7vFyfRrNfYDbhRgBoPZl7uVYNvLo 8YoFPUwKz9EVQNReXzz4LhrxhAUGRQ/mdr5E4L08aPvYzsLCvivgQvP3jvqDOKp1 jC578kIb27fvsTQX1iKbuleevopLzWe8G3fofm5HbOFERJBbDZOuf1MIGqp5Wc+N p+lcnLnCb0dvMCftW9WOcxa9myh3cA2pvK8vw5VkMTnGF29gzpu3QDMthfoNF6Im stQi4dogmOsFj/6caEvNw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedriedugdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepueelueefffejffekkeeuheeugfduueekheevueelteegudeludfh tdehtefftdeunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Nov 2022 11:33:24 -0500 (EST) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH] devtools: fix checkpatches subject retrieval from stdin Date: Wed, 23 Nov 2022 17:33:21 +0100 Message-ID: <3162672.aV6nBDHxoP@thomas> In-Reply-To: <20220929120403.352-1-olivier.matz@6wind.com> References: <20220929120403.352-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 29/09/2022 14:04, Olivier Matz: > When passing the patch to checkpatches.sh through stdin, the subject is > retrieved by reading the input until a "Subject:" entry is found. The > rest of the input is piped to checkpatch.pl. > > Since the "From:" line is before the "Subject:" line, it won't be sent to > checkpatch.pl, which won't be able to get the author of the commit. > The following error will appear: > > > ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author '' > > Do the subject lookup on the temporary file instead of stdin, and > send the whole lines to checkpatch.pl. > > The problem is visible since the introduction of this check in linux > checkpatch.pl in version 4.19 (see link below). > > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd2614967d8b > Fixes: 8005feef421d ("scripts: add standard input to checkpatch") > CC: stable@dpdk.org > > Signed-off-by: Olivier Matz Reviewed-by: Thomas Monjalon Applied, thanks.