DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Junxiao Shi <git@mail1.yoursunny.com>,
	"Loftus, Ciara" <ciara.loftus@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH] net/af_xdp: fix custom program loading with multiple queues
Date: Fri, 11 Mar 2022 09:01:49 +0100	[thread overview]
Message-ID: <3163221.44csPzL39Z@thomas> (raw)
In-Reply-To: <PH0PR11MB479175AABC5A44CAC99874F98E0B9@PH0PR11MB4791.namprd11.prod.outlook.com>

10/03/2022 09:49, Loftus, Ciara:
> > When the PMD is configured to load a custom XDP program, it sets
> > XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag to prevent libbpf from
> > loading its default XDP program. However, when queue_count is set to
> > greater than 1, this flag is only set for the first XSK socket but not
> > for subsequent XSK sockets. This causes XSK socket creation failure.
> > 
> > This commit ensures that XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag is
> > set for all XSK socket creations when custom XDP program is being used.
> > 
> > Fixes: 01fa83c94d7e ("net/af_xdp: workaround custom program loading")
> > 
> > Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
> 
> Thanks for the patch!
> It's probably too late to make it into 22.03 but cc-ing stable as it should be backported to 21.11.x.
> 
> Acked-by: Ciara Loftus <ciara.loftus@intel.com>

I can take it in -rc4. How much are you confident there is no regression?




  parent reply	other threads:[~2022-03-11  8:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 21:18 Junxiao Shi
2022-03-10  8:49 ` Loftus, Ciara
2022-03-10  9:41   ` Kevin Traynor
2022-03-11  8:01   ` Thomas Monjalon [this message]
2022-03-11 11:12     ` Loftus, Ciara
2022-03-14  8:41       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3163221.44csPzL39Z@thomas \
    --to=thomas@monjalon.net \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=git@mail1.yoursunny.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).