From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CCA242C05; Thu, 1 Jun 2023 17:19:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D97B40DDC; Thu, 1 Jun 2023 17:19:55 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id B229B406BA for ; Thu, 1 Jun 2023 17:19:53 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 50F0B5C0144; Thu, 1 Jun 2023 11:19:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 01 Jun 2023 11:19:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1685632793; x=1685719193; bh=5L9qpMeGRG+Q5pQR25IpB48b6MBsWnBhO93 kXo55yAg=; b=FOmn6P4vVlC4E3ntSYH2w3Si3tpECY64afRdCMmkPw410dHbk0a 5JVNl8j4BLcTJnFtWpKCDkRl/kd7cS8JQB6k3Kep7GGwVNpWG6KhuOvtuBgRLACg YjaypeK2PC/iS4r4JBQwMyRG+EHgH/epINi1bCRmZHt7s59Y4oF9F08EMAzqxMwz wHLoA1Fcv8RJ/MjXb22AnS2dr8B/MG6X85iZfO4kFwe2nPwfGFBgNKqAeMWrZVvL 1i4EyDtwUbD4wbAybJfZXyvc4i71JUhAFPTIH4pfJ1DomrCva7LWSwvzO4K18mM/ q2vZzfn6T4Z+1+PP006JzUas0hrqn7VEftg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685632793; x=1685719193; bh=5L9qpMeGRG+Q5pQR25IpB48b6MBsWnBhO93 kXo55yAg=; b=cs0uNmZJQ23F22ikPsB4DL7BwGmKTryw+YB64BSbWrWekzLo7Qo TvoQGbZDE3Za5l56T++U3gH4yVh9B/JtlorAAG7UmDrOMZSvK6YuA6ES9Hoogusi qRz+2H8AZjEYurKvJhvIUh4HPvdNp7Oo4LyIh2Y8jWTpy3y7u+HwNFRGjLu1z57z xKRrmCoK2oPjFhvD8xo+Y8fiiQ+I/7LIdkvklS/Ur3FjLRGxYKtENGgCVXReRLgu eJHR0MAwmUJ0U89mXjO9kt3jxsi3Uca68U8nvFYXGpc7cG4UZOl8Am1SynCaRLsv /yuuvoyPvPhvm/oX6iHt8f05M1F9/uq8nbg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeluddgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Jun 2023 11:19:52 -0400 (EDT) From: Thomas Monjalon To: Volodymyr Fialko Cc: dev@dpdk.org, Reshma Pattan , jerinj@marvell.com, anoobj@marvell.com, bruce.richardson@intel.com, stephen@networkplumber.org, roretzla@linux.microsoft.com Subject: Re: [PATCH v2] reorder: improve buffer structure layout Date: Thu, 01 Jun 2023 17:19:50 +0200 Message-ID: <3165123.NnENhoQgcM@thomas> In-Reply-To: <20230417091233.1406974-1-vfialko@marvell.com> References: <20230414084344.271602-1-vfialko@marvell.com> <20230417091233.1406974-1-vfialko@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/04/2023 11:12, Volodymyr Fialko: > Rearrange the reorder buffer structure to prevent padding to extra one > cache line. > > Current layout: > struct rte_reorder_buffer { > char name[RTE_REORDER_NAMESIZE]; > uint32_t min_seqn; > unsigned int memsize; > // -> padding to cache align (cir_buffer is also cache aligned) > struct cir_buffer ready_buf; > struct cir_buffer order_buf; > int is_initialized; > // -> padding to cache align, eat whole line > }; > > New layout: > struct rte_reorder_buffer { > char name[RTE_REORDER_NAMESIZE]; > uint32_t min_seqn; > unsigned int memsize; > bool is_initialized; > // -> padding to cache align (cir_buffer is also cache aligned) > struct cir_buffer ready_buf; > struct cir_buffer order_buf; > // -> no padding > }; > > Signed-off-by: Volodymyr Fialko > Acked-by: Bruce Richardson Applied, thanks.