From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 74BE519F5 for <dev@dpdk.org>; Mon, 12 Mar 2018 09:58:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2018 01:58:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,460,1515484800"; d="scan'208";a="181892332" Received: from kbraniew-mobl.ger.corp.intel.com (HELO [10.252.16.99]) ([10.252.16.99]) by orsmga004.jf.intel.com with ESMTP; 12 Mar 2018 01:58:02 -0700 To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, dev@dpdk.org Cc: keith.wiles@intel.com, konstantin.ananyev@intel.com References: <a9cae982af2307c7fa59406723bca84004de5ff6.1520000413.git.anatoly.burakov@intel.com> <cover.1520424998.git.anatoly.burakov@intel.com> <e12740bd3daa6c2237f1a300edf4e7f49b3eb8cd.1520424998.git.anatoly.burakov@intel.com> <ffb7f257-e88d-13b9-3082-6241ecd921bf@intel.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <31652ac7-5951-a358-18df-2eb87c5abce8@intel.com> Date: Mon, 12 Mar 2018 08:58:00 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <ffb7f257-e88d-13b9-3082-6241ecd921bf@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 6/6] eal: ignore messages until init is complete X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 12 Mar 2018 08:58:05 -0000 On 12-Mar-18 1:42 AM, Tan, Jianfeng wrote: > > On 3/8/2018 12:56 AM, Anatoly Burakov wrote: >> If we receive messages that don't have a callback registered for >> them, and we haven't finished initialization yet, it can be reasonably >> inferred that we shouldn't have gotten the message in the first >> place. Therefore, send requester a special message telling them to >> ignore response to this request, as if this process wasn't there. > > Two nits: > - I think we could add a note in commit log that "it only applies to > primary to secondary request". > - To make the change more simple, maybe we can just put a declaration of > function mp_send. > >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> > > Acked-by: Jianfeng Tan <jianfeng.tan@intel.com> > Makes sense, will do for v6. Thanks for the reviews! -- Thanks, Anatoly