From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 571D9A04B1; Wed, 23 Sep 2020 22:47:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 250FD1DB36; Wed, 23 Sep 2020 22:47:57 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 71A651DB26 for ; Wed, 23 Sep 2020 22:47:55 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id D28225C0109; Wed, 23 Sep 2020 16:47:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 23 Sep 2020 16:47:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= o0mxCu4KqcXKOUUeqehqJ7vsffAFAjQticWw5wccifM=; b=khXvHM9v47xHL5JP xAth06vlRYqKocIMMKDKhJF8Tzt9VGOr0JeG+3TfcpxpuH9QPXWndYKrspq/3J9p KNUMw+zNx5eA8ycepYCx4cr5QJYftJhiDHtqgw9UfmKZSOPOqYW28hJKmZ2/ywwH d/fRzJy5b9bbFTdisdVLr6yWSfX2q/uy3tm9oewJlCpmi/xlRKvFFbADmHii7yNO iGHIaS6OLgiuWooagAv2HMROiEZWFh5mRo+2oGpQyhdITtxZeQ14Gbr4YyVujPKb jQOEV8hVdGUqB9GAbXKMSwVTYAVZrfw2rpSq0ec3sxuDz0uDdd9w59EZpS3EKF3e cfJitA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=o0mxCu4KqcXKOUUeqehqJ7vsffAFAjQticWw5wcci fM=; b=Cshk6acInEKHfukcE3OfNLCTCc9noKxpQ2mn/MaNXnT7J/zSHk+YBvYJQ ++jZhr1EFKl+OG3EItErURVNFR8TN5jaWp1axejUFow3Qa7fO9f3IFYoHAwetmo+ Oi+KVOqyez5BxJeAM76REabqpMI099OwGMUNuVfhhcNExSKuS7UEZvnBewVT+dVV qZoFYRFMYwBEGmxBNeLHBrkcqvBlghlIrWiduww8+O4WLRcY0oZwjxyzzPXVa3+L YJOnvA7OkWr/+Rm8Lim9Kx8g7AaiNCb87kPaQDhQsYf/16/bA7OxvF46SyAWl9pZ CqBADITelJm2cXOe/OrU28cJJ7nRA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeigdduheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E3150306467D; Wed, 23 Sep 2020 16:47:52 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, arybchenko@solarflare.com, Tetsuya Mukawa , Anatoly Burakov Date: Wed, 23 Sep 2020 22:47:51 +0200 Message-ID: <3167472.YmleaKYWZ9@thomas> In-Reply-To: <736c2ece-136d-19d0-e7bf-a23f5382a36f@intel.com> References: <20200913220711.3768597-1-thomas@monjalon.net> <20200913220711.3768597-11-thomas@monjalon.net> <736c2ece-136d-19d0-e7bf-a23f5382a36f@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 10/20] net/null: release port upon close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/09/2020 18:44, Ferruh Yigit: > On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > > The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources > > can be freed by rte_eth_dev_close(). > > > > Signed-off-by: Thomas Monjalon > > --- > > --- a/drivers/net/null/rte_eth_null.c > > +++ b/drivers/net/null/rte_eth_null.c > > +static int > > +eth_dev_close(struct rte_eth_dev *dev) > > +{ > > + PMD_LOG(INFO, "Closing null ethdev on NUMA socket %u", > > + rte_socket_id()); > > + > > + /* mac_addrs must not be freed alone because part of dev_private */ > > + dev->data->mac_addrs = NULL; > > + > > + return 0; > > +} > > should check 'RTE_PROC_PRIMARY' in 'eth_dev_close()'? Yes, looks to be a miss for this new function.