From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FC4A45CE2; Tue, 12 Nov 2024 03:25:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1751F402C3; Tue, 12 Nov 2024 03:25:47 +0100 (CET) Received: from fout-b6-smtp.messagingengine.com (fout-b6-smtp.messagingengine.com [202.12.124.149]) by mails.dpdk.org (Postfix) with ESMTP id 09629400D6 for ; Tue, 12 Nov 2024 03:25:44 +0100 (CET) Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id E8A2711401CA; Mon, 11 Nov 2024 21:25:43 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Mon, 11 Nov 2024 21:25:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731378343; x=1731464743; bh=Odecs2Xh8WmGvmwqCHwPfo3MGfwZOetNqOad5cmxm1k=; b= I3bjLTcTdRmaxe+nT9AcYcrIV8TFVU9HZ/FDaRGspNV2Vv6xzOLSGncroAsEwl70 8T9B4qOqK404aPeYhrA0Kg+S40DP6jzUQHEVG91K6CYapMd0intFJQxWUb7cK5rf p94f+ECHVGRqx4RQbtG/CtqhrWubqxs/NFtQdvuaxJffVL5Z2JB/QFjE3Avn7Gdg KCC+zTLcOvgg2lPN0FU3mBYa+vC4AqornqfxgU9IuhDMzGYEcfz3HKLQRRGUHoDg SWlpF6xeVjil4dlxafBGDdZ0FMpYSGLu3lp24Uf6FKM+PCvsAZZQcDM2izzzyAoR EhwfyT0X0SWStZNPACz6mA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731378343; x= 1731464743; bh=Odecs2Xh8WmGvmwqCHwPfo3MGfwZOetNqOad5cmxm1k=; b=b hvFHUIv9cqCnyMm1GzwPMgmQbefyigmHcrwEwdWt95lURvZR6j1qG2U0hQ3NjqLA yXiZqD4F2a3Lqh6wov4NcAfFe/QN170aCWSMdCavEzyM0Mpeus7hMXEBFQejGoxj EssySxRyGSeaGa8UemdLLQPE4IHfUzzfPcL9aOyLuBf0pqG9kyFGGGsdOMye6loU Fcd2RGa6AD/X62DWU512sP6LebLXzu4eDTEhUhsUW491spoVBZfoTUfe62vNzjVY GdlfE1Ebx91pqPGniXHD+x+f+751RYfyJqOy4qgIK5g2okLTYgROnzNhqtQY2Xff Xw6dXrZOyWolG8mCFyouQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudefgdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdeh vedtkeeivdeuuedvieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohepuddvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehmsgessh hmrghrthhshhgrrhgvshihshhtvghmshdrtghomhdprhgtphhtthhopeguvghvseguphgu khdrohhrghdprhgtphhtthhopehrohhrvghtiihlrgeslhhinhhugidrmhhitghrohhsoh hfthdrtghomhdprhgtphhtthhopehfvghrrhhuhhdrhihighhithesrghmugdrtghomhdp rhgtphhtthhopegrnhgurhgvfidrrhihsggthhgvnhhkohesohhkthgvthhlrggsshdrrh hupdhrtghpthhtoheprghjihhtrdhkhhgrphgrrhguvgessghrohgruggtohhmrdgtohhm pdhrtghpthhtohepshhomhhnrghthhdrkhhothhurhessghrohgruggtohhmrdgtohhmpd hrtghpthhtohepsghruhgtvgdrrhhitghhrghrughsohhnsehinhhtvghlrdgtohhmpdhr tghpthhtohepghhrihhvvgesuhdvheeirdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Nov 2024 21:25:40 -0500 (EST) From: Thomas Monjalon To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: dev@dpdk.org, Tyler Retzlaff , Ferruh Yigit , Andrew Rybchenko , Ajit Khaparde , Somnath Kotur , Bruce Richardson , Gaetan Rivet , Jie Hai , Long Li , Wei Hu Subject: Re: [PATCH 0/2] ethdev: support single queue per port Date: Tue, 12 Nov 2024 03:25:36 +0100 Message-ID: <31679149.gRfpFWEtPU@thomas> In-Reply-To: <20241025115223.1230680-1-mb@smartsharesystems.com> References: <20241025115223.1230680-1-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 25/10/2024 13:52, Morten Br=C3=B8rup: > When configuring DPDK for one queue per port > (#define RTE_MAX_QUEUES_PER_PORT 1), compilation of some network drivers > fails with e.g.: >=20 > ../drivers/net/bnxt/bnxt_rxq.c: In function 'bnxt_rx_queue_stop': > ../drivers/net/bnxt/bnxt_rxq.c:587:34: error: array subscript 1 is above = array bounds of 'uint8_t[1]' {aka 'unsigned char[1]'} [-Werror=3Darray-boun= ds=3D] > 587 | dev->data->rx_queue_state[q_id] =3D RTE_ETH_QUEUE_STATE_S= TOPPED; > | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ > In file included from ../drivers/net/bnxt/bnxt.h:16, > from ../drivers/net/bnxt/bnxt_rxq.c:10: > ../lib/ethdev/ethdev_driver.h:168:17: note: while referencing 'rx_queue_s= tate' > 168 | uint8_t rx_queue_state[RTE_MAX_QUEUES_PER_PORT]; > | ^~~~~~~~~~~~~~ >=20 > This series fixes those compiler emitted errros as follows: > 1. A precondition hint macro is introduced, which can be used to prevent > the compiler/optimizer from considering scenarios that cannot occur. > 2. The hint is added to the network drivers where a compiler in the CI has > been seen to emit the above error when DPDK is configured for one queue > per port, but we know that the error cannot occur. >=20 > Morten Br=C3=B8rup (2): > eal: add unreachable and precondition hints > drivers/net: support single queue per port Applied, thanks.