From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EFF7A0C46; Fri, 18 Jun 2021 10:58:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9635040150; Fri, 18 Jun 2021 10:58:16 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 9DCE740142 for ; Fri, 18 Jun 2021 10:58:14 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 367185C0152; Fri, 18 Jun 2021 04:58:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 18 Jun 2021 04:58:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= dzAUUYbFNMB/UVAKfCCG5aX6lHVcXsQFyvlcu8c9l1w=; b=QVD4L3gF2OY3mql2 2JgV8QS9zFo7QWvWjOC8LG3GRLBM9CZ9n0sf4qjH2hcd7gF48ULbNMMy/rtoyE9E /VAt+eQIOFYZkLJszIslAju5DmUKEqKNCNHwoXud4Os+9Q0+Dt6SNvTopAtcFnqW ji1adZXoSvdMfaLCltu9V1/Blncml47QaTk9l4HMAwbClh8owo3h1Yi/vrendNK7 z5HSu0lg4L6xZ88Ifj2vhmDfTuCUpyvTHyOEKotXILBT7ud7jHT3a47J4d4GFq6a 7UJPtGi03NunAantXirr+lD/bKtwyMi+AVXigI47zCrohVaVuoII09OKMuaS3ZAf WFDR9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=dzAUUYbFNMB/UVAKfCCG5aX6lHVcXsQFyvlcu8c9l 1w=; b=i3ppITIlATY+x7+f11l3mrgMkXsvdpK9TJNGKUw7jffkE6x+vO9f/lb90 OegccEK4GtzsijcawzaoDMQPy3fgWoQ19+d45ZTVznxen3zI+b3bTBJ33pM3tYym 6FzOI9IDQY3m+qMRpMZ6KQ0SZoZH1YgCg7+qvieeXfDLd4f00UFVMk4XNz6m/cmH iZ5vSNJGkvQ4DX0GoxwYIIiCyckEzlw+0Ajs6icmCSLVWlqryuFa0eRwnpHSO7tM 6X7KdQ4ujqW/0Wjme1CNpT9Pji/3X72AfX5OLK9sc3qaJawkN4lNRtrLqYAOQK0x LWTJkNuEEzwuG9QqVDeELi8/mQDug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeffedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Jun 2021 04:58:11 -0400 (EDT) From: Thomas Monjalon To: Ruifeng Wang , Thierry Herbelot Cc: "dev@dpdk.org" , "jerinj@marvell.com" , Honnappa Nagarahalli , Juraj =?utf-8?B?TGlua2XFoQ==?= , nd Date: Fri, 18 Jun 2021 10:58:09 +0200 Message-ID: <3167957.VrzZcUUg0p@thomas> In-Reply-To: References: <1b58faa5588ee2add217208ef10716ae78c4e52b.1623930249.git.thierry.herbelot@6wind.com> <17848474.vh7KFhE8Hu@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/06/2021 10:53, Thierry Herbelot: > On 6/18/21 10:51 AM, Thomas Monjalon wrote: > > 18/06/2021 04:09, Ruifeng Wang: > >> From: Thierry Herbelot > >>> 'part_number_config': { > >>> - '0xc00': {'machine_args': ['-march=armv8-a+crc']} > >>> + '0x800': {'machine_args': ['-march=armv8-a+crc']}, > >>> + '0xc00': {'machine_args': ['-march=armv8-a+crc']}, > >> Nit, redundant comma at the end of the line. > > > > What is redundant? > > The comma at the end of the second line is not necessary. It is a good practice to have comma like other lines, so no need to update this line when adding more.