From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id DBDB7A0548;
Tue, 22 Jun 2021 23:12:50 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1A7B340141;
Tue, 22 Jun 2021 23:12:50 +0200 (CEST)
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
[64.147.123.21])
by mails.dpdk.org (Postfix) with ESMTP id 31C074003E;
Tue, 22 Jun 2021 23:12:48 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
by mailout.west.internal (Postfix) with ESMTP id E0948B56;
Tue, 22 Jun 2021 17:12:46 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute3.internal (MEProxy); Tue, 22 Jun 2021 17:12:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
VkosuYikyAP1kWPbo3rGoGB8mh71Ma4orP8sJzrukxQ=; b=W1S3+9auIKwwxSFT
2bF8WmNGcSwmRp4q5neje70DoDQRwKhXEzCRF0DIEO9IiSNzRY050CLeQL/yI0dU
ozlxNKkzvKnw5SW04fQy9GmSiw+kN9trs2Q+BwKc1lrR1DYosS4b+g6U66zU8JNQ
eKMQGoUbJK7IvPORcas96DUGYq5y4kEnR919/AAN+KLzwKwcGm6mybWqgcDuOYVr
/e4nFt22NSsrBL2zukmNg8zHnzdOY0tGshb9b+pbwmXtZIiGtHxgnolest1OnbTP
J/vKwcPRvNMSHZGa/Pdk7/tiO+phs/nd5tHDy4Ged6/K6+CX41EpV2qsczJHO1vR
QMEHDA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=VkosuYikyAP1kWPbo3rGoGB8mh71Ma4orP8sJzruk
xQ=; b=drHNHqxCC0L390pKlCIhBZnllXJ7qXG8vIOYMtDiCzfgYInXA1v3qXpXB
5G27y24W/XgVkhMiozaOJqxIuCxLig/fx0ij2HrppXOatz2JF1ZKI0ctnbm+4yfW
i7r0Ixnbpo+cDDTSR5mpwQDkdwAhNCuUJtGU1w4eWP2WrKG8z3QrQSfvrfEI6Wu2
RZXG6nexoeURDMV3GtuQ/z8Vf9O/XmH/5MhzX4mHYAWSNtamTKZuC3WaYcLgpwZu
BpNiwrBxLGrEnsg5ENYwcMxifWSvIzExACFi6GyhKlvTOoJ6Xyu1iBokNkAT/r2+
wv9FcYRYum/xLN1NUrXf1wLcm1f2A==
X-ME-Sender: <xms:TlLSYPgtgqa_u5OnJjRAcr3sYlbzB3aZ2yElX3HpqE_OafWHzvmK7g>
<xme:TlLSYMB-UJMaxQT040gx5b-kgyVtaXE6jMWwAMSCBhj-x4SPJ_FRRh12Zf9SpvOxj
k2nw3ZTzz4dld4Bkg>
X-ME-Received: <xmr:TlLSYPHPhlvZu3_sTjfZihT95VsR07Sy_umackbTECXNZk8teu9BFka0j_BC8nEkVz5cfnyMHZJzJDrlKyujwjf6ng>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeguddgudehjecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:TlLSYMR7SAx69ce5ro8tFO3LuB3NXsAID598Cg74Byy91eFCMLNfwg>
<xmx:TlLSYMyOAqcFtmtdmsXqGfG2u69UdXjzp8EsUO_XWVOGl5QmsL_sTQ>
<xmx:TlLSYC6xWHVZXP7xlYt3_hDHdeJelbwuuhcKLK3GroXhIkrji85ofg>
<xmx:TlLSYH8pTDKR9G8bku82LYAqBvVydyr2K2BsfTlryR-oczesKgwrJA>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
22 Jun 2021 17:12:45 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>
Date: Tue, 22 Jun 2021 23:12:43 +0200
Message-ID: <3168706.SJkJIDuJnI@thomas>
In-Reply-To: <YMtaYk5ZZVRaKxD8@bricha3-MOBL.ger.corp.intel.com>
References: <20210617141815.93367-1-kevin.laatz@intel.com>
<YMtaYk5ZZVRaKxD8@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] raw/ioat: fix missing ring
pointer reset
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
17/06/2021 16:21, Bruce Richardson:
> On Thu, Jun 17, 2021 at 02:18:15PM +0000, Kevin Laatz wrote:
> > In the event of a device reconfigure, "hdls_avail" is not being reset. This
> > can lead to miscalculations in rte_ioat_completed_ops(), causing the
> > function to report an incorrect amount of completed operations. This patch
> > fixes the issue by resetting "hdls_avail" during the device configure.
> >
> > Fixes: 74464005a2af ("raw/ioat: rework SW ring layout")
> >
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> > ---
> To catch more of these reconfigure issues, we should look to add an
> appropriate unit test.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org
Applied, thanks