From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21A9FA0487 for ; Sun, 30 Jun 2019 23:50:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FCFC1BA9F; Sun, 30 Jun 2019 23:50:39 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 09DD81B9E5; Sun, 30 Jun 2019 23:50:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 942F921C39; Sun, 30 Jun 2019 17:50:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 30 Jun 2019 17:50:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=2jbr2NstMeiqbpaIUzr1souDeBMSotLRZvcrLPoD8sM=; b=KBg8bAPVN3/j unl8kO6uQK4lbHo1IjK7wvI8ENX4fhW1IM3ASXt9ZlqnaRA27tnIp/bVb7oislYS ShWFNiuybPY62PgjybOzQAicIwrWaz3r2R/nqb2CZSysSuYksRbF9pzHGfa4yMcG g6rhTrcBlfkk33c8F1vTHlYgFbuEZ14= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=2jbr2NstMeiqbpaIUzr1souDeBMSotLRZvcrLPoD8 sM=; b=xFtFxVvDTsAUDi8JOHkb+dJjpzD0a/BmjWq21aA+T4wnTCe+ZPJFmbV8Q y7incX9H6WJYdJ3XNwi02xp+fpgbxSDz6aFfIZpQ9Oxf1CPSTSShf17ODLkfKtOv p8zVs64E0fwFFeXE/c6Zt+8SbiQsjnpCU4yt/eb5uBmNGXo7EHjPDRl9xX53G5O5 onHmkpJY7CPreBje9rhPQk3L1w9OZ6hghsHw7i01vdeQ5UtBv6WbDVO4AQOFY2XR leqgydFyixK1nQCsHpNE75FK+HmMFDCiA90a3zbexoc/HgkpRmN85rM/CTj4vryz +jgtUaZMKUvh58TmQBKbmVzxI1OPA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvdehgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 87DE380061; Sun, 30 Jun 2019 17:50:34 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Wei Zhao Cc: stable@dpdk.org, dev@dpdk.org, bernard.iremonger@intel.com Date: Sun, 30 Jun 2019 23:50:32 +0200 Message-ID: <3169691.2REKQABzIT@xps> In-Reply-To: <62d5ba5d-fcad-0f16-ed73-c7d89a5f735f@intel.com> References: <1557477677-54876-1-git-send-email-wei.zhao1@intel.com> <1560146823-57155-1-git-send-email-wei.zhao1@intel.com> <62d5ba5d-fcad-0f16-ed73-c7d89a5f735f@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: remove port stop check for macsec X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/06/2019 19:23, Ferruh Yigit: > On 6/10/2019 7:07 AM, Wei Zhao wrote: > > There is no need to do such a check when set macsec for ixgbe, and > > reconfig_device_queueand is also useless. If we do not delete this > > unnessary code, users have to stop port before enable or disable > > macsec, then restart this port after make configuration. All these > > process are useless. As this cmdline is a private API which is only > > used by ixgbe NIC, so remove it. > > > > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Zhao > > Tested-by: Peng Yuan > > Acked-by: Bernard Iremonger > > Applied to dpdk-next-net/master, thanks. I disagree with the purpose of this patch. It is removing some "generic" code with the argument that it is not needed in the case of ixgbe, and ixgbe is the only user. We may (and probably will) have other PMDs using this command, so the argument is not OK. I do not merge this patch in master for now. Sorry for the inconvenience.