DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Ye, MingjinX" <mingjinx.ye@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Zhou, YidingX" <yidingx.zhou@intel.com>,
	"Ye, MingjinX" <mingjinx.ye@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [PATCH v3] net/iavf: add debug checks for mbuf
Date: Sun, 19 Feb 2023 15:30:11 +0100	[thread overview]
Message-ID: <3171710.l52yBJDM9G@thomas> (raw)
In-Reply-To: <DM4PR11MB5994891EF974C5A357F96E82D7A79@DM4PR11MB5994.namprd11.prod.outlook.com>

19/02/2023 09:30, Zhang, Qi Z:
> From: Mingjin Ye <mingjinx.ye@intel.com>
> > 
> > The scalar Tx path would send wrong mbuf that causes the kernel driver to
> > fire the MDD event.
> > 
> > This patch adds mbuf detection in tx_prepare and enables it by defining
> > `RTE_ETHDEV_DEBUG_TX` macro to fix this issue. If validation fails, rte_errno
> 
> This is a debug utility but not a fix, enable this check will significantly downgrade the performance
> Removed  "to fix this issue"
> 
> > will be set to EINVAL and returned.
> > 
> > Fixes: 3fd32df381f8 ("net/iavf: check Tx packet with correct UP and queue")
> > Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction")
> > Fixes: f28fbd1e6b50 ("net/iavf: check max SIMD bitwidth")
> 
> Removed all the fix lines
> 
> > Cc: stable@dpdk.org

I think the "stable line" should be removed as well.
It is a new debug feature, we should not try to backport it.




      reply	other threads:[~2023-02-19 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 10:06 [PATCH] net/iavf: add check " Mingjin Ye
2023-02-02 10:03 ` [PATCH v2] " Mingjin Ye
2023-02-07  8:57   ` Ye, MingjinX
2023-02-13  8:31   ` [PATCH v3] net/iavf: add debug checks " Mingjin Ye
2023-02-19  8:30     ` Zhang, Qi Z
2023-02-19 14:30       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3171710.l52yBJDM9G@thomas \
    --to=thomas@monjalon.net \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=mingjinx.ye@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=yidingx.zhou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).