From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DE8A41CDE; Sun, 19 Feb 2023 15:30:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8EC742D16; Sun, 19 Feb 2023 15:30:16 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id AB23F40698; Sun, 19 Feb 2023 15:30:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D23BC5C00EA; Sun, 19 Feb 2023 09:30:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 19 Feb 2023 09:30:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676817014; x= 1676903414; bh=n2B5qqTcPAoygo2FVYnJ3FW9sRnfYx9TP+vHvhzvZwI=; b=X f0ZDhr3wa3X6gn1JkqSgB1UtLQ+O5upY1OEw75qC5LHbkSWeRNCwPERqnu11KcPe Le4EVnTG8yISVxKP1LiZVNrIFaQ8gFNOySkNAVyN1zNasmK12mQEyUzp6zeKZb7h 0e+qsqx1EIhDhU08L34lp33Vz5X3mrsjql9t1+qbvHVRNDB6pOS6T7yCBy23/0r0 8vaeZB5hJnJ9IXja3TxJHvoMYAfjJmNvQtj91X0iOrxkTszwKj6yRj6muht3KNd8 CwfEGpeXKn0rKqoYx/urfw/fN8/I8gwwg0riziW25LdiYmYLde7xJUDqfyMpY1hB cowUmWqwfX1f1UUSjA3rQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676817014; x= 1676903414; bh=n2B5qqTcPAoygo2FVYnJ3FW9sRnfYx9TP+vHvhzvZwI=; b=V n2As1vZpqtmaCmEUm8V1BlraRM9qNGmL+/Vh64OhfDbbYsbxUzjyAusdfru0trQv ckhtOCYZezm8udmsnkR5n2f4Ixb4VR83nrM6p3G+nBn/zccx5xjwLvQM+OpzJYua atLa4ozve93YQ8yB2qVWohNEZucaoRT31fHw15uB0mM4ZDWzToPC79ZhhwBHkemV kBwQhKlqo8DbIw7ePzHnxWZ+wvA/EA/rinavYMuaEXXGvpRTZT+oujDC3+9q2MID LKRdJN3IS/iN31Dca8u0FWOQE5YBvVwvSmilIx4qavVIaxFbe5qjYNxuxY02COiq 2yIXdbdBQoA/W2mi0A8Eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejfedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Feb 2023 09:30:13 -0500 (EST) From: Thomas Monjalon To: "Ye, MingjinX" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "Yang, Qiming" , "stable@dpdk.org" , "Zhou, YidingX" , "Ye, MingjinX" , "Wu, Jingjing" , "Xing, Beilei" Subject: Re: [PATCH v3] net/iavf: add debug checks for mbuf Date: Sun, 19 Feb 2023 15:30:11 +0100 Message-ID: <3171710.l52yBJDM9G@thomas> In-Reply-To: References: <20230202100350.668809-1-mingjinx.ye@intel.com> <20230213083150.295194-1-mingjinx.ye@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/02/2023 09:30, Zhang, Qi Z: > From: Mingjin Ye > > > > The scalar Tx path would send wrong mbuf that causes the kernel driver to > > fire the MDD event. > > > > This patch adds mbuf detection in tx_prepare and enables it by defining > > `RTE_ETHDEV_DEBUG_TX` macro to fix this issue. If validation fails, rte_errno > > This is a debug utility but not a fix, enable this check will significantly downgrade the performance > Removed "to fix this issue" > > > will be set to EINVAL and returned. > > > > Fixes: 3fd32df381f8 ("net/iavf: check Tx packet with correct UP and queue") > > Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction") > > Fixes: f28fbd1e6b50 ("net/iavf: check max SIMD bitwidth") > > Removed all the fix lines > > > Cc: stable@dpdk.org I think the "stable line" should be removed as well. It is a new debug feature, we should not try to backport it.