From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0F3CD7CA9 for ; Mon, 4 Sep 2017 12:35:39 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 03:35:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,474,1498546800"; d="scan'208";a="1214451824" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.79]) ([10.237.221.79]) by fmsmga002.fm.intel.com with ESMTP; 04 Sep 2017 03:35:37 -0700 To: Kirill Rybalchenko , dev@dpdk.org Cc: andrey.chilikin@intel.com, beilei.xing@intel.com References: <1503588634-85735-1-git-send-email-kirill.rybalchenko@intel.com> <1503588634-85735-2-git-send-email-kirill.rybalchenko@intel.com> From: Radu Nicolau Message-ID: <31727283-632e-ea3e-edbc-be1e6980be07@intel.com> Date: Mon, 4 Sep 2017 11:35:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1503588634-85735-2-git-send-email-kirill.rybalchenko@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add support for raw flow type for flow director X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 10:35:40 -0000 On 8/24/2017 4:30 PM, Kirill Rybalchenko wrote: > Add new structure rte_eth_raw_flow to the union rte_eth_fdir_flow > to support filter for raw flow type > > Signed-off-by: Kirill Rybalchenko > --- > lib/librte_ether/rte_eth_ctrl.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h > index 8386904..22d9640 100644 > --- a/lib/librte_ether/rte_eth_ctrl.h > +++ b/lib/librte_ether/rte_eth_ctrl.h > @@ -525,6 +525,15 @@ struct rte_eth_tunnel_flow { > }; > > /** > + * A structure used to define the input for raw flow > + */ > +struct rte_eth_raw_flow { > + uint16_t flow; /**< flow type. */ > + void *packet; /**< pre-constructed packet buffer. */ > + uint16_t length; /**< buffer length. */ > +}; Nitpicking on comments alignment. > + > +/** > * An union contains the inputs for all types of flow > * Items in flows need to be in big endian > */ > @@ -540,6 +549,7 @@ union rte_eth_fdir_flow { > struct rte_eth_ipv6_flow ipv6_flow; > struct rte_eth_mac_vlan_flow mac_vlan_flow; > struct rte_eth_tunnel_flow tunnel_flow; > + struct rte_eth_raw_flow raw_flow; > }; > > /**