Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

[Thomas Monjalon <thomas@monjalon.net>]

01/04/2020 21:14, Jerin Jacob:
> On Wed, Apr 1, 2020 at 11:22 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> >
> > On Wed, Apr 1, 2020 at 11:02 PM David Marchand
> > <david.marchand@redhat.com> wrote:
> > >
> > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> > > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand <david.marchand@redhat.com> wrote:
> > > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> > > > > > I assume the patch content will be:
> > > > > > 1) Removing experimental API from app, lib, drivers, examples with
> > > > > > make and meson
> > > > > > 2) Have it enabled at the global level.
> > > > >
> > > > > examples are a special case as they can be compiled out of the dpdk sources.
> > > > > This is why I excluded them of the list in my mail before.
> > > >
> > > > There are a lot of examples already that have ALLOW_EXPERIMENTAL_API.
> > > > What is the issue in enabling ALLOW_EXPERIMENTAL_API  in the in tree
> > > > example application?
> > >
> > > I did not say there is an issue in keeping this flag in the example makefiles.
> > >
> > > examples makefile should be self sufficient (like an external
> > > application makefile would be) and are called directly in our building
> > > test scripts: see devtools/test-meson-builds.sh.
> > > So I don't see how it would work if you remove this flag from all
> > > examples makefiles and rely on some global thing.
> >
> > Thanks for the clarification. I will update meson.build and Makefile in
> > examples.
> >
> > devtools/test-meson-builds.sh tests[1] the the below apps,
> > "cmdline helloworld l2fwd l3fwd skeleton time"
> >
> > What is your preference, Adding in all the examples or above selected ones?
> 
> 
> Since meson installing example application as well. I will update the
> effected examples
> with ALLOW_EXPERIMENTAL_API

I think you need to update all examples.