From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44799A057B; Wed, 1 Apr 2020 21:43:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5E5B1C131; Wed, 1 Apr 2020 21:43:49 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id DA1A21C126 for <dev@dpdk.org>; Wed, 1 Apr 2020 21:43:47 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 040825801C1; Wed, 1 Apr 2020 15:43:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 01 Apr 2020 15:43:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qkMlZLCV5xOBoJ2sx73HQKRtFATUooRtzcYRHBQMn5g=; b=c8Qld+6hgaMS azlc1J70c6U0OrHPPlRZ5jcwKYJa8G9IwJBew1jgcq9ZP8Eoy03ThSu1y2d0jRrh SYgVcgMI8beefsvpqkKCRe6NsFDqbzUblq7bpwF+dq5CfGa5NG4HmXziCFkK+3Po kSDnqCQSJCSSqOJUqw5NsUHwIndj9+Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qkMlZLCV5xOBoJ2sx73HQKRtFATUooRtzcYRHBQMn 5g=; b=qQoW8y8TC+CTxEVQKZudAYE1rZwpZ1kWgSAnJgvUK1umftLyGvYrhBmNS +VgW9nmgeQDHNs7iT0vVlqNynC/x3F11fmxpE4QMZW4wV1Ay/fhBBHCDBGllkGf1 9HJ1XGRKi3zVuD/c4Cw2FQTDYbRx7DZAvF8ALQ3tPqQ9/M5rpFnqGt0YpRDDlYIp xLXHc6b6WrSkJKUq1Su3FxHDYNX/unWlxfktQ2RjqntpVugZA8HLh8UYEqUU3WEI 7fkwUA4Oehp9kzsUnWwf9ytz9AptSY3Nx8Msp+LvtYizWs3HcK34Gu4GZvxHUABp XcdxDsjoJFlcaENAqGO7UvUL44vOw== X-ME-Sender: <xms:8e6EXkmf8c6TjXYcv1O3fuhQ8xVAZxhRcxBCk4Yq1rm2tODFJG0-Eg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtddvgddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:8e6EXlS6Nwl2VJx-rcrOwzKxE1toKaaCpWGNs4fh9mrhvzwtxPw00A> <xmx:8e6EXuAFSMABsOsxmJVUTRR4FvqCCQTUT-qSQzPxIb9pBOMQPsVI0w> <xmx:8e6EXtq00FgxBt4_LHmtHQopLsBItJq34nIb9DC1WfIXmzEYlyQKDg> <xmx:8u6EXmA-iwWPKpfMDGOHd0mG98824nW5JJbFGO8MI_6a_gItt2T_LA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A0A9306CCF5; Wed, 1 Apr 2020 15:43:43 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Jerin Jacob <jerinjacobk@gmail.com> Cc: David Marchand <david.marchand@redhat.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>, Mattias =?ISO-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>, Sunil Kumar Kori <skori@marvell.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Declan Doherty <declan.doherty@intel.com>, Olivier Matz <olivier.matz@6wind.com>, Neil Horman <nhorman@tuxdriver.com>, Ray Kinsella <mdr@ashroe.eu> Date: Wed, 01 Apr 2020 21:43:40 +0200 Message-ID: <3173562.8FI41Ny9JD@xps> In-Reply-To: <CALBAE1PrE3bvbv8tnTPibL_xLVmJ5fEE6wr4iSkHe1NpOqyepw@mail.gmail.com> References: <20200325211603.240288-1-jerinj@marvell.com> <CALBAE1M3nbeFfYe-doEcM_m4aJhHfaOuHG94htd9XXVoDqW7MA@mail.gmail.com> <CALBAE1PrE3bvbv8tnTPibL_xLVmJ5fEE6wr4iSkHe1NpOqyepw@mail.gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 01/04/2020 21:14, Jerin Jacob: > On Wed, Apr 1, 2020 at 11:22 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > > > > On Wed, Apr 1, 2020 at 11:02 PM David Marchand > > <david.marchand@redhat.com> wrote: > > > > > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > > > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand <david.marchand@redhat.com> wrote: > > > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > > > > > > I assume the patch content will be: > > > > > > 1) Removing experimental API from app, lib, drivers, examples with > > > > > > make and meson > > > > > > 2) Have it enabled at the global level. > > > > > > > > > > examples are a special case as they can be compiled out of the dpdk sources. > > > > > This is why I excluded them of the list in my mail before. > > > > > > > > There are a lot of examples already that have ALLOW_EXPERIMENTAL_API. > > > > What is the issue in enabling ALLOW_EXPERIMENTAL_API in the in tree > > > > example application? > > > > > > I did not say there is an issue in keeping this flag in the example makefiles. > > > > > > examples makefile should be self sufficient (like an external > > > application makefile would be) and are called directly in our building > > > test scripts: see devtools/test-meson-builds.sh. > > > So I don't see how it would work if you remove this flag from all > > > examples makefiles and rely on some global thing. > > > > Thanks for the clarification. I will update meson.build and Makefile in > > examples. > > > > devtools/test-meson-builds.sh tests[1] the the below apps, > > "cmdline helloworld l2fwd l3fwd skeleton time" > > > > What is your preference, Adding in all the examples or above selected ones? > > > Since meson installing example application as well. I will update the > effected examples > with ALLOW_EXPERIMENTAL_API I think you need to update all examples.