DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Ye, MingjinX" <mingjinx.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Zhou, YidingX" <yidingx.zhou@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	 "david.marchand@redhat.com" <david.marchand@redhat.com>,
	"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>
Subject: Re: [PATCH] net/ice: fix get link status timeout
Date: Mon, 06 Feb 2023 10:15:52 +0100	[thread overview]
Message-ID: <3175550.aV6nBDHxoP@thomas> (raw)
In-Reply-To: <SN7PR11MB713929848E6477FDFFD44DB6E5DA9@SN7PR11MB7139.namprd11.prod.outlook.com>

06/02/2023 09:14, Ye, MingjinX:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 06/02/2023 07:22, Mingjin Ye:
> > > When hw is just started, it will immediately obtain the link status,
> > > and the longest attempt is 1 second. Some NICs are slow to initialize,
> > > which make it fails to obtain the link status.
> > >
> > > The patch fixes this issue by modifying the longest attempt to 5 seconds.
> > 
> > What is the consequence?
> 
> DPDK could not get link status. At this point, the link status obtained through
> the pmd API is wrong.
> 
> > In which case, DPDK application would be blocked during 5 seconds?
> 
> When the dpdk application startup port is used, it will be blocked for up
> to 5 seconds to ensure that the connection status can be obtained.

I mean what is the consequence of the increase?
For example, if the port is not connected (no wire),
are we going to wait 5 seconds?

I guess it's OK because it won't wait at all if using rte_eth_link_get_nowait.
It may be interesting to note in the commit message.



  reply	other threads:[~2023-02-06  9:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06  6:22 Mingjin Ye
2023-02-06  7:23 ` Thomas Monjalon
2023-02-06  8:14   ` Ye, MingjinX
2023-02-06  9:15     ` Thomas Monjalon [this message]
2023-02-06 10:06       ` Ye, MingjinX
2023-02-06  7:56 韩爽
2023-02-06 10:51 ` Ye, MingjinX
2023-02-07  6:48   ` Yang, Qiming
2023-02-06  8:35 Shuang Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3175550.aV6nBDHxoP@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=mingjinx.ye@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=yidingx.zhou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).